* [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr
@ 2022-08-26 9:34 Daisuke Matsuda
2022-08-26 13:59 ` Yanjun Zhu
0 siblings, 1 reply; 4+ messages in thread
From: Daisuke Matsuda @ 2022-08-26 9:34 UTC (permalink / raw)
To: jgg, zyjzyj2000; +Cc: linux-rdma, rpearsonhpe, lizhijian, Daisuke Matsuda
Commit 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for
FMRs"") brought back the member 'va' to struct rxe_mr. However, it is
actually used by nobody and thus can be removed.
Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
---
drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 850b80f5ad8b..814116ec4778 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -180,7 +180,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
mr->access = access;
mr->length = length;
mr->iova = iova;
- mr->va = start;
mr->offset = ib_umem_offset(umem);
mr->state = RXE_MR_STATE_VALID;
mr->type = IB_MR_TYPE_USER;
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index e264cf69bf55..9ebe9decad34 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -1007,7 +1007,6 @@ static int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg,
n = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, rxe_set_page);
- mr->va = ibmr->iova;
mr->iova = ibmr->iova;
mr->length = ibmr->length;
mr->page_shift = ilog2(ibmr->page_size);
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 96af3e054f4d..a51819d0c345 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -305,7 +305,6 @@ struct rxe_mr {
u32 rkey;
enum rxe_mr_state state;
enum ib_mr_type type;
- u64 va;
u64 iova;
size_t length;
u32 offset;
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr
2022-08-26 9:34 [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr Daisuke Matsuda
@ 2022-08-26 13:59 ` Yanjun Zhu
2022-08-29 1:23 ` [PATCH v2] " Daisuke Matsuda
0 siblings, 1 reply; 4+ messages in thread
From: Yanjun Zhu @ 2022-08-26 13:59 UTC (permalink / raw)
To: Daisuke Matsuda, jgg, zyjzyj2000; +Cc: linux-rdma, rpearsonhpe, lizhijian
在 2022/8/26 17:34, Daisuke Matsuda 写道:
> Commit 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for
> FMRs"") brought back the member 'va' to struct rxe_mr. However, it is
> actually used by nobody and thus can be removed.
>
Missing Fixes?
Zhu Yanjun
> Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
> ---
> drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
> index 850b80f5ad8b..814116ec4778 100644
> --- a/drivers/infiniband/sw/rxe/rxe_mr.c
> +++ b/drivers/infiniband/sw/rxe/rxe_mr.c
> @@ -180,7 +180,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
> mr->access = access;
> mr->length = length;
> mr->iova = iova;
> - mr->va = start;
> mr->offset = ib_umem_offset(umem);
> mr->state = RXE_MR_STATE_VALID;
> mr->type = IB_MR_TYPE_USER;
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
> index e264cf69bf55..9ebe9decad34 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.c
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
> @@ -1007,7 +1007,6 @@ static int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg,
>
> n = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, rxe_set_page);
>
> - mr->va = ibmr->iova;
> mr->iova = ibmr->iova;
> mr->length = ibmr->length;
> mr->page_shift = ilog2(ibmr->page_size);
> diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
> index 96af3e054f4d..a51819d0c345 100644
> --- a/drivers/infiniband/sw/rxe/rxe_verbs.h
> +++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
> @@ -305,7 +305,6 @@ struct rxe_mr {
> u32 rkey;
> enum rxe_mr_state state;
> enum ib_mr_type type;
> - u64 va;
> u64 iova;
> size_t length;
> u32 offset;
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH v2] RDMA/rxe: Remove an unused member from struct rxe_mr
2022-08-26 13:59 ` Yanjun Zhu
@ 2022-08-29 1:23 ` Daisuke Matsuda
2022-08-29 6:48 ` Leon Romanovsky
0 siblings, 1 reply; 4+ messages in thread
From: Daisuke Matsuda @ 2022-08-29 1:23 UTC (permalink / raw)
To: jgg, yanjun.zhu; +Cc: linux-rdma, Daisuke Matsuda
Commit 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for
FMRs"") brought back the member 'va' to struct rxe_mr. However, it is
actually used by nobody and thus can be removed.
Fixes: 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for FMRs"")
Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
---
v2
Added a Fixes tag
drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/infiniband/sw/rxe/rxe_mr.c b/drivers/infiniband/sw/rxe/rxe_mr.c
index 850b80f5ad8b..814116ec4778 100644
--- a/drivers/infiniband/sw/rxe/rxe_mr.c
+++ b/drivers/infiniband/sw/rxe/rxe_mr.c
@@ -180,7 +180,6 @@ int rxe_mr_init_user(struct rxe_pd *pd, u64 start, u64 length, u64 iova,
mr->access = access;
mr->length = length;
mr->iova = iova;
- mr->va = start;
mr->offset = ib_umem_offset(umem);
mr->state = RXE_MR_STATE_VALID;
mr->type = IB_MR_TYPE_USER;
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.c b/drivers/infiniband/sw/rxe/rxe_verbs.c
index e264cf69bf55..9ebe9decad34 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.c
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.c
@@ -1007,7 +1007,6 @@ static int rxe_map_mr_sg(struct ib_mr *ibmr, struct scatterlist *sg,
n = ib_sg_to_pages(ibmr, sg, sg_nents, sg_offset, rxe_set_page);
- mr->va = ibmr->iova;
mr->iova = ibmr->iova;
mr->length = ibmr->length;
mr->page_shift = ilog2(ibmr->page_size);
diff --git a/drivers/infiniband/sw/rxe/rxe_verbs.h b/drivers/infiniband/sw/rxe/rxe_verbs.h
index 96af3e054f4d..a51819d0c345 100644
--- a/drivers/infiniband/sw/rxe/rxe_verbs.h
+++ b/drivers/infiniband/sw/rxe/rxe_verbs.h
@@ -305,7 +305,6 @@ struct rxe_mr {
u32 rkey;
enum rxe_mr_state state;
enum ib_mr_type type;
- u64 va;
u64 iova;
size_t length;
u32 offset;
--
2.31.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] RDMA/rxe: Remove an unused member from struct rxe_mr
2022-08-29 1:23 ` [PATCH v2] " Daisuke Matsuda
@ 2022-08-29 6:48 ` Leon Romanovsky
0 siblings, 0 replies; 4+ messages in thread
From: Leon Romanovsky @ 2022-08-29 6:48 UTC (permalink / raw)
To: Daisuke Matsuda; +Cc: jgg, yanjun.zhu, linux-rdma
On Mon, Aug 29, 2022 at 10:23:35AM +0900, Daisuke Matsuda wrote:
> Commit 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for
> FMRs"") brought back the member 'va' to struct rxe_mr. However, it is
> actually used by nobody and thus can be removed.
>
> Fixes: 1e75550648da ("Revert "RDMA/rxe: Create duplicate mapping tables for FMRs"")
> Signed-off-by: Daisuke Matsuda <matsuda-daisuke@fujitsu.com>
> ---
> v2
> Added a Fixes tag
>
> drivers/infiniband/sw/rxe/rxe_mr.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.c | 1 -
> drivers/infiniband/sw/rxe/rxe_verbs.h | 1 -
> 3 files changed, 3 deletions(-)
>
Thanks, applied.
BTW, please don't send new patches as reply to previous versions.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2022-08-29 6:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-08-26 9:34 [PATCH] RDMA/rxe: Remove an unused member from struct rxe_mr Daisuke Matsuda
2022-08-26 13:59 ` Yanjun Zhu
2022-08-29 1:23 ` [PATCH v2] " Daisuke Matsuda
2022-08-29 6:48 ` Leon Romanovsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox