From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Bernard Metzler <bmt@zurich.ibm.com>,
Leon Romanovsky <leon@kernel.org>,
Ursula Braun <ubraun@linux.ibm.com>,
OFED mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] RDMA: don't ignore client->add() failures
Date: Tue, 28 Mar 2023 13:18:45 -0300 [thread overview]
Message-ID: <ZCMTZWdY7D7mxJuE@ziepe.ca> (raw)
In-Reply-To: <ec025592-3390-cf4f-ed03-c3c6c43d9310@I-love.SAKURA.ne.jp>
On Tue, Mar 28, 2023 at 11:59:48PM +0900, Tetsuo Handa wrote:
> Without this patch, __ib_unregister_device(device) is not called because
> enable_device_and_get() returns 0 because add_client_context() returns 0
> because add_client_context() ignores client->add() faiulures. As a result,
> device's refcount remains 7, which later prevents unregister_netdevice()
> from unregistering this device.
That is completely correct, the device was successfully registered
without one of the clients.
It seems to me all this has done done is make it so the device doesn't
register and that will hide the refcount bug because the bug is
actually something that happens during operation - and we never get to
operation now.
Jason
next prev parent reply other threads:[~2023-03-28 16:18 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 10:52 [PATCH] RDMA: don't ignore client->add() failures Tetsuo Handa
2023-03-28 11:24 ` Jason Gunthorpe
2023-03-28 11:33 ` Tetsuo Handa
2023-03-28 11:34 ` Jason Gunthorpe
2023-03-28 14:59 ` Tetsuo Handa
2023-03-28 16:18 ` Jason Gunthorpe [this message]
2023-03-28 22:17 ` Tetsuo Handa
2023-03-29 15:44 ` Jason Gunthorpe
2023-03-29 23:51 ` Tetsuo Handa
2023-03-30 23:39 ` Jason Gunthorpe
2023-03-31 16:19 ` Tetsuo Handa
2023-03-31 16:23 ` Jason Gunthorpe
2023-04-01 7:30 ` Tetsuo Handa
2023-04-01 18:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCMTZWdY7D7mxJuE@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bmt@zurich.ibm.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox