From: Jason Gunthorpe <jgg@ziepe.ca>
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
Cc: Bernard Metzler <bmt@zurich.ibm.com>,
Leon Romanovsky <leon@kernel.org>,
Ursula Braun <ubraun@linux.ibm.com>,
OFED mailing list <linux-rdma@vger.kernel.org>
Subject: Re: [PATCH] RDMA: don't ignore client->add() failures
Date: Fri, 31 Mar 2023 13:23:32 -0300 [thread overview]
Message-ID: <ZCcJBPbOlmx0he9Y@ziepe.ca> (raw)
In-Reply-To: <747eaa78-5773-c2fd-5a8f-97998a0c9883@I-love.SAKURA.ne.jp>
On Sat, Apr 01, 2023 at 01:19:47AM +0900, Tetsuo Handa wrote:
> On 2023/03/31 8:39, Jason Gunthorpe wrote:
> > Look at siw_netdev_event:
> >
> > case NETDEV_UNREGISTER:
> > ib_unregister_device_queued(&sdev->base_dev);
> > break;
>
> I see. We can observe that
>
> net vlan0: siw: event 6
>
> is emitted for every second, but unfortunately ib_unregister_device_queued() is
> never called because dev_net(netdev) != &init_net is true. Changing like below
> avoids this problem.
>
> I guess that either dev_net(netdev) is not appropriately initialized or
> dev_net(netdev) != &init_net is too restrictive to call ib_unregister_device_queued().
> Where is dev_net(netdev) initialized?
Bernard? What is this net ns check for? It seems surprising this would
be here
Jason
next prev parent reply other threads:[~2023-03-31 16:29 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-28 10:52 [PATCH] RDMA: don't ignore client->add() failures Tetsuo Handa
2023-03-28 11:24 ` Jason Gunthorpe
2023-03-28 11:33 ` Tetsuo Handa
2023-03-28 11:34 ` Jason Gunthorpe
2023-03-28 14:59 ` Tetsuo Handa
2023-03-28 16:18 ` Jason Gunthorpe
2023-03-28 22:17 ` Tetsuo Handa
2023-03-29 15:44 ` Jason Gunthorpe
2023-03-29 23:51 ` Tetsuo Handa
2023-03-30 23:39 ` Jason Gunthorpe
2023-03-31 16:19 ` Tetsuo Handa
2023-03-31 16:23 ` Jason Gunthorpe [this message]
2023-04-01 7:30 ` Tetsuo Handa
2023-04-01 18:30 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZCcJBPbOlmx0he9Y@ziepe.ca \
--to=jgg@ziepe.ca \
--cc=bmt@zurich.ibm.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=penguin-kernel@i-love.sakura.ne.jp \
--cc=ubraun@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox