[PATCH v2 net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28

[PATCH v2 net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28

[Krzysztof Olędzki]

Enable reading additional EEPROM information from high pages such as
thresholds and alarms on QSFP/QSFP+/QSFP28 modules.

"This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add
support for EEPROM high pages query") but given all the required logic
already exists in mlx4_qsfp_eeprom_params_set() only s/_LEN/MAX_LEN/ is
needed.

Tested-by: Dan Merillat <git@dan.merillat.org>
Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl>
---
 drivers/net/ethernet/mellanox/mlx4/en_ethtool.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
index 619e1c3ef7f9..aca968b4dc15 100644
--- a/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
+++ b/drivers/net/ethernet/mellanox/mlx4/en_ethtool.c
@@ -2055,20 +2055,20 @@ static int mlx4_en_get_module_info(struct net_device *dev,
 	switch (data[0] /* identifier */) {
 	case MLX4_MODULE_ID_QSFP:
 		modinfo->type = ETH_MODULE_SFF_8436;
-		modinfo->eeprom_len = ETH_MODULE_SFF_8436_LEN;
+		modinfo->eeprom_len = ETH_MODULE_SFF_8436_MAX_LEN;
 		break;
 	case MLX4_MODULE_ID_QSFP_PLUS:
 		if (data[1] >= 0x3) { /* revision id */
 			modinfo->type = ETH_MODULE_SFF_8636;
-			modinfo->eeprom_len = ETH_MODULE_SFF_8636_LEN;
+			modinfo->eeprom_len = ETH_MODULE_SFF_8636_MAX_LEN;
 		} else {
 			modinfo->type = ETH_MODULE_SFF_8436;
-			modinfo->eeprom_len = ETH_MODULE_SFF_8436_LEN;
+			modinfo->eeprom_len = ETH_MODULE_SFF_8436_MAX_LEN;
 		}
 		break;
 	case MLX4_MODULE_ID_QSFP28:
 		modinfo->type = ETH_MODULE_SFF_8636;
-		modinfo->eeprom_len = ETH_MODULE_SFF_8636_LEN;
+		modinfo->eeprom_len = ETH_MODULE_SFF_8636_MAX_LEN;
 		break;
 	case MLX4_MODULE_ID_SFP:
 		modinfo->type = ETH_MODULE_SFF_8472;
-- 
2.45.2

Re: [PATCH v2 net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28

[Ido Schimmel]

On Tue, Jul 30, 2024 at 05:49:53PM -0700, Krzysztof Olędzki wrote:
> Enable reading additional EEPROM information from high pages such as
> thresholds and alarms on QSFP/QSFP+/QSFP28 modules.
> 
> "This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add
  ^ Nit: s/^\"//

> support for EEPROM high pages query") but given all the required logic
> already exists in mlx4_qsfp_eeprom_params_set() only s/_LEN/MAX_LEN/ is
> needed.
> 
> Tested-by: Dan Merillat <git@dan.merillat.org>
> Signed-off-by: Krzysztof Piotr Oledzki <ole@ans.pl>

Reviewed-by: Ido Schimmel <idosch@nvidia.com>

Re: [PATCH v2 net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28

[Krzysztof Olędzki]

On 31.07.2024 at 01:45, Ido Schimmel wrote:
> On Tue, Jul 30, 2024 at 05:49:53PM -0700, Krzysztof Olędzki wrote:
>> Enable reading additional EEPROM information from high pages such as
>> thresholds and alarms on QSFP/QSFP+/QSFP28 modules.
>>
>> "This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add
>   ^ Nit: s/^\"//

Ouch, do you want me to resend or it can be fixed when applying?

Krzysztof

Re: [PATCH v2 net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28

[patchwork-bot+netdevbpf]

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 30 Jul 2024 17:49:53 -0700 you wrote:
> Enable reading additional EEPROM information from high pages such as
> thresholds and alarms on QSFP/QSFP+/QSFP28 modules.
> 
> "This is similar to commit a708fb7b1f8d ("net/mlx5e: ethtool, Add
> support for EEPROM high pages query") but given all the required logic
> already exists in mlx4_qsfp_eeprom_params_set() only s/_LEN/MAX_LEN/ is
> needed.
> 
> [...]

Here is the summary with links:
  - [v2,net-next] net/mlx4: Add support for EEPROM high pages query for QSFP/QSFP+/QSFP28
    https://git.kernel.org/netdev/net-next/c/9c26a1d0a01c

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html