Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Jiri Pirko <jiri@resnulli.us>
To: Leon Romanovsky <leon@kernel.org>
Cc: linux-rdma@vger.kernel.org, jgg@ziepe.ca, edwards@nvidia.com,
	 kees@kernel.org, parav@nvidia.com, mbloch@nvidia.com,
	yishaih@nvidia.com,  lirongqing@baidu.com,
	huangjunxian6@hisilicon.com, liuy22@mails.tsinghua.edu.cn,
	 jmoroni@google.com
Subject: Re: [PATCH rdma-next v2 2/2] RDMA/umem: block plain userspace memory registration under CoCo bounce
Date: Sun, 17 May 2026 15:59:37 +0200	[thread overview]
Message-ID: <agnJpvWB-tkw-jeg@FV6GYCPJ69> (raw)
In-Reply-To: <20260517115006.GG33515@unreal>

Sun, May 17, 2026 at 01:50:06PM +0200, leon@kernel.org wrote:
>On Fri, May 15, 2026 at 08:13:17AM +0200, Jiri Pirko wrote:
>> Thu, May 14, 2026 at 06:25:06PM +0200, leon@kernel.org wrote:
>> >On Tue, May 12, 2026 at 04:04:13PM +0200, Jiri Pirko wrote:
>> >> Tue, May 12, 2026 at 03:05:15PM CEST, leon@kernel.org wrote:
>> >> >On Wed, May 06, 2026 at 01:14:47PM +0200, Jiri Pirko wrote:
>> >> >> From: Jiri Pirko <jiri@nvidia.com>
>> >> >> 
>> >> >> When a device requires DMA bounce buffering inside a Confidential
>> >> >> Computing guest, __ib_umem_get_va() cannot work. The DMA mapping layer
>> >> >> redirects all mappings through swiotlb bounce buffers, so the device
>> >> >> receives DMA addresses pointing to bounce buffer memory rather than
>> >> >> the user's pages. Since RDMA devices access registered memory directly
>> >> >> without CPU involvement, there is no opportunity for swiotlb to
>> >> >> synchronize between the bounce buffer and the original pages.
>> >> >> 
>> >> >> The registration would already fail later on, since the umem mapping
>> >> >> is requested with DMA_ATTR_REQUIRE_COHERENT and gets rejected under
>> >> >> is_swiotlb_force_bounce() with -EIO. Fail early with -EOPNOTSUPP
>> >> >> instead, so the user gets a specific error code to react to.
>> >> >
>> >> >DMA_ATTR_REQUIRE_COHERENT was our answer to "layering violation claim".
>> >> 
>> >> I'm not sure I follow. What's the issue you see?
>> >
>> >SWIOTLB is the layer below DMA API, RDMA is the layer above DMA API.
>> >You shouldn't call to SWIOTLB functions in RDMA code.
>> 
>> This patch doesn't do that. The patch description only describes the
>> current situation and how the patch changes the behaviour.
>
>From previous patch:
>+       if (dma_device &&
>+           cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT) &&
>+           is_swiotlb_force_bounce(dma_device))
>+               device->cc_dma_bounce = 1;
>
>And this patch reads cc_dma_bounce.

Sure, I got that remark from the reply to the previous patch :) Already
removed. Will send next v soon.

Thanks!

  reply	other threads:[~2026-05-17 13:59 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-06 11:14 [PATCH rdma-next v2 0/2] RDMA: detect and handle CoCo DMA bounce buffering Jiri Pirko
2026-05-06 11:14 ` [PATCH rdma-next v2 1/2] RDMA/uverbs: expose CoCo DMA bounce requirement to userspace Jiri Pirko
2026-05-12 13:03   ` Leon Romanovsky
2026-05-12 14:03     ` Jiri Pirko
2026-05-12 14:05       ` Jason Gunthorpe
2026-05-12 14:08         ` Jiri Pirko
2026-05-12 14:34           ` Jason Gunthorpe
2026-05-12 18:30             ` Jiri Pirko
2026-05-06 11:14 ` [PATCH rdma-next v2 2/2] RDMA/umem: block plain userspace memory registration under CoCo bounce Jiri Pirko
2026-05-12 13:05   ` Leon Romanovsky
2026-05-12 14:04     ` Jiri Pirko
2026-05-14 16:25       ` Leon Romanovsky
2026-05-15  6:13         ` Jiri Pirko
2026-05-17 11:50           ` Leon Romanovsky
2026-05-17 13:59             ` Jiri Pirko [this message]
2026-05-06 12:52 ` [PATCH rdma-next v2 0/2] RDMA: detect and handle CoCo DMA bounce buffering Jacob Moroni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=agnJpvWB-tkw-jeg@FV6GYCPJ69 \
    --to=jiri@resnulli.us \
    --cc=edwards@nvidia.com \
    --cc=huangjunxian6@hisilicon.com \
    --cc=jgg@ziepe.ca \
    --cc=jmoroni@google.com \
    --cc=kees@kernel.org \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=lirongqing@baidu.com \
    --cc=liuy22@mails.tsinghua.edu.cn \
    --cc=mbloch@nvidia.com \
    --cc=parav@nvidia.com \
    --cc=yishaih@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox