[PATCH] IB/hfil: Delete unused bypass flags

[PATCH] IB/hfil: Delete unused bypass flags

[Christos Gkekas]

Clean up unused bypass variables in verbs.

Signed-off-by: Christos Gkekas <chris.gekas@gmail.com>
---
 drivers/infiniband/hw/hfi1/verbs.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
index e232f3c..62c3f4e 100644
--- a/drivers/infiniband/hw/hfi1/verbs.c
+++ b/drivers/infiniband/hw/hfi1/verbs.c
@@ -891,14 +891,12 @@ int hfi1_verbs_send_dma(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
 	u8 sc5 = priv->s_sc;
 	int ret;
 	u32 dwords;
-	bool bypass = false;
 
 	if (ps->s_txreq->phdr.hdr.hdr_type) {
 		u8 extra_bytes = hfi1_get_16b_padding((hdrwords << 2), len);
 
 		dwords = (len + extra_bytes + (SIZE_OF_CRC << 2) +
 			  SIZE_OF_LT) >> 2;
-		bypass = true;
 	} else {
 		dwords = (len + 3) >> 2;
 	}
@@ -1034,7 +1032,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
 	int ret = 0;
 	pio_release_cb cb = NULL;
 	u32 lrh0_16b;
-	bool bypass = false;
 	u8 extra_bytes = 0;
 
 	if (ps->s_txreq->phdr.hdr.hdr_type) {
@@ -1044,7 +1041,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
 		dwords = (len + extra_bytes) >> 2;
 		hdr = (u32 *)&ps->s_txreq->phdr.hdr.opah;
 		lrh0_16b = ps->s_txreq->phdr.hdr.opah.lrh[0];
-		bypass = true;
 	} else {
 		dwords = (len + 3) >> 2;
 		hdr = (u32 *)&ps->s_txreq->phdr.hdr.ibh;
-- 
2.7.4

Re: [PATCH] IB/hfil: Delete unused bypass flags

[Don Hiatt]

On 10/11/2017 1:56 PM, Christos Gkekas wrote:
> Clean up unused bypass variables in verbs.
>
> Signed-off-by: Christos Gkekas <chris.gekas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> ---
>   drivers/infiniband/hw/hfi1/verbs.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/infiniband/hw/hfi1/verbs.c b/drivers/infiniband/hw/hfi1/verbs.c
> index e232f3c..62c3f4e 100644
> --- a/drivers/infiniband/hw/hfi1/verbs.c
> +++ b/drivers/infiniband/hw/hfi1/verbs.c
> @@ -891,14 +891,12 @@ int hfi1_verbs_send_dma(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
>   	u8 sc5 = priv->s_sc;
>   	int ret;
>   	u32 dwords;
> -	bool bypass = false;
>   
>   	if (ps->s_txreq->phdr.hdr.hdr_type) {
>   		u8 extra_bytes = hfi1_get_16b_padding((hdrwords << 2), len);
>   
>   		dwords = (len + extra_bytes + (SIZE_OF_CRC << 2) +
>   			  SIZE_OF_LT) >> 2;
> -		bypass = true;
>   	} else {
>   		dwords = (len + 3) >> 2;
>   	}
> @@ -1034,7 +1032,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
>   	int ret = 0;
>   	pio_release_cb cb = NULL;
>   	u32 lrh0_16b;
> -	bool bypass = false;
>   	u8 extra_bytes = 0;
>   
>   	if (ps->s_txreq->phdr.hdr.hdr_type) {
> @@ -1044,7 +1041,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, struct hfi1_pkt_state *ps,
>   		dwords = (len + extra_bytes) >> 2;
>   		hdr = (u32 *)&ps->s_txreq->phdr.hdr.opah;
>   		lrh0_16b = ps->s_txreq->phdr.hdr.opah.lrh[0];
> -		bypass = true;
>   	} else {
>   		dwords = (len + 3) >> 2;
>   		hdr = (u32 *)&ps->s_txreq->phdr.hdr.ibh;
Thanks!  Those were useful at one time. ;-)

Reviewed-by: Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] IB/hfil: Delete unused bypass flags

[Dennis Dalessandro]

On 10/11/2017 5:35 PM, Don Hiatt wrote:
> 
> 
> On 10/11/2017 1:56 PM, Christos Gkekas wrote:
>> Clean up unused bypass variables in verbs.
>>
>> Signed-off-by: Christos Gkekas <chris.gekas-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>> ---
>>   drivers/infiniband/hw/hfi1/verbs.c | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/drivers/infiniband/hw/hfi1/verbs.c 
>> b/drivers/infiniband/hw/hfi1/verbs.c
>> index e232f3c..62c3f4e 100644
>> --- a/drivers/infiniband/hw/hfi1/verbs.c
>> +++ b/drivers/infiniband/hw/hfi1/verbs.c
>> @@ -891,14 +891,12 @@ int hfi1_verbs_send_dma(struct rvt_qp *qp, 
>> struct hfi1_pkt_state *ps,
>>       u8 sc5 = priv->s_sc;
>>       int ret;
>>       u32 dwords;
>> -    bool bypass = false;
>>       if (ps->s_txreq->phdr.hdr.hdr_type) {
>>           u8 extra_bytes = hfi1_get_16b_padding((hdrwords << 2), len);
>>           dwords = (len + extra_bytes + (SIZE_OF_CRC << 2) +
>>                 SIZE_OF_LT) >> 2;
>> -        bypass = true;
>>       } else {
>>           dwords = (len + 3) >> 2;
>>       }
>> @@ -1034,7 +1032,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, 
>> struct hfi1_pkt_state *ps,
>>       int ret = 0;
>>       pio_release_cb cb = NULL;
>>       u32 lrh0_16b;
>> -    bool bypass = false;
>>       u8 extra_bytes = 0;
>>       if (ps->s_txreq->phdr.hdr.hdr_type) {
>> @@ -1044,7 +1041,6 @@ int hfi1_verbs_send_pio(struct rvt_qp *qp, 
>> struct hfi1_pkt_state *ps,
>>           dwords = (len + extra_bytes) >> 2;
>>           hdr = (u32 *)&ps->s_txreq->phdr.hdr.opah;
>>           lrh0_16b = ps->s_txreq->phdr.hdr.opah.lrh[0];
>> -        bypass = true;
>>       } else {
>>           dwords = (len + 3) >> 2;
>>           hdr = (u32 *)&ps->s_txreq->phdr.hdr.ibh;
> Thanks!  Those were useful at one time. ;-)
> 
> Reviewed-by: Don Hiatt <don.hiatt-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
> 

Thanks, but this is already handled by a patch submitted by Bart. See:

https://marc.info/?l=linux-rdma&m=150774420313310&w=2

His patch catches a few other variables in those same functions.

-Denny
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html