* [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency
@ 2021-11-24 8:10 Jack Wang
2021-11-24 8:56 ` Guoqing Jiang
2021-11-25 17:37 ` Jason Gunthorpe
0 siblings, 2 replies; 4+ messages in thread
From: Jack Wang @ 2021-11-24 8:10 UTC (permalink / raw)
To: linux-rdma; +Cc: bvanassche, leon, dledford, jgg, haris.iqbal
The type of min_latency is ktime_t, so use KTIME_MAX to initialize
the initial value.
Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")
Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
---
drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
index 15c0077dd27e..e39709dee179 100644
--- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
+++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
@@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)
struct rtrs_clt_sess *min_path = NULL;
struct rtrs_clt *clt = it->clt;
struct rtrs_clt_sess *sess;
- ktime_t min_latency = INT_MAX;
+ ktime_t min_latency = KTIME_MAX;
ktime_t latency;
list_for_each_entry_rcu(sess, &clt->paths_list, s.entry) {
--
2.25.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency
2021-11-24 8:10 [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency Jack Wang
@ 2021-11-24 8:56 ` Guoqing Jiang
2021-11-24 9:05 ` Jinpu Wang
2021-11-25 17:37 ` Jason Gunthorpe
1 sibling, 1 reply; 4+ messages in thread
From: Guoqing Jiang @ 2021-11-24 8:56 UTC (permalink / raw)
To: Jack Wang, linux-rdma; +Cc: bvanassche, leon, dledford, jgg, haris.iqbal
On 11/24/21 4:10 PM, Jack Wang wrote:
> The type of min_latency is ktime_t, so use KTIME_MAX to initialize
> the initial value.
>
> Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")
> Signed-off-by: Jack Wang<jinpu.wang@ionos.com>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> index 15c0077dd27e..e39709dee179 100644
> --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> @@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)
> struct rtrs_clt_sess *min_path = NULL;
> struct rtrs_clt *clt = it->clt;
> struct rtrs_clt_sess *sess;
> - ktime_t min_latency = INT_MAX;
> + ktime_t min_latency = KTIME_MAX;
> ktime_t latency;
>
> list_for_each_entry_rcu(sess, &clt->paths_list, s.entry) {
LGTM.
Reviewed-by: Guoqing Jiang <Guoqing.Jiang@linux.dev>
Thanks,
Guoqing
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency
2021-11-24 8:56 ` Guoqing Jiang
@ 2021-11-24 9:05 ` Jinpu Wang
0 siblings, 0 replies; 4+ messages in thread
From: Jinpu Wang @ 2021-11-24 9:05 UTC (permalink / raw)
To: Guoqing Jiang; +Cc: linux-rdma, bvanassche, leon, dledford, jgg, haris.iqbal
On Wed, Nov 24, 2021 at 9:56 AM Guoqing Jiang <guoqing.jiang@linux.dev> wrote:
>
>
>
> On 11/24/21 4:10 PM, Jack Wang wrote:
> > The type of min_latency is ktime_t, so use KTIME_MAX to initialize
> > the initial value.
> >
> > Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")
> > Signed-off-by: Jack Wang<jinpu.wang@ionos.com>
> > ---
> > drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/infiniband/ulp/rtrs/rtrs-clt.c b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > index 15c0077dd27e..e39709dee179 100644
> > --- a/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > +++ b/drivers/infiniband/ulp/rtrs/rtrs-clt.c
> > @@ -867,7 +867,7 @@ static struct rtrs_clt_sess *get_next_path_min_latency(struct path_it *it)
> > struct rtrs_clt_sess *min_path = NULL;
> > struct rtrs_clt *clt = it->clt;
> > struct rtrs_clt_sess *sess;
> > - ktime_t min_latency = INT_MAX;
> > + ktime_t min_latency = KTIME_MAX;
> > ktime_t latency;
> >
> > list_for_each_entry_rcu(sess, &clt->paths_list, s.entry) {
>
> LGTM.
>
> Reviewed-by: Guoqing Jiang <Guoqing.Jiang@linux.dev>
Thank you for the quick review!
>
> Thanks,
> Guoqing
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency
2021-11-24 8:10 [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency Jack Wang
2021-11-24 8:56 ` Guoqing Jiang
@ 2021-11-25 17:37 ` Jason Gunthorpe
1 sibling, 0 replies; 4+ messages in thread
From: Jason Gunthorpe @ 2021-11-25 17:37 UTC (permalink / raw)
To: Jack Wang; +Cc: linux-rdma, bvanassche, leon, dledford, haris.iqbal
On Wed, Nov 24, 2021 at 09:10:40AM +0100, Jack Wang wrote:
> The type of min_latency is ktime_t, so use KTIME_MAX to initialize
> the initial value.
>
> Fixes: dc3b66a0ce70 ("RDMA/rtrs-clt: Add a minimum latency multipath policy")
> Signed-off-by: Jack Wang <jinpu.wang@ionos.com>
> Reviewed-by: Guoqing Jiang <Guoqing.Jiang@linux.dev>
> ---
> drivers/infiniband/ulp/rtrs/rtrs-clt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Applied to for-next, thanks
Jason
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2021-11-25 17:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-11-24 8:10 [PATCH] RDMA/rtrs-clt: Fix the initial value of min_latency Jack Wang
2021-11-24 8:56 ` Guoqing Jiang
2021-11-24 9:05 ` Jinpu Wang
2021-11-25 17:37 ` Jason Gunthorpe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox