Re: [PATCH 1/1] RDMA/irdma: remove the check to the returned value of irdma_uk_cq_init

[Yanjun Zhu <yanjun.zhu@linux.dev>]

在 2021/10/19 23:36, Saleem, Shiraz 写道:
>> Subject: [PATCH 1/1] RDMA/irdma: remove the check to the returned value of
>> irdma_uk_cq_init
> 
> Maybe you can condense this to --
> 
> RDMA/irdma: Make irdma_uk_cq_init return a void
> 
> 
>>
>> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>>
>> Since the function irdma_uk_cq_init always returns 0, so remove the check to the
>> returned value of the function irdma_uk_cq_init.
> 
> Maybe --
> 
> irdma_uk_cq_init always returns 0, so make it a void.
> 
> 
>>
>> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
>> ---
>>   drivers/infiniband/hw/irdma/ctrl.c | 5 +----
>>   drivers/infiniband/hw/irdma/uk.c   | 6 ++----
>>   drivers/infiniband/hw/irdma/user.h | 4 ++--
>>   3 files changed, 5 insertions(+), 10 deletions(-)
>>
> 
> Thanks for this!
> 
> Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
> 
Thanks, Shiraz

Zhu Yanjun