From: "Saleem, Shiraz" <shiraz.saleem@intel.com>
To: "yanjun.zhu@linux.dev" <yanjun.zhu@linux.dev>,
"Ismail, Mustafa" <mustafa.ismail@intel.com>,
"dledford@redhat.com" <dledford@redhat.com>,
"jgg@ziepe.ca" <jgg@ziepe.ca>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"leon@kernel.org" <leon@kernel.org>
Subject: RE: [PATCH 1/1] RDMA/irdma: remove the check to the returned value of irdma_uk_cq_init
Date: Tue, 19 Oct 2021 15:36:37 +0000 [thread overview]
Message-ID: <f6a7d200d1f94c7abe8f2524a1d3acd7@intel.com> (raw)
In-Reply-To: <20211019153717.3836-1-yanjun.zhu@linux.dev>
> Subject: [PATCH 1/1] RDMA/irdma: remove the check to the returned value of
> irdma_uk_cq_init
Maybe you can condense this to --
RDMA/irdma: Make irdma_uk_cq_init return a void
>
> From: Zhu Yanjun <yanjun.zhu@linux.dev>
>
> Since the function irdma_uk_cq_init always returns 0, so remove the check to the
> returned value of the function irdma_uk_cq_init.
Maybe --
irdma_uk_cq_init always returns 0, so make it a void.
>
> Signed-off-by: Zhu Yanjun <yanjun.zhu@linux.dev>
> ---
> drivers/infiniband/hw/irdma/ctrl.c | 5 +----
> drivers/infiniband/hw/irdma/uk.c | 6 ++----
> drivers/infiniband/hw/irdma/user.h | 4 ++--
> 3 files changed, 5 insertions(+), 10 deletions(-)
>
Thanks for this!
Reviewed-by: Shiraz Saleem <shiraz.saleem@intel.com>
next prev parent reply other threads:[~2021-10-19 15:36 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 15:37 [PATCH 1/1] RDMA/irdma: remove the check to the returned value of irdma_uk_cq_init yanjun.zhu
2021-10-19 15:36 ` Saleem, Shiraz [this message]
2021-10-19 23:40 ` Yanjun Zhu
2021-10-20 23:03 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f6a7d200d1f94c7abe8f2524a1d3acd7@intel.com \
--to=shiraz.saleem@intel.com \
--cc=dledford@redhat.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mustafa.ismail@intel.com \
--cc=yanjun.zhu@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox