Re: [PATCH net] net/mlx5: Use only loaded devices for PTP clock operations

[Carolina Jubran <cjubran@nvidia.com>]

On 21/10/2026 13:59, netdev-bot+sinfo@kernel.org wrote:
> Hi!
>
> This is an automated message. This series looks like a fix, but its
> commit messages seem to be missing some information:
>
>   - How the issue was discovered, e.g. hit in production, hit during
>     development, syzbot report, manual code inspection, LLM or static
>     analysis tool scan.
>
>   - Whether the issue was actually triggered, or is only theoretical
>     (e.g. found by code inspection). If it was triggered please include
>     the symptoms, like the stack trace or error messages.
>
>   - What hardware the change was tested on. For driver fixes please
>     mention the device (and if relevant firmware version) used for
>     testing, or say that the change was not tested on real hardware.
>
> Please do not repost the series just to address the above. Instead,
> reply to this email with the missing information, so that reviewers
> can take it into account. If the series needs another revision for
> other reasons, please include the information in the commit messages
> then.
>
> The evaluation is done by an LLM so it may be wrong, if you think
> that is the case please reply and explain.

Hi,

The issue was observed and reported internally during PCI suspend/resume.
During the initial investigation, another team found that stopping the
PTP worker prevented the issue. I do not have any logs to share.

I then investigated the report through manual code inspection and found
that the periodic PTP worker could access PCI registers through its
backing function after that function had been unloaded. Stopping the
worker alone wasn't enough because PTP operations could still access
the same unloaded backing mdev. The change therefore ties the worker to
the load state and ensures that PTP hardware operations use only a loaded
backing function.

The change was tested on ConnectX-7 hardware.

Thanks,
Carolina