Re: [PATCH net] net/mlx5: Use only loaded devices for PTP clock operations

[sashiko-bot@kernel.org]

> From: Carolina Jubran <cjubran@nvidia.com>
> 
> The PTP periodic worker and PTP operations access PCI registers through
> the function backing the PTP clock. The PTP clock remains registered
> when a PCI function is suspended, so these paths can still access the
> function after it has been unloaded.
> 
> To fix that, serialize clock hardware access with the clock mutex for
> all clocks and fail callbacks with -EAGAIN when there is no loaded
> function to service the clock. Additionally, tie the worker's lifetime
> to load/unload and use the devcom lock to synchronize with peer
> loads/unloads.
> 
> Fixes: 8fc3e29be924 ("net/mlx5: Fix crash upon suspend/resume")
> Signed-off-by: Carolina Jubran <cjubran@nvidia.com>
> Reviewed-by: Cosmin Ratiu <cratiu@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261021105600.3481485-1-tariqt@nvidia.com?part=1