Re: [PATCH net-next v9 03/13] net/rds: ib: refuse to attach a connection to a device being removed

[sashiko-bot@kernel.org]

> rds_ib_remove_one() drops every connection on the device's conn_list
> in rds_ib_dev_shutdown(), then clears the client data so that no new
> connect can find the device.  A connect that is already past
> rds_ib_get_client_data() when the walk runs is not covered by either:
> rds_ib_setup_qp() goes on to rds_ib_add_conn(), which moves the
> connection onto the conn_list the walk has just finished with, and
> builds a QP on a device that is on its way out.
> 
> On a hot removal the rdma_cm still catches that: its own client
> removal runs after RDS's and delivers RDMA_CM_EVENT_DEVICE_REMOVAL to
> the connection's id, whose drop shuts the connection down and returns
> it to ib_nodev_conns.  On module unload there is no such event - the
> device stays registered - and rds_destroy_pending() is already true,
> so every drop short of a destroy returns early.  Nothing drops that
> connection then: the device's shutdown walk is over, and the
> [ ... ]
> rds_ib_add_conn().
> 
> Fixes: fc19de38be92 ("RDS/IB: disconnect when IB devices are removed")
> Assisted-by: Claude-Code:claude-fable-5
> Signed-off-by: Allison Henderson <achender@kernel.org>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261008031333.1142174-1-achender@kernel.org?part=3