Re: [PATCH AUTOSEL 6.18-5.10] net/rds: fix rds_message leak in the rds_send_xmit() drop path

[sashiko-bot@kernel.org]

> From: Sharath Srinivasan <sharath.srinivasan@oracle.com>
> 
> [ Upstream commit eb8a59a17f4a8b6f2afb4a8063e99dd96cc3fab0 ]
> 
> When rds_send_xmit() picks the next message off cp_send_queue it takes
> its own reference with rds_message_addref().  If the message then hits
> the never-retransmit check (RDS_MSG_FLUSH, or an RDMA op that was
> already retransmitted), it is moved to the local to_be_dropped list and
> that reference is dropped after the batch.
> 
> However, if RDS_MSG_ON_CONN has already been cleared, the message is
> not added to to_be_dropped and the reference taken above is never
> dropped: cp_xmit_rm has not been set at this point, so the loop simply
> abandons rm and the rds_message (and everything it pins: pages, MRs,
> notifiers) leaks after an RDMA error.
> [ ... ]
> [achender: port to net-next; update commit message, checkpatch nits]
> Signed-off-by: Allison Henderson <achender@kernel.org>
> Link: https://patch.msgid.link/20260730041629.3512480-4-achender@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019135441.1420968-258-sashal@kernel.org?part=1