Re: [PATCH AUTOSEL 6.18-5.10] net/rds: hold the socket while an rds_mr references it

[sashiko-bot@kernel.org]

> From: Håkon Bugge <haakon.bugge@oracle.com>
> 
> [ Upstream commit 9079adef042c1e7a6141dcdfd3041acd30607297 ]
> 
> Each rds_mr stores a bare back pointer to the socket that created it
> (mr->r_sock) but takes no reference on it.  When the mr is destroyed it
> references the rs. Hence, provisions must be made to avoid the rs
> being destroyed before all mrs referencing it have been destroyed.
> 
> The MR itself is refcounted, and in-flight messages legitimately hold
> MR krefs that can outlive the socket: rds_release() drops the rb-tree
> references via rds_rdma_drop_keys(), but a send completion arriving
> afterwards drops the final message reference from the CQ handler and
> ends up in
> 
> [ ... ]
>  __rds_put_mr_final(); update commit message]
> Signed-off-by: Allison Henderson <achender@kernel.org>
> Link: https://patch.msgid.link/20260730041629.3512480-3-achender@kernel.org
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
> Signed-off-by: Sasha Levin <sashal@kernel.org>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261019135441.1420968-432-sashal@kernel.org?part=1