Re: [PATCH 2/7] RDMA/zrdma: Add core data structures and ABI definitions

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] RDMA/zrdma: missing WITH Linux-syscall-note in UAPI zrdma_abi.h SPDX header
--

commit c85ffe470e05337ffcff385d3797e8a504257235
Author: Yanze Zhang <zhang.yanze@zte.com.cn>

RDMA/zrdma: Add core data structures and ABI definitions

This patch adds core data structures, hardware control structures, and
user-space ABI definitions for the ZTE DingHai RDMA driver.

> diff --git a/include/uapi/rdma/zrdma_abi.h b/include/uapi/rdma/zrdma_abi.h
> new file mode 100644
> index 0000000000000..6686a02f77a32
> --- /dev/null
> +++ b/include/uapi/rdma/zrdma_abi.h
> @@ -0,0 +1,81 @@
> +/* SPDX-License-Identifier: GPL-2.0 OR Linux-OpenIB

[Severity: Low]
Will this license header cause a build failure when installing or validating
exported user-space headers (such as via make headers_install)?

When scripts/headers_install.sh processes headers under include/uapi/, it
rejects gpl license identifiers that omit the syscall note exception:

    # SPDX-License-Identifier with GPL variants must have "WITH Linux-syscall-note"
    if [ -n "$(sed -n -e "/SPDX-License-Identifier:.*GPL-/{/WITH Linux-syscall-note/!p}" $INFILE)" ]; then
        echo "error: $INFILE: missing \"WITH Linux-syscall-note\" for SPDX-License-Identifier" >&2
        exit 1
    fi

Should the first line of include/uapi/rdma/zrdma_abi.h instead be:

    /* SPDX-License-Identifier: ((GPL-2.0 WITH Linux-syscall-note) OR Linux-OpenIB) */

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261024071539.2182864-1-zhang.yanze@zte.com.cn?part=2