[PATCH] RDMA/mlx5: Return ENOMEM when allocating a MEMIC operation fails

[PATCH] RDMA/mlx5: Return ENOMEM when allocating a MEMIC operation fails

[Zhu Jun]

When a MEMIC operation is not already mapped, map_existing_op() leaves
err set to -ENOENT. If allocating the new operation entry then fails, the
handler returns that stale lookup error instead of -ENOMEM.

Set err to -ENOMEM before allocating the operation entry.

OpenAI Codex assisted with analysis and patch preparation.

Fixes: cea85fa5dbc2 ("RDMA/mlx5: Add support in MEMIC operations")
Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>
---
 drivers/infiniband/hw/mlx5/dm.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/infiniband/hw/mlx5/dm.c b/drivers/infiniband/hw/mlx5/dm.c
index 7a6fe4fea3e2..61727118d1b4 100644
--- a/drivers/infiniband/hw/mlx5/dm.c
+++ b/drivers/infiniband/hw/mlx5/dm.c
@@ -228,6 +228,7 @@ static int UVERBS_HANDLER(MLX5_IB_METHOD_DM_MAP_OP_ADDR)(
 	if (!err || err != -ENOENT)
 		goto err_unlock;
 
+	err = -ENOMEM;
 	op_entry = kzalloc_obj(*op_entry);
 	if (!op_entry)
 		goto err_unlock;
-- 
2.51.0

Re: [PATCH] RDMA/mlx5: Return ENOMEM when allocating a MEMIC operation fails

[sashiko-bot]

> When a MEMIC operation is not already mapped, map_existing_op() leaves
> err set to -ENOENT. If allocating the new operation entry then fails, the
> handler returns that stale lookup error instead of -ENOMEM.
> 
> Set err to -ENOMEM before allocating the operation entry.
> 
> OpenAI Codex assisted with analysis and patch preparation.
> 
> Fixes: cea85fa5dbc2 ("RDMA/mlx5: Add support in MEMIC operations")
> Signed-off-by: Zhu Jun <zhujun2@cmss.chinamobile.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112023108.118187-1-zhujun2@cmss.chinamobile.com?part=1