[PATCH net] net/mlx5: IFC, enlarge active_port field to support 8 port LAG

[PATCH net] net/mlx5: IFC, enlarge active_port field to support 8 port LAG

[Tariq Toukan]

From: Shay Drory <shayd@nvidia.com>

active_port is a bitmask with a bit per LAG port. The cited commit
enabled 8 port LAG, but active_port remained 4 bits wide.

Enlarge active_port to 8 bits, as defined in the PRM.

Fixes: e0e6adfe8c20 ("net/mlx5: Enable 8 ports LAG")
Signed-off-by: Shay Drory <shayd@nvidia.com>
Reviewed-by: Mark Bloch <mbloch@nvidia.com>
Reviewed-by: Akiva Goldberger <agoldberger@nvidia.com>
Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
---
 include/linux/mlx5/mlx5_ifc.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h
index 697fc9387b73..37b6e47c9091 100644
--- a/include/linux/mlx5/mlx5_ifc.h
+++ b/include/linux/mlx5/mlx5_ifc.h
@@ -12453,8 +12453,8 @@ struct mlx5_ifc_lagc_bits {
 	u8         reserved_at_18[0x5];
 	u8         lag_state[0x3];
 
-	u8         reserved_at_20[0xc];
-	u8         active_port[0x4];
+	u8         reserved_at_20[0x8];
+	u8         active_port[0x8];
 	u8         reserved_at_30[0x4];
 	u8         tx_remap_affinity_2[0x4];
 	u8         reserved_at_38[0x4];

base-commit: b71c101bbb9814d163c00234d43c41f0a17907d4
-- 
2.44.0

Re: [PATCH net] net/mlx5: IFC, enlarge active_port field to support 8 port LAG

[sashiko-bot]

> From: Shay Drory <shayd@nvidia.com>
> 
> active_port is a bitmask with a bit per LAG port. The cited commit
> enabled 8 port LAG, but active_port remained 4 bits wide.
> 
> Enlarge active_port to 8 bits, as defined in the PRM.
> 
> Fixes: e0e6adfe8c20 ("net/mlx5: Enable 8 ports LAG")
> Signed-off-by: Shay Drory <shayd@nvidia.com>
> Reviewed-by: Mark Bloch <mbloch@nvidia.com>
> Reviewed-by: Akiva Goldberger <agoldberger@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261112182940.3655773-1-tariqt@nvidia.com?part=1

Re: [PATCH net] net/mlx5: IFC, enlarge active_port field to support 8 port LAG

[netdev-bot+sinfo]

Hi!

This is an automated message. This series looks like a fix, but its
commit messages seem to be missing some information:

 - How the issue was discovered, e.g. hit in production, hit during
   development, syzbot report, manual code inspection, LLM or static
   analysis tool scan.

 - Whether the issue was actually triggered, or is only theoretical
   (e.g. found by LLM and not proven at runtime). If it was triggered
   please include the symptoms, like the stack trace or kernel messages.

Please do not repost the series just to address the above. Instead,
reply to this email with the missing information, so that reviewers
can take it into account. If the series needs another revision for
other reasons, please include the information in the commit messages
then.

The evaluation is done by an LLM so it may be wrong, if you think
that is the case please reply and explain.