* [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule
@ 2026-11-17 3:13 Mohsin Bashir
2026-11-17 19:18 ` Mark Bloch
2026-11-18 3:13 ` sashiko-bot
0 siblings, 2 replies; 6+ messages in thread
From: Mohsin Bashir @ 2026-11-17 3:13 UTC (permalink / raw)
To: netdev
Cc: saeedm, leon, tariqt, mbloch, cjubran, andrew+netdev, davem,
edumazet, kuba, pabeni, linux-rdma, linux-kernel
From: Mohsin Bashir <hmohsin@meta.com>
In switchdev mode, mlx5 offloads police only when other actions follow
it. TC needs no extra action for a police-only rule to work. The mlx5
driver makes every police rule forward to the post meter table, but for
a rate police it adds that forward only after verify_attr_actions() has
checked the rule, so the check rejects it. The ok result of police is
also handled as pipe. In TC, ok accepts the packet and ends the action
list, whereas mlx5 goes on with the actions after police.
Support police as the only action of a rule. Set the forward while
parsing police, as is already done for police with mtu, and forward
an ok result to the end of the TC chains, as the driver does when it
offloads the gact ok action. The upcoming selftest series also relies on
such rules for TC offload validation.
The patch was tested on a ConnectX-7 in switchdev mode with the command
below, and it was verified that the rule is offloaded and limits the
matching traffic to the configured rate, using the hardware drop counter.
tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \
ip_proto udp dst_port 5201 \
action police rate 100mbit burst 1m conform-exceed drop/ok
Cc: Carolina Jubran <cjubran@nvidia.com>
Signed-off-by: Mohsin Bashir <hmohsin@meta.com>
---
drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c | 3 ++-
drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 +++
2 files changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c
index 1bd1c94fb977..52295f5d644c 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c
@@ -94,13 +94,14 @@ tc_act_parse_police(struct mlx5e_tc_act_parse_state *parse_state,
MLX5_FLOW_STEERING_CAP_MATCH_RANGES))
return -EOPNOTSUPP;
- attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
attr->flags |= MLX5_ATTR_FLAG_MTU;
} else {
attr->action |= MLX5_FLOW_CONTEXT_ACTION_EXECUTE_ASO;
attr->exe_aso_type = MLX5_EXE_ASO_FLOW_METER;
}
+ attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
+
return 0;
}
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
index 1d35c97aea0b..8685e41487f3 100644
--- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
+++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c
@@ -3892,6 +3892,9 @@ alloc_branch_attr(struct mlx5e_tc_flow *flow,
attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP;
break;
case FLOW_ACTION_ACCEPT:
+ attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST;
+ attr->flags |= MLX5_ATTR_FLAG_ACCEPT;
+ break;
case FLOW_ACTION_PIPE:
err = set_branch_dest_ft(flow->priv, attr);
if (err)
--
2.53.1-Meta
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule 2026-11-17 3:13 [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule Mohsin Bashir @ 2026-11-17 19:18 ` Mark Bloch 2026-11-17 21:52 ` Mohsin Bashir 2026-11-18 3:13 ` sashiko-bot 1 sibling, 1 reply; 6+ messages in thread From: Mark Bloch @ 2026-11-17 19:18 UTC (permalink / raw) To: Mohsin Bashir, netdev Cc: saeedm, leon, tariqt, cjubran, andrew+netdev, davem, edumazet, kuba, pabeni, linux-rdma, linux-kernel, idosch On 17/11/2026 5:13, Mohsin Bashir wrote: > From: Mohsin Bashir <hmohsin@meta.com> > > In switchdev mode, mlx5 offloads police only when other actions follow > it. TC needs no extra action for a police-only rule to work. The mlx5 > driver makes every police rule forward to the post meter table, but for > a rate police it adds that forward only after verify_attr_actions() has > checked the rule, so the check rejects it. The ok result of police is > also handled as pipe. In TC, ok accepts the packet and ends the action > list, whereas mlx5 goes on with the actions after police. > > Support police as the only action of a rule. Set the forward while > parsing police, as is already done for police with mtu, and forward > an ok result to the end of the TC chains, as the driver does when it > offloads the gact ok action. The upcoming selftest series also relies on > such rules for TC offload validation. > > The patch was tested on a ConnectX-7 in switchdev mode with the command > below, and it was verified that the rule is offloaded and limits the > matching traffic to the configured rate, using the hardware drop counter. > > tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ > ip_proto udp dst_port 5201 \ > action police rate 100mbit burst 1m conform-exceed drop/ok > > Cc: Carolina Jubran <cjubran@nvidia.com> > Signed-off-by: Mohsin Bashir <hmohsin@meta.com> > --- > drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c | 3 ++- > drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 +++ > 2 files changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c > index 1bd1c94fb977..52295f5d644c 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c > @@ -94,13 +94,14 @@ tc_act_parse_police(struct mlx5e_tc_act_parse_state *parse_state, > MLX5_FLOW_STEERING_CAP_MATCH_RANGES)) > return -EOPNOTSUPP; > > - attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > attr->flags |= MLX5_ATTR_FLAG_MTU; > } else { > attr->action |= MLX5_FLOW_CONTEXT_ACTION_EXECUTE_ASO; > attr->exe_aso_type = MLX5_EXE_ASO_FLOW_METER; > } > > + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; This makes every police that is the lact action pass verify_attr_actions() not only ok case described. what happens with: "police ... conform-exceed drop/pipe" with this not writes to FTEID_TO_REG so what happens once a packet reaches the port action table? also what about: tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ ip_proto udp dst_port 5201 \ action police rate 100mbit burst 1m conform-exceed drop/pipe \ action police rate 100mbit burst 1m conform-exceed drop/pipe won't this create a loop? > + > return 0; > } > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index 1d35c97aea0b..8685e41487f3 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -3892,6 +3892,9 @@ alloc_branch_attr(struct mlx5e_tc_flow *flow, > attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP; > break; > case FLOW_ACTION_ACCEPT: > + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > + attr->flags |= MLX5_ATTR_FLAG_ACCEPT; > + break; > case FLOW_ACTION_PIPE: > err = set_branch_dest_ft(flow->priv, attr); > if (err) This also changes rules where police is not the last action. The conform result defaults to ok when it is not given. action police rate 100mbit burst 1m conform-exceed drop \ action mirred egress redirect dev eth2 won't with this change the conforming packets go to the tc end table and not to the redirect dev? The rule is still reported as offloaded and installs the redirect which can't reached now. Mark ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule 2026-11-17 19:18 ` Mark Bloch @ 2026-11-17 21:52 ` Mohsin Bashir 2026-11-17 22:14 ` Mark Bloch 0 siblings, 1 reply; 6+ messages in thread From: Mohsin Bashir @ 2026-11-17 21:52 UTC (permalink / raw) To: Mark Bloch, netdev Cc: saeedm, leon, tariqt, cjubran, andrew+netdev, davem, edumazet, kuba, pabeni, linux-rdma, linux-kernel, idosch On 11/17/26 11:18 AM, Mark Bloch wrote: > On 17/11/2026 5:13, Mohsin Bashir wrote: >> From: Mohsin Bashir <hmohsin@meta.com> >> >> In switchdev mode, mlx5 offloads police only when other actions follow >> it. TC needs no extra action for a police-only rule to work. The mlx5 >> driver makes every police rule forward to the post meter table, but for >> a rate police it adds that forward only after verify_attr_actions() has >> checked the rule, so the check rejects it. The ok result of police is >> also handled as pipe. In TC, ok accepts the packet and ends the action >> list, whereas mlx5 goes on with the actions after police. >> >> Support police as the only action of a rule. Set the forward while >> parsing police, as is already done for police with mtu, and forward >> an ok result to the end of the TC chains, as the driver does when it >> offloads the gact ok action. The upcoming selftest series also relies on >> such rules for TC offload validation. >> >> The patch was tested on a ConnectX-7 in switchdev mode with the command >> below, and it was verified that the rule is offloaded and limits the >> matching traffic to the configured rate, using the hardware drop counter. >> >> tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ >> ip_proto udp dst_port 5201 \ >> action police rate 100mbit burst 1m conform-exceed drop/ok >> >> Cc: Carolina Jubran <cjubran@nvidia.com> >> Signed-off-by: Mohsin Bashir <hmohsin@meta.com> >> --- >> drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c | 3 ++- >> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 +++ >> 2 files changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >> index 1bd1c94fb977..52295f5d644c 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >> @@ -94,13 +94,14 @@ tc_act_parse_police(struct mlx5e_tc_act_parse_state *parse_state, >> MLX5_FLOW_STEERING_CAP_MATCH_RANGES)) >> return -EOPNOTSUPP; >> >> - attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >> attr->flags |= MLX5_ATTR_FLAG_MTU; >> } else { >> attr->action |= MLX5_FLOW_CONTEXT_ACTION_EXECUTE_ASO; >> attr->exe_aso_type = MLX5_EXE_ASO_FLOW_METER; >> } >> >> + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > > This makes every police that is the lact action pass verify_attr_actions() > not only ok case described. > > what happens with: > "police ... conform-exceed drop/pipe" > with this not writes to FTEID_TO_REG so what happens once a packet > reaches the port action table? > > also what about: > tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ > ip_proto udp dst_port 5201 \ > action police rate 100mbit burst 1m conform-exceed drop/pipe \ > action police rate 100mbit burst 1m conform-exceed drop/pipe > > won't this create a loop? > Thanks for reviewing Mark. Ahh! I missed the loop case. I had a patch to handle pipe on the last police but I dropped it, since my testing showed the post_act table still passed the packets up. Let me respin and send pipe and jump on the last police to the end of the TC chains. Would that work in your opinion? >> + >> return 0; >> } >> >> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >> index 1d35c97aea0b..8685e41487f3 100644 >> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >> @@ -3892,6 +3892,9 @@ alloc_branch_attr(struct mlx5e_tc_flow *flow, >> attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP; >> break; >> case FLOW_ACTION_ACCEPT: >> + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >> + attr->flags |= MLX5_ATTR_FLAG_ACCEPT; >> + break; >> case FLOW_ACTION_PIPE: >> err = set_branch_dest_ft(flow->priv, attr); >> if (err) > > This also changes rules where police is not the last action. > The conform result defaults to ok when it is not given. > > action police rate 100mbit burst 1m conform-exceed drop \ > action mirred egress redirect dev eth2 > > > won't with this change the conforming packets go to the tc end table > and not to the redirect dev? > The rule is still reported as offloaded and installs the redirect > which can't reached now. > Maybe I am missing something here, but when the conform action is not given, doesn't it default to ok? For example, if we have action police rate 100mbit burst 1m conform-exceed drop action drop shouldn't conforming packets still be pushed up rather than dropped by the following action, making the action drop (or the action mirred) dead code? > Mark > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule 2026-11-17 21:52 ` Mohsin Bashir @ 2026-11-17 22:14 ` Mark Bloch 2026-11-18 0:52 ` Mohsin Bashir 0 siblings, 1 reply; 6+ messages in thread From: Mark Bloch @ 2026-11-17 22:14 UTC (permalink / raw) To: Mohsin Bashir, netdev Cc: saeedm, leon, tariqt, cjubran, andrew+netdev, davem, edumazet, kuba, pabeni, linux-rdma, linux-kernel, idosch On 17/11/2026 23:52, Mohsin Bashir wrote: > > > On 11/17/26 11:18 AM, Mark Bloch wrote: >> On 17/11/2026 5:13, Mohsin Bashir wrote: >>> From: Mohsin Bashir <hmohsin@meta.com> >>> >>> In switchdev mode, mlx5 offloads police only when other actions follow >>> it. TC needs no extra action for a police-only rule to work. The mlx5 >>> driver makes every police rule forward to the post meter table, but for >>> a rate police it adds that forward only after verify_attr_actions() has >>> checked the rule, so the check rejects it. The ok result of police is >>> also handled as pipe. In TC, ok accepts the packet and ends the action >>> list, whereas mlx5 goes on with the actions after police. >>> >>> Support police as the only action of a rule. Set the forward while >>> parsing police, as is already done for police with mtu, and forward >>> an ok result to the end of the TC chains, as the driver does when it >>> offloads the gact ok action. The upcoming selftest series also relies on >>> such rules for TC offload validation. >>> >>> The patch was tested on a ConnectX-7 in switchdev mode with the command >>> below, and it was verified that the rule is offloaded and limits the >>> matching traffic to the configured rate, using the hardware drop counter. >>> >>> tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ >>> ip_proto udp dst_port 5201 \ >>> action police rate 100mbit burst 1m conform-exceed drop/ok >>> >>> Cc: Carolina Jubran <cjubran@nvidia.com> >>> Signed-off-by: Mohsin Bashir <hmohsin@meta.com> >>> --- >>> drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c | 3 ++- >>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 +++ >>> 2 files changed, 5 insertions(+), 1 deletion(-) >>> >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >>> index 1bd1c94fb977..52295f5d644c 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >>> @@ -94,13 +94,14 @@ tc_act_parse_police(struct mlx5e_tc_act_parse_state *parse_state, >>> MLX5_FLOW_STEERING_CAP_MATCH_RANGES)) >>> return -EOPNOTSUPP; >>> - attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >>> attr->flags |= MLX5_ATTR_FLAG_MTU; >>> } else { >>> attr->action |= MLX5_FLOW_CONTEXT_ACTION_EXECUTE_ASO; >>> attr->exe_aso_type = MLX5_EXE_ASO_FLOW_METER; >>> } >>> + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >> >> This makes every police that is the lact action pass verify_attr_actions() >> not only ok case described. >> >> what happens with: >> "police ... conform-exceed drop/pipe" >> with this not writes to FTEID_TO_REG so what happens once a packet >> reaches the port action table? >> >> also what about: >> tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ >> ip_proto udp dst_port 5201 \ >> action police rate 100mbit burst 1m conform-exceed drop/pipe \ >> action police rate 100mbit burst 1m conform-exceed drop/pipe >> >> won't this create a loop? >> > > Thanks for reviewing Mark. > > Ahh! I missed the loop case. I had a patch to handle pipe on the last police but I dropped it, since my testing showed the post_act table still passed the packets up. Let me respin and send pipe and jump on the last police to the end of the TC chains. Would that work in your opinion? Yes for PIPE. For JUMP, we need to check the target. tcf_action_exec() counts from the start of the action list, so even the last police can jump back to itself or an earlier action. If we can't offload that, we should probably reject it. That's how I read tcf_action_exec(), but please correct me if I'm missing something as I'm not really a tc expert. > >>> + >>> return 0; >>> } >>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >>> index 1d35c97aea0b..8685e41487f3 100644 >>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >>> @@ -3892,6 +3892,9 @@ alloc_branch_attr(struct mlx5e_tc_flow *flow, >>> attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP; >>> break; >>> case FLOW_ACTION_ACCEPT: >>> + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >>> + attr->flags |= MLX5_ATTR_FLAG_ACCEPT; >>> + break; >>> case FLOW_ACTION_PIPE: >>> err = set_branch_dest_ft(flow->priv, attr); >>> if (err) >> >> This also changes rules where police is not the last action. >> The conform result defaults to ok when it is not given. >> >> action police rate 100mbit burst 1m conform-exceed drop \ >> action mirred egress redirect dev eth2 >> >> >> won't with this change the conforming packets go to the tc end table >> and not to the redirect dev? >> The rule is still reported as offloaded and installs the redirect >> which can't reached now. >> > > Maybe I am missing something here, but when the conform action is not given, doesn't it default to ok? For example, if we have > action police rate 100mbit burst 1m conform-exceed drop action drop > shouldn't conforming packets still be pushed up rather than dropped by the following action, making the action drop (or the action mirred) dead code? > Yes, agreed, the following action is dead code in software too, a separated cleanup patch maybe? What about packets that reach the rep? I don't see anything in the ACCEPT path that tells software TC the packet has already been processed. For example: tc filter add dev eth2 ingress pref 100 protocol ipv6 flower skip_sw \ ip_proto udp dst_port 5201 \ action police rate 100mbit burst 1m conform-exceed drop/ok tc filter add dev eth2 ingress pref 200 protocol ipv6 flower skip_hw \ ip_proto udp dst_port 5201 \ action drop Wouldn't a conforming packet reach software, skip the first rule and get dropped by the second, despite already being accepted in hardware? Can you test this? The existing gact ok path might have the same issue. Mark >> Mark >> > ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule 2026-11-17 22:14 ` Mark Bloch @ 2026-11-18 0:52 ` Mohsin Bashir 0 siblings, 0 replies; 6+ messages in thread From: Mohsin Bashir @ 2026-11-18 0:52 UTC (permalink / raw) To: Mark Bloch, netdev Cc: saeedm, leon, tariqt, cjubran, andrew+netdev, davem, edumazet, kuba, pabeni, linux-rdma, linux-kernel, idosch On 11/17/26 2:14 PM, Mark Bloch wrote: > > > On 17/11/2026 23:52, Mohsin Bashir wrote: >> >> >> On 11/17/26 11:18 AM, Mark Bloch wrote: >>> On 17/11/2026 5:13, Mohsin Bashir wrote: >>>> From: Mohsin Bashir <hmohsin@meta.com> >>>> >>>> In switchdev mode, mlx5 offloads police only when other actions follow >>>> it. TC needs no extra action for a police-only rule to work. The mlx5 >>>> driver makes every police rule forward to the post meter table, but for >>>> a rate police it adds that forward only after verify_attr_actions() has >>>> checked the rule, so the check rejects it. The ok result of police is >>>> also handled as pipe. In TC, ok accepts the packet and ends the action >>>> list, whereas mlx5 goes on with the actions after police. >>>> >>>> Support police as the only action of a rule. Set the forward while >>>> parsing police, as is already done for police with mtu, and forward >>>> an ok result to the end of the TC chains, as the driver does when it >>>> offloads the gact ok action. The upcoming selftest series also relies on >>>> such rules for TC offload validation. >>>> >>>> The patch was tested on a ConnectX-7 in switchdev mode with the command >>>> below, and it was verified that the rule is offloaded and limits the >>>> matching traffic to the configured rate, using the hardware drop counter. >>>> >>>> tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ >>>> ip_proto udp dst_port 5201 \ >>>> action police rate 100mbit burst 1m conform-exceed drop/ok >>>> >>>> Cc: Carolina Jubran <cjubran@nvidia.com> >>>> Signed-off-by: Mohsin Bashir <hmohsin@meta.com> >>>> --- >>>> drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c | 3 ++- >>>> drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 +++ >>>> 2 files changed, 5 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >>>> index 1bd1c94fb977..52295f5d644c 100644 >>>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >>>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c >>>> @@ -94,13 +94,14 @@ tc_act_parse_police(struct mlx5e_tc_act_parse_state *parse_state, >>>> MLX5_FLOW_STEERING_CAP_MATCH_RANGES)) >>>> return -EOPNOTSUPP; >>>> - attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >>>> attr->flags |= MLX5_ATTR_FLAG_MTU; >>>> } else { >>>> attr->action |= MLX5_FLOW_CONTEXT_ACTION_EXECUTE_ASO; >>>> attr->exe_aso_type = MLX5_EXE_ASO_FLOW_METER; >>>> } >>>> + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >>> >>> This makes every police that is the lact action pass verify_attr_actions() >>> not only ok case described. >>> >>> what happens with: >>> "police ... conform-exceed drop/pipe" >>> with this not writes to FTEID_TO_REG so what happens once a packet >>> reaches the port action table? >>> >>> also what about: >>> tc filter add dev eth0 ingress pref 100 protocol ipv6 flower skip_sw \ >>> ip_proto udp dst_port 5201 \ >>> action police rate 100mbit burst 1m conform-exceed drop/pipe \ >>> action police rate 100mbit burst 1m conform-exceed drop/pipe >>> >>> won't this create a loop? >>> >> >> Thanks for reviewing Mark. >> >> Ahh! I missed the loop case. I had a patch to handle pipe on the last police but I dropped it, since my testing showed the post_act table still passed the packets up. Let me respin and send pipe and jump on the last police to the end of the TC chains. Would that work in your opinion? > > Yes for PIPE. > > For JUMP, we need to check the target. tcf_action_exec() counts from > the start of the action list, so even the last police can jump back > to itself or an earlier action. If we can't offload that, we should > probably reject it. > > That's how I read tcf_action_exec(), but please correct me if I'm > missing something as I'm not really a tc expert. > >> Yeah, jump restarts the list. Before this patch police as the last action was rejected anyway, so I believe rejecting jump there in the respin should be okay? >>>> + >>>> return 0; >>>> } >>>> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >>>> index 1d35c97aea0b..8685e41487f3 100644 >>>> --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >>>> +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c >>>> @@ -3892,6 +3892,9 @@ alloc_branch_attr(struct mlx5e_tc_flow *flow, >>>> attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP; >>>> break; >>>> case FLOW_ACTION_ACCEPT: >>>> + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; >>>> + attr->flags |= MLX5_ATTR_FLAG_ACCEPT; >>>> + break; >>>> case FLOW_ACTION_PIPE: >>>> err = set_branch_dest_ft(flow->priv, attr); >>>> if (err) >>> >>> This also changes rules where police is not the last action. >>> The conform result defaults to ok when it is not given. >>> >>> action police rate 100mbit burst 1m conform-exceed drop \ >>> action mirred egress redirect dev eth2 >>> >>> >>> won't with this change the conforming packets go to the tc end table >>> and not to the redirect dev? >>> The rule is still reported as offloaded and installs the redirect >>> which can't reached now. >>> >> >> Maybe I am missing something here, but when the conform action is not given, doesn't it default to ok? For example, if we have >> action police rate 100mbit burst 1m conform-exceed drop action drop >> shouldn't conforming packets still be pushed up rather than dropped by the following action, making the action drop (or the action mirred) dead code? >> > > Yes, agreed, the following action is dead code in software too, > a separated cleanup patch maybe? > Yeah probably. > What about packets that reach the rep? I don't see anything in > the ACCEPT path that tells software TC the packet has already been > processed. For example: > > tc filter add dev eth2 ingress pref 100 protocol ipv6 flower skip_sw \ > ip_proto udp dst_port 5201 \ > action police rate 100mbit burst 1m conform-exceed drop/ok > > tc filter add dev eth2 ingress pref 200 protocol ipv6 flower skip_hw \ > ip_proto udp dst_port 5201 \ > action drop > > Wouldn't a conforming packet reach software, skip the first rule and > get dropped by the second, despite already being accepted in hardware? > > Can you test this? The existing gact ok path might have the same issue. Yeah, in both cases (police and gact ok) the conforming packets are pushed up, where they get dropped by the skip_hw rule. My understanding is that with existing behavior the restore doesn't happen on accept path, so sw tc takes the packet through classification again. > Mark ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule 2026-11-17 3:13 [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule Mohsin Bashir 2026-11-17 19:18 ` Mark Bloch @ 2026-11-18 3:13 ` sashiko-bot 1 sibling, 0 replies; 6+ messages in thread From: sashiko-bot @ 2026-11-18 3:13 UTC (permalink / raw) To: Mohsin Bashir; +Cc: linux-rdma Thank you for your contribution! Sashiko AI review found 1 potential issue to consider: - [High] net/mlx5e: broken post_act steering when last police action uses pipe or jump It also noticed 1 related pre-existing issue this patch does not introduce: - [Medium] net/mlx5e: memory leak of parse_attr on error path in alloc_branch_attr() [1] -- commit bbe05fcd328438a7e5968a8a2b44d3bf4fffd2eb Author: Mohsin Bashir <hmohsin@meta.com> net: mlx5: Allow police as the last action of a TC rule This commit sets MLX5_FLOW_CONTEXT_ACTION_FWD_DEST while parsing rate police actions and updates alloc_branch_attr() to set MLX5_ATTR_FLAG_ACCEPT for FLOW_ACTION_ACCEPT so police can be offloaded as the last action in a TC rule. > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c > index 1bd1c94fb9776..52295f5d644c5 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en/tc/act/police.c > @@ -94,13 +94,14 @@ tc_act_parse_police(struct mlx5e_tc_act_parse_state *parse_state, > MLX5_FLOW_STEERING_CAP_MATCH_RANGES)) > return -EOPNOTSUPP; > > - attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > attr->flags |= MLX5_ATTR_FLAG_MTU; > } else { > attr->action |= MLX5_FLOW_CONTEXT_ACTION_EXECUTE_ASO; > attr->exe_aso_type = MLX5_EXE_ASO_FLOW_METER; > } > > + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > + > return 0; > } > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > index 1d35c97aea0bc..8685e41487f39 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c > @@ -3892,6 +3892,9 @@ alloc_branch_attr(struct mlx5e_tc_flow *flow, > attr->action |= MLX5_FLOW_CONTEXT_ACTION_DROP; > break; > case FLOW_ACTION_ACCEPT: > + attr->action |= MLX5_FLOW_CONTEXT_ACTION_FWD_DEST; > + attr->flags |= MLX5_ATTR_FLAG_ACCEPT; > + break; > case FLOW_ACTION_PIPE: > err = set_branch_dest_ft(flow->priv, attr); > if (err) [Severity: High] What happens when a rule ends with a police action whose branch control is FLOW_ACTION_PIPE (the iproute2 default for notexceed when configuring "action police rate ... drop") or FLOW_ACTION_JUMP? Setting MLX5_FLOW_CONTEXT_ACTION_FWD_DEST in tc_act_parse_police() lets a trailing rate police action pass verify_attr_actions(), while alloc_branch_attr() still sets branch_attr->dest_ft to post_act->ft for FLOW_ACTION_PIPE and FLOW_ACTION_JUMP. However, parse_tc_actions() only splits the flow to allocate a subsequent post_act attribute when i < flow_action->num_entries - 1, so next_attr is NULL in alloc_flow_post_acts() and mlx5e_tc_act_set_next_post_act() never writes a new FTEID_TO_REG or installs a target post_act rule. Packets taking the pipe branch will miss in post_act->ft to the slow path instead of reaching the end of the TC chains, or if an earlier multi-table action preceded the final police action, FTEID_TO_REG still holds the final police attribute's own post_act_handle->id and steers packets back into the same police rule in a loop. [Severity: Medium] This problem wasn't introduced by this patch, but does the out_err path in alloc_branch_attr() leak (*cond_attr)->parse_attr [1]? mlx5e_clone_flow_attr_for_post_act() allocates both *cond_attr and a separate (*cond_attr)->parse_attr via kvzalloc_obj(), but out_err only calls kfree(*cond_attr) instead of a helper like free_branch_attr() when set_branch_dest_ft() or branch validation fails. [1] https://sashiko.dev/#/bug/linux-ad0e9c08-1f2f-44c7-a3a1-f3f69e4acf76 -- Sashiko AI review · https://sashiko.dev/#/patchset/20261117031337.4126403-1-mohsin.bashr@gmail.com?part=1 ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2026-11-18 3:14 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2026-11-17 3:13 [PATCH net-next] net: mlx5: Allow police as the last action of a TC rule Mohsin Bashir 2026-11-17 19:18 ` Mark Bloch 2026-11-17 21:52 ` Mohsin Bashir 2026-11-17 22:14 ` Mark Bloch 2026-11-18 0:52 ` Mohsin Bashir 2026-11-18 3:13 ` sashiko-bot
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox