From: Tanmay Shah <tanmays@amd.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
Tanmay Shah <tanmay.shah@amd.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Michal Simek <michal.simek@amd.com>
Cc: linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v10 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings
Date: Thu, 13 Oct 2022 08:28:17 -0700 [thread overview]
Message-ID: <13dd0380-9195-7a24-fac0-e5978393b1ae@amd.com> (raw)
In-Reply-To: <fa60ba81-6cc7-7f78-55cc-9ca0053336b8@linaro.org>
On 10/12/22 8:29 AM, Krzysztof Kozlowski wrote:
> On 11/10/2022 17:24, Tanmay Shah wrote:
>> Xilinx ZynqMP platform has dual-core ARM Cortex R5 Realtime Processing
>> Unit(RPU) subsystem. This patch adds dt-bindings for RPU subsystem
>> (cluster).
>>
>> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
>> ---
>>
>> Changes in v10:
>> - rename example node to remoteproc
>>
>> Changes in v9:
>> - remove power-domains property description
>> - fix nitpicks in description of other properties
>>
>> Changes in v8:
>> - Add 'items:' for sram property
>>
>> Changes in v7:
>> - Add minItems in sram property
>>
>> Changes in v6:
>> - Add maxItems to sram and memory-region property
>>
>> Changes in v5:
>> - Add constraints of the possible values of xlnx,cluster-mode property
>> - fix description of power-domains property for r5 core
>> - Remove reg, address-cells and size-cells properties as it is not required
>> - Fix description of mboxes property
>> - Add description of each memory-region and remove old .txt binding link
>> reference in the description
>>
>> Changes in v4:
>> - Add memory-region, mboxes and mbox-names properties in example
>>
>> Changes in v3:
>> - None
>>
>> .../bindings/remoteproc/xlnx,r5f-rproc.yaml | 135 ++++++++++++++++++
>> include/dt-bindings/power/xlnx-zynqmp-power.h | 6 +
>> 2 files changed, 141 insertions(+)
>> create mode 100644 Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml
>>
>> diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml
>> new file mode 100644
>> index 000000000000..8079b60b950e
>> --- /dev/null
>> +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,r5f-rproc.yaml
> The convention is to have filename matching the compatible, so:
> xlnx,zynqmp-r5fss.yaml
>
Thanks for reviews. Sure I will rename file in next revision.
>> @@ -0,0 +1,135 @@
>> +# SPDX-License-Identifier: (GPL-2.0-only or BSD-2-Clause)
>> +%YAML 1.2
>> +---
>> +$id: http://devicetree.org/schemas/remoteproc/xlnx,r5f-rproc.yaml#
>> +$schema: http://devicetree.org/meta-schemas/core.yaml#
>> +
>> +title: Xilinx R5F processor subsystem
>> +
>> +maintainers:
>> + - Ben Levinsky <ben.levinsky@amd.com>
>> + - Tanmay Shah <tanmay.shah@amd.com>
>> +
>> +description: |
>> + The Xilinx platforms include a pair of Cortex-R5F processors (RPU) for
>> + real-time processing based on the Cortex-R5F processor core from ARM.
>> + The Cortex-R5F processor implements the Arm v7-R architecture and includes a
>> + floating-point unit that implements the Arm VFPv3 instruction set.
>> +
>> +properties:
>> + compatible:
>> + const: xlnx,zynqmp-r5fss
>> +
>
>
> Best regards,
> Krzysztof
>
next prev parent reply other threads:[~2022-10-13 15:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-11 21:24 [PATCH v10 0/6] Add Xilinx RPU subsystem support Tanmay Shah
2022-10-11 21:24 ` [PATCH v10 1/6] dt-bindings: remoteproc: Add Xilinx RPU subsystem bindings Tanmay Shah
2022-10-12 15:29 ` Krzysztof Kozlowski
2022-10-13 15:28 ` Tanmay Shah [this message]
2022-10-11 21:24 ` [PATCH v10 2/6] arm64: dts: xilinx: zynqmp: Add RPU subsystem device node Tanmay Shah
2022-10-11 21:24 ` [PATCH v10 3/6] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration Tanmay Shah
2022-10-25 13:04 ` Michal Simek
2022-10-11 21:24 ` [PATCH v10 4/6] firmware: xilinx: Add shutdown/wakeup APIs Tanmay Shah
2022-10-25 13:05 ` Michal Simek
2022-10-11 21:25 ` [PATCH v10 5/6] firmware: xilinx: Add RPU configuration APIs Tanmay Shah
2022-10-25 13:05 ` Michal Simek
2022-10-11 21:25 ` [PATCH v10 6/6] drivers: remoteproc: Add Xilinx r5 remoteproc driver Tanmay Shah
2022-11-01 22:05 ` Mathieu Poirier
2022-11-02 19:53 ` [PATCH v10 0/6] Add Xilinx RPU subsystem support Mathieu Poirier
2022-11-02 19:58 ` tanmays
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=13dd0380-9195-7a24-fac0-e5978393b1ae@amd.com \
--to=tanmays@amd.com \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=michal.simek@amd.com \
--cc=robh+dt@kernel.org \
--cc=tanmay.shah@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox