Re: [PATCH v10 3/6] firmware: xilinx: Add ZynqMP firmware ioctl enums for RPU configuration.

[Michal Simek <michal.simek@amd.com>]

On 10/11/22 23:24, Tanmay Shah wrote:
> From: Ben Levinsky <ben.levinsky@amd.com>
> 
> Add ZynqMP firmware ioctl enums for RPU configuration and TCM Nodes for
> later use via request_node and release_node
> 
> Signed-off-by: Ben Levinsky <ben.levinsky@amd.com>
> Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
> ---
> 
> Changes in v10:
>    - None
> 
> Changes in v9:
>    - None
> 
> Changes in v8:
>    - None
> 
> Changes in v7:
>    - None
> 
> Changes in v6:
>    - None
> 
> Changes in v5:
>    - None
> 
> Changes in v4:
>    - None
> 
> Changes in v3:
>    - None
> 
>   include/linux/firmware/xlnx-zynqmp.h | 19 +++++++++++++++++++
>   1 file changed, 19 insertions(+)
> 
> diff --git a/include/linux/firmware/xlnx-zynqmp.h b/include/linux/firmware/xlnx-zynqmp.h
> index 9f50dacbf7d6..e00a25aa2c17 100644
> --- a/include/linux/firmware/xlnx-zynqmp.h
> +++ b/include/linux/firmware/xlnx-zynqmp.h
> @@ -135,6 +135,10 @@ enum pm_ret_status {
>   };
>   
>   enum pm_ioctl_id {
> +	IOCTL_GET_RPU_OPER_MODE = 0,
> +	IOCTL_SET_RPU_OPER_MODE = 1,
> +	IOCTL_RPU_BOOT_ADDR_CONFIG = 2,
> +	IOCTL_TCM_COMB_CONFIG = 3,
>   	IOCTL_SD_DLL_RESET = 6,
>   	IOCTL_SET_SD_TAPDELAY = 7,
>   	IOCTL_SET_PLL_FRAC_MODE = 8,
> @@ -172,6 +176,21 @@ enum pm_query_id {
>   	PM_QID_CLOCK_GET_MAX_DIVISOR = 13,
>   };
>   
> +enum rpu_oper_mode {
> +	PM_RPU_MODE_LOCKSTEP = 0,
> +	PM_RPU_MODE_SPLIT = 1,
> +};
> +
> +enum rpu_boot_mem {
> +	PM_RPU_BOOTMEM_LOVEC = 0,
> +	PM_RPU_BOOTMEM_HIVEC = 1,
> +};
> +
> +enum rpu_tcm_comb {
> +	PM_RPU_TCM_SPLIT = 0,
> +	PM_RPU_TCM_COMB = 1,
> +};
> +
>   enum zynqmp_pm_reset_action {
>   	PM_RESET_ACTION_RELEASE = 0,
>   	PM_RESET_ACTION_ASSERT = 1,

Acked-by: Michal Simek <michal.simek@amd.com>

M