* [PATCH v8 07/19] remoteproc: pull in slab.h [not found] <20200407011612.478226-1-mst@redhat.com> @ 2020-04-07 1:16 ` Michael S. Tsirkin 2020-04-07 1:16 ` Michael S. Tsirkin 2020-04-07 5:31 ` Bjorn Andersson 2020-04-07 1:16 ` [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size Michael S. Tsirkin 1 sibling, 2 replies; 8+ messages in thread From: Michael S. Tsirkin @ 2020-04-07 1:16 UTC (permalink / raw) To: linux-kernel; +Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc In preparation to virtio header changes, include slab.h directly as this module is using it. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/remoteproc/remoteproc_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 7f8536b73295..52b871327b55 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b/drivers/remoteproc/remoteproc_sysfs.c @@ -4,6 +4,7 @@ */ #include <linux/remoteproc.h> +#include <linux/slab.h> #include "remoteproc_internal.h" -- MST ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v8 07/19] remoteproc: pull in slab.h 2020-04-07 1:16 ` [PATCH v8 07/19] remoteproc: pull in slab.h Michael S. Tsirkin @ 2020-04-07 1:16 ` Michael S. Tsirkin 2020-04-07 5:31 ` Bjorn Andersson 1 sibling, 0 replies; 8+ messages in thread From: Michael S. Tsirkin @ 2020-04-07 1:16 UTC (permalink / raw) To: linux-kernel; +Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc In preparation to virtio header changes, include slab.h directly as this module is using it. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/remoteproc/remoteproc_sysfs.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c index 7f8536b73295..52b871327b55 100644 --- a/drivers/remoteproc/remoteproc_sysfs.c +++ b/drivers/remoteproc/remoteproc_sysfs.c @@ -4,6 +4,7 @@ */ #include <linux/remoteproc.h> +#include <linux/slab.h> #include "remoteproc_internal.h" -- MST ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v8 07/19] remoteproc: pull in slab.h 2020-04-07 1:16 ` [PATCH v8 07/19] remoteproc: pull in slab.h Michael S. Tsirkin 2020-04-07 1:16 ` Michael S. Tsirkin @ 2020-04-07 5:31 ` Bjorn Andersson 2020-04-07 5:31 ` Bjorn Andersson 1 sibling, 1 reply; 8+ messages in thread From: Bjorn Andersson @ 2020-04-07 5:31 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: linux-kernel, Ohad Ben-Cohen, linux-remoteproc On Mon 06 Apr 18:16 PDT 2020, Michael S. Tsirkin wrote: > In preparation to virtio header changes, include slab.h directly as > this module is using it. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/remoteproc/remoteproc_sysfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c > index 7f8536b73295..52b871327b55 100644 > --- a/drivers/remoteproc/remoteproc_sysfs.c > +++ b/drivers/remoteproc/remoteproc_sysfs.c > @@ -4,6 +4,7 @@ > */ > > #include <linux/remoteproc.h> > +#include <linux/slab.h> > > #include "remoteproc_internal.h" > > -- > MST > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 07/19] remoteproc: pull in slab.h 2020-04-07 5:31 ` Bjorn Andersson @ 2020-04-07 5:31 ` Bjorn Andersson 0 siblings, 0 replies; 8+ messages in thread From: Bjorn Andersson @ 2020-04-07 5:31 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: linux-kernel, Ohad Ben-Cohen, linux-remoteproc On Mon 06 Apr 18:16 PDT 2020, Michael S. Tsirkin wrote: > In preparation to virtio header changes, include slab.h directly as > this module is using it. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/remoteproc/remoteproc_sysfs.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/remoteproc/remoteproc_sysfs.c b/drivers/remoteproc/remoteproc_sysfs.c > index 7f8536b73295..52b871327b55 100644 > --- a/drivers/remoteproc/remoteproc_sysfs.c > +++ b/drivers/remoteproc/remoteproc_sysfs.c > @@ -4,6 +4,7 @@ > */ > > #include <linux/remoteproc.h> > +#include <linux/slab.h> > > #include "remoteproc_internal.h" > > -- > MST > ^ permalink raw reply [flat|nested] 8+ messages in thread
* [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size [not found] <20200407011612.478226-1-mst@redhat.com> 2020-04-07 1:16 ` [PATCH v8 07/19] remoteproc: pull in slab.h Michael S. Tsirkin @ 2020-04-07 1:16 ` Michael S. Tsirkin 2020-04-07 1:16 ` Michael S. Tsirkin 2020-04-07 5:30 ` Bjorn Andersson 1 sibling, 2 replies; 8+ messages in thread From: Michael S. Tsirkin @ 2020-04-07 1:16 UTC (permalink / raw) To: linux-kernel; +Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc These are used for legacy ring format, switch to APIs that make this explicit. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/remoteproc/remoteproc_virtio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 097f33e4f1f3..c350a01e6c4e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -322,7 +322,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i) struct rproc_mem_entry *mem; /* actual size of vring (in bytes) */ - size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); + size = PAGE_ALIGN(vring_legacy_size(rvring->len, rvring->align)); rsc = (void *)rproc->table_ptr + rvdev->rsc_offset; diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index 8c07cb2ca8ba..35b02468197a 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -95,7 +95,7 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev, len = rvring->len; /* zero vring */ - size = vring_size(len, rvring->align); + size = vring_legacy_size(len, rvring->align); memset(addr, 0, size); dev_dbg(dev, "vring%d: va %pK qsz %d notifyid %d\n", -- MST ^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size 2020-04-07 1:16 ` [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size Michael S. Tsirkin @ 2020-04-07 1:16 ` Michael S. Tsirkin 2020-04-07 5:30 ` Bjorn Andersson 1 sibling, 0 replies; 8+ messages in thread From: Michael S. Tsirkin @ 2020-04-07 1:16 UTC (permalink / raw) To: linux-kernel; +Cc: Ohad Ben-Cohen, Bjorn Andersson, linux-remoteproc These are used for legacy ring format, switch to APIs that make this explicit. Signed-off-by: Michael S. Tsirkin <mst@redhat.com> --- drivers/remoteproc/remoteproc_core.c | 2 +- drivers/remoteproc/remoteproc_virtio.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c index 097f33e4f1f3..c350a01e6c4e 100644 --- a/drivers/remoteproc/remoteproc_core.c +++ b/drivers/remoteproc/remoteproc_core.c @@ -322,7 +322,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i) struct rproc_mem_entry *mem; /* actual size of vring (in bytes) */ - size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); + size = PAGE_ALIGN(vring_legacy_size(rvring->len, rvring->align)); rsc = (void *)rproc->table_ptr + rvdev->rsc_offset; diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c index 8c07cb2ca8ba..35b02468197a 100644 --- a/drivers/remoteproc/remoteproc_virtio.c +++ b/drivers/remoteproc/remoteproc_virtio.c @@ -95,7 +95,7 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev, len = rvring->len; /* zero vring */ - size = vring_size(len, rvring->align); + size = vring_legacy_size(len, rvring->align); memset(addr, 0, size); dev_dbg(dev, "vring%d: va %pK qsz %d notifyid %d\n", -- MST ^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size 2020-04-07 1:16 ` [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size Michael S. Tsirkin 2020-04-07 1:16 ` Michael S. Tsirkin @ 2020-04-07 5:30 ` Bjorn Andersson 2020-04-07 5:30 ` Bjorn Andersson 1 sibling, 1 reply; 8+ messages in thread From: Bjorn Andersson @ 2020-04-07 5:30 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: linux-kernel, Ohad Ben-Cohen, linux-remoteproc On Mon 06 Apr 18:16 PDT 2020, Michael S. Tsirkin wrote: > These are used for legacy ring format, switch to APIs that make this > explicit. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 2 +- > drivers/remoteproc/remoteproc_virtio.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 097f33e4f1f3..c350a01e6c4e 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -322,7 +322,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i) > struct rproc_mem_entry *mem; > > /* actual size of vring (in bytes) */ > - size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); > + size = PAGE_ALIGN(vring_legacy_size(rvring->len, rvring->align)); > > rsc = (void *)rproc->table_ptr + rvdev->rsc_offset; > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 8c07cb2ca8ba..35b02468197a 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -95,7 +95,7 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev, > len = rvring->len; > > /* zero vring */ > - size = vring_size(len, rvring->align); > + size = vring_legacy_size(len, rvring->align); > memset(addr, 0, size); > > dev_dbg(dev, "vring%d: va %pK qsz %d notifyid %d\n", > -- > MST > ^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size 2020-04-07 5:30 ` Bjorn Andersson @ 2020-04-07 5:30 ` Bjorn Andersson 0 siblings, 0 replies; 8+ messages in thread From: Bjorn Andersson @ 2020-04-07 5:30 UTC (permalink / raw) To: Michael S. Tsirkin; +Cc: linux-kernel, Ohad Ben-Cohen, linux-remoteproc On Mon 06 Apr 18:16 PDT 2020, Michael S. Tsirkin wrote: > These are used for legacy ring format, switch to APIs that make this > explicit. > > Signed-off-by: Michael S. Tsirkin <mst@redhat.com> Acked-by: Bjorn Andersson <bjorn.andersson@linaro.org> Regards, Bjorn > --- > drivers/remoteproc/remoteproc_core.c | 2 +- > drivers/remoteproc/remoteproc_virtio.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c > index 097f33e4f1f3..c350a01e6c4e 100644 > --- a/drivers/remoteproc/remoteproc_core.c > +++ b/drivers/remoteproc/remoteproc_core.c > @@ -322,7 +322,7 @@ int rproc_alloc_vring(struct rproc_vdev *rvdev, int i) > struct rproc_mem_entry *mem; > > /* actual size of vring (in bytes) */ > - size = PAGE_ALIGN(vring_size(rvring->len, rvring->align)); > + size = PAGE_ALIGN(vring_legacy_size(rvring->len, rvring->align)); > > rsc = (void *)rproc->table_ptr + rvdev->rsc_offset; > > diff --git a/drivers/remoteproc/remoteproc_virtio.c b/drivers/remoteproc/remoteproc_virtio.c > index 8c07cb2ca8ba..35b02468197a 100644 > --- a/drivers/remoteproc/remoteproc_virtio.c > +++ b/drivers/remoteproc/remoteproc_virtio.c > @@ -95,7 +95,7 @@ static struct virtqueue *rp_find_vq(struct virtio_device *vdev, > len = rvring->len; > > /* zero vring */ > - size = vring_size(len, rvring->align); > + size = vring_legacy_size(len, rvring->align); > memset(addr, 0, size); > > dev_dbg(dev, "vring%d: va %pK qsz %d notifyid %d\n", > -- > MST > ^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2020-04-07 5:31 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20200407011612.478226-1-mst@redhat.com>
2020-04-07 1:16 ` [PATCH v8 07/19] remoteproc: pull in slab.h Michael S. Tsirkin
2020-04-07 1:16 ` Michael S. Tsirkin
2020-04-07 5:31 ` Bjorn Andersson
2020-04-07 5:31 ` Bjorn Andersson
2020-04-07 1:16 ` [PATCH v8 15/19] remoteproc: switch to virtio_legacy_init/size Michael S. Tsirkin
2020-04-07 1:16 ` Michael S. Tsirkin
2020-04-07 5:30 ` Bjorn Andersson
2020-04-07 5:30 ` Bjorn Andersson
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox