* [PATCH] rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge
@ 2022-05-11 12:07 Miaoqian Lin
2022-07-18 22:59 ` (subset) " Bjorn Andersson
0 siblings, 1 reply; 2+ messages in thread
From: Miaoqian Lin @ 2022-05-11 12:07 UTC (permalink / raw)
To: Andy Gross, Bjorn Andersson, Mathieu Poirier, linux-arm-msm,
linux-remoteproc, linux-kernel
Cc: linmq006
of_parse_phandle() returns a node pointer with refcount
incremented, we should use of_node_put() on it when done.
Fixes: 53e2822e56c7 ("rpmsg: Introduce Qualcomm SMD backend")
Signed-off-by: Miaoqian Lin <linmq006@gmail.com>
---
drivers/rpmsg/qcom_smd.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/rpmsg/qcom_smd.c b/drivers/rpmsg/qcom_smd.c
index 764c980507be..e559c8e468e3 100644
--- a/drivers/rpmsg/qcom_smd.c
+++ b/drivers/rpmsg/qcom_smd.c
@@ -1383,6 +1383,7 @@ static int qcom_smd_parse_edge(struct device *dev,
}
edge->ipc_regmap = syscon_node_to_regmap(syscon_np);
+ of_node_put(syscon_np);
if (IS_ERR(edge->ipc_regmap)) {
ret = PTR_ERR(edge->ipc_regmap);
goto put_node;
--
2.25.1
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: (subset) [PATCH] rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge
2022-05-11 12:07 [PATCH] rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge Miaoqian Lin
@ 2022-07-18 22:59 ` Bjorn Andersson
0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Andersson @ 2022-07-18 22:59 UTC (permalink / raw)
To: linux-kernel, linmq006, agross, mathieu.poirier, linux-remoteproc,
linux-arm-msm
On Wed, 11 May 2022 16:07:37 +0400, Miaoqian Lin wrote:
> of_parse_phandle() returns a node pointer with refcount
> incremented, we should use of_node_put() on it when done.
>
>
Applied, thanks!
[1/1] rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge
commit: 65382585f067d4256ba087934f30f85c9b6984de
Best regards,
--
Bjorn Andersson <bjorn.andersson@linaro.org>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-07-18 22:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2022-05-11 12:07 [PATCH] rpmsg: qcom_smd: Fix refcount leak in qcom_smd_parse_edge Miaoqian Lin
2022-07-18 22:59 ` (subset) " Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox