From: Nikita Travkin <nikita@trvn.ru>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konrad.dybcio@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
David Wronek <davidwronek@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 4/4] arm64: dts: qcom: sc7180: Add ADSP
Date: Wed, 06 Sep 2023 19:52:32 +0500 [thread overview]
Message-ID: <2caf25a10f8d97dd3694ec57ca0dad36@trvn.ru> (raw)
In-Reply-To: <4202b582-c0a0-ce13-7561-f5185fe1930a@linaro.org>
Krzysztof Kozlowski писал(а) 06.09.2023 18:36:
> On 05/09/2023 12:41, Nikita Travkin wrote:
>> sc7180 has an ADSP remoteproc that exclusively controls the audio
>> hardware on devices that use Qualcomm firmware.
>
>
>> + q6afe: service@4 {
>> + compatible = "qcom,q6afe";
>> + reg = <APR_SVC_AFE>;
>> + qcom,protection-domain = "avs/audio", "msm/adsp/audio_pd";
>> +
>> + q6afedai: dais {
>> + compatible = "qcom,q6afe-dais";
>> + #address-cells = <1>;
>> + #size-cells = <0>;
>> + #sound-dai-cells = <1>;
>> + };
>> +
>> + q6afecc: cc {
>
>
> No improvements.
>
> You need to add ADSP to your board and then test it. Otherwise you won't
> see errors and we do not want incorrect, even if disabled, nodes in DTSI.
>
Ah, didn't think the check would (partially) ignore disabled nodes...
Is there any simple way to instruct the checker to ignore disabled
status and test anyway? I'd like to be able to test the "clean"
series as-to-be-sent to have less places for error (and manual action
I guess...)
I will make sure to fix that for v3
Nikita
> Best regards,
> Krzysztof
next prev parent reply other threads:[~2023-09-06 14:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 10:41 [PATCH v2 0/4] sc7180: Add ADSP Nikita Travkin
2023-09-05 10:41 ` [PATCH v2 1/4] dt-bindings: remoteproc: qcom: sc7180-pas: Add ADSP compatible Nikita Travkin
2023-09-06 13:34 ` Krzysztof Kozlowski
2023-09-05 10:41 ` [PATCH v2 2/4] remoteproc: qcom: pas: Add sc7180 adsp Nikita Travkin
2023-09-05 10:41 ` [PATCH v2 3/4] arm64: dts: qcom: sc7180: Add tertiary mi2s pinctrl Nikita Travkin
2023-09-05 15:53 ` Konrad Dybcio
2023-09-05 16:19 ` Nikita Travkin
2023-09-05 10:41 ` [PATCH v2 4/4] arm64: dts: qcom: sc7180: Add ADSP Nikita Travkin
2023-09-06 11:59 ` Konrad Dybcio
2023-09-06 13:36 ` Krzysztof Kozlowski
2023-09-06 14:52 ` Nikita Travkin [this message]
2023-09-06 14:53 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2caf25a10f8d97dd3694ec57ca0dad36@trvn.ru \
--to=nikita@trvn.ru \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox