From: Nikita Travkin <nikita@trvn.ru>
To: Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Manivannan Sadhasivam <mani@kernel.org>,
cros-qcom-dts-watchers@chromium.org,
David Wronek <davidwronek@gmail.com>,
linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH v2 3/4] arm64: dts: qcom: sc7180: Add tertiary mi2s pinctrl
Date: Tue, 05 Sep 2023 21:19:49 +0500 [thread overview]
Message-ID: <c14229b715f98f3270bc7ee63409a8af@trvn.ru> (raw)
In-Reply-To: <4b87a766-9e8d-4676-b77e-d54e6d9c36ef@linaro.org>
Konrad Dybcio писал(а) 05.09.2023 20:53:
> On 5.09.2023 12:41, Nikita Travkin wrote:
>> Some devices use tertiary mi2s to connect external audio codec.
>> Add it near the other two i2s pinctrl definitions so the devices don't
>> have to duplicate it.
>>
>> Signed-off-by: Nikita Travkin <nikita@trvn.ru>
>> ---
> This sorting makes no sense, neither alphabetically nor gpio-idx-wise
>
> I'd suggest chucking it in after pri_mi2s_mclk_active.
>
I assumed these are alphabetically sorted since other nodes before mostly
are, with the pri_* being an outlier, but I can move it below if you think
it would be better.
Nikita
> Konrad
next prev parent reply other threads:[~2023-09-05 17:34 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-05 10:41 [PATCH v2 0/4] sc7180: Add ADSP Nikita Travkin
2023-09-05 10:41 ` [PATCH v2 1/4] dt-bindings: remoteproc: qcom: sc7180-pas: Add ADSP compatible Nikita Travkin
2023-09-06 13:34 ` Krzysztof Kozlowski
2023-09-05 10:41 ` [PATCH v2 2/4] remoteproc: qcom: pas: Add sc7180 adsp Nikita Travkin
2023-09-05 10:41 ` [PATCH v2 3/4] arm64: dts: qcom: sc7180: Add tertiary mi2s pinctrl Nikita Travkin
2023-09-05 15:53 ` Konrad Dybcio
2023-09-05 16:19 ` Nikita Travkin [this message]
2023-09-05 10:41 ` [PATCH v2 4/4] arm64: dts: qcom: sc7180: Add ADSP Nikita Travkin
2023-09-06 11:59 ` Konrad Dybcio
2023-09-06 13:36 ` Krzysztof Kozlowski
2023-09-06 14:52 ` Nikita Travkin
2023-09-06 14:53 ` Konrad Dybcio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c14229b715f98f3270bc7ee63409a8af@trvn.ru \
--to=nikita@trvn.ru \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=cros-qcom-dts-watchers@chromium.org \
--cc=davidwronek@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mani@kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox