From: Paul Cercueil <paul@crapouillou.net>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Cc: Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-stm32@st-md-mailman.stormreply.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 1/2] remoteproc: ingenic: Constify ingenic_rproc_ops
Date: Mon, 09 Nov 2020 22:47:27 +0000 [thread overview]
Message-ID: <3NWJJQ.S916PME9WPQT@crapouillou.net> (raw)
In-Reply-To: <20201107233630.9728-2-rikard.falkeborn@gmail.com>
Hi,
Le dim. 8 nov. 2020 à 0:36, Rikard Falkeborn
<rikard.falkeborn@gmail.com> a écrit :
> The only usage of ingenic_rproc_ops is to pass its address to
> devm_rproc_alloc(), which accepts a const pointer. Make it const to
> allow the compiler to put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> drivers/remoteproc/ingenic_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/ingenic_rproc.c
> b/drivers/remoteproc/ingenic_rproc.c
> index 1c2b21a5d178..26e19e6143b7 100644
> --- a/drivers/remoteproc/ingenic_rproc.c
> +++ b/drivers/remoteproc/ingenic_rproc.c
> @@ -135,7 +135,7 @@ static void *ingenic_rproc_da_to_va(struct rproc
> *rproc, u64 da, size_t len)
> return (__force void *)va;
> }
>
> -static struct rproc_ops ingenic_rproc_ops = {
> +static const struct rproc_ops ingenic_rproc_ops = {
> .prepare = ingenic_rproc_prepare,
> .unprepare = ingenic_rproc_unprepare,
> .start = ingenic_rproc_start,
> --
> 2.29.2
>
next prev parent reply other threads:[~2020-11-09 22:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 23:36 [PATCH 0/2] remoteproc: Constify static struct rproc_ops Rikard Falkeborn
2020-11-07 23:36 ` [PATCH 1/2] remoteproc: ingenic: Constify ingenic_rproc_ops Rikard Falkeborn
2020-11-09 22:47 ` Paul Cercueil [this message]
2020-11-07 23:36 ` [PATCH 2/2] remoteproc: stm32: Constify st_rproc_ops Rikard Falkeborn
2020-11-09 13:49 ` [Linux-stm32] " Arnaud POULIQUEN
2020-11-18 14:30 ` [PATCH 0/2] remoteproc: Constify static struct rproc_ops patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3NWJJQ.S916PME9WPQT@crapouillou.net \
--to=paul@crapouillou.net \
--cc=alexandre.torgue@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox