From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Rikard Falkeborn <rikard.falkeborn@gmail.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: "linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Paul Cercueil <paul@crapouillou.net>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>
Subject: Re: [Linux-stm32] [PATCH 2/2] remoteproc: stm32: Constify st_rproc_ops
Date: Mon, 9 Nov 2020 14:49:20 +0100 [thread overview]
Message-ID: <aff96f00-192b-e251-9a87-53dab368946c@st.com> (raw)
In-Reply-To: <20201107233630.9728-3-rikard.falkeborn@gmail.com>
Hi Rikard,
On 11/8/20 12:36 AM, Rikard Falkeborn wrote:
> The only usage of st_rproc_ops is to pass its address to rproc_alloc()
> which accepts a const pointer. Make it const to allow the compiler to
> put it in read-only memory.
>
> Signed-off-by: Rikard Falkeborn <rikard.falkeborn@gmail.com>
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index d2414cc1d90d..a180aeae9675 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -541,7 +541,7 @@ static void stm32_rproc_kick(struct rproc *rproc, int vqid)
> }
> }
>
> -static struct rproc_ops st_rproc_ops = {
> +static const struct rproc_ops st_rproc_ops = {
> .start = stm32_rproc_start,
> .stop = stm32_rproc_stop,
> .attach = stm32_rproc_attach,
>
acked-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
Thanks,
Arnaud
next prev parent reply other threads:[~2020-11-09 13:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-07 23:36 [PATCH 0/2] remoteproc: Constify static struct rproc_ops Rikard Falkeborn
2020-11-07 23:36 ` [PATCH 1/2] remoteproc: ingenic: Constify ingenic_rproc_ops Rikard Falkeborn
2020-11-09 22:47 ` Paul Cercueil
2020-11-07 23:36 ` [PATCH 2/2] remoteproc: stm32: Constify st_rproc_ops Rikard Falkeborn
2020-11-09 13:49 ` Arnaud POULIQUEN [this message]
2020-11-18 14:30 ` [PATCH 0/2] remoteproc: Constify static struct rproc_ops patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aff96f00-192b-e251-9a87-53dab368946c@st.com \
--to=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
--cc=paul@crapouillou.net \
--cc=rikard.falkeborn@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox