Re: [PATCH 03/18] remoteproc: imx: Convert to platform remove callback returning void

[Iuliana Prodan <iuliana.prodan@nxp.com>]

On 5/4/2023 10:44 PM, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
>
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
>
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Iuliana Prodan <iuliana.prodan@nxp.com>


> ---
>   drivers/remoteproc/imx_rproc.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 0ab840dc7e97..f9874fc5a80f 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -1112,7 +1112,7 @@ static int imx_rproc_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int imx_rproc_remove(struct platform_device *pdev)
> +static void imx_rproc_remove(struct platform_device *pdev)
>   {
>   	struct rproc *rproc = platform_get_drvdata(pdev);
>   	struct imx_rproc *priv = rproc->priv;
> @@ -1123,8 +1123,6 @@ static int imx_rproc_remove(struct platform_device *pdev)
>   	imx_rproc_free_mbox(rproc);
>   	destroy_workqueue(priv->workqueue);
>   	rproc_free(rproc);
> -
> -	return 0;
>   }
>   
>   static const struct of_device_id imx_rproc_of_match[] = {
> @@ -1145,7 +1143,7 @@ MODULE_DEVICE_TABLE(of, imx_rproc_of_match);
>   
>   static struct platform_driver imx_rproc_driver = {
>   	.probe = imx_rproc_probe,
> -	.remove = imx_rproc_remove,
> +	.remove_new = imx_rproc_remove,
>   	.driver = {
>   		.name = "imx-rproc",
>   		.of_match_table = imx_rproc_of_match,