Re: [PATCH 06/18] remoteproc: mtk_scp: Convert to platform remove callback returning void

[Matthias Brugger <matthias.bgg@gmail.com>]

On 04/05/2023 21:44, Uwe Kleine-König wrote:
> The .remove() callback for a platform driver returns an int which makes
> many driver authors wrongly assume it's possible to do error handling by
> returning an error code. However the value returned is (mostly) ignored
> and this typically results in resource leaks. To improve here there is a
> quest to make the remove callback return void. In the first step of this
> quest all drivers are converted to .remove_new() which already returns
> void.
> 
> Trivially convert this driver from always returning zero in the remove
> callback to the void returning variant.
> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>

Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>

> ---
>   drivers/remoteproc/mtk_scp.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/remoteproc/mtk_scp.c b/drivers/remoteproc/mtk_scp.c
> index e1d93e63d7df..dcc94ee2458d 100644
> --- a/drivers/remoteproc/mtk_scp.c
> +++ b/drivers/remoteproc/mtk_scp.c
> @@ -913,7 +913,7 @@ static int scp_probe(struct platform_device *pdev)
>   	return ret;
>   }
>   
> -static int scp_remove(struct platform_device *pdev)
> +static void scp_remove(struct platform_device *pdev)
>   {
>   	struct mtk_scp *scp = platform_get_drvdata(pdev);
>   	int i;
> @@ -925,8 +925,6 @@ static int scp_remove(struct platform_device *pdev)
>   	for (i = 0; i < SCP_IPI_MAX; i++)
>   		mutex_destroy(&scp->ipi_desc[i].lock);
>   	mutex_destroy(&scp->send_lock);
> -
> -	return 0;
>   }
>   
>   static const struct mtk_scp_of_data mt8183_of_data = {
> @@ -1003,7 +1001,7 @@ MODULE_DEVICE_TABLE(of, mtk_scp_of_match);
>   
>   static struct platform_driver mtk_scp_driver = {
>   	.probe = scp_probe,
> -	.remove = scp_remove,
> +	.remove_new = scp_remove,
>   	.driver = {
>   		.name = "mtk-scp",
>   		.of_match_table = mtk_scp_of_match,