[PATCH] remoteproc: omap: add comment for is_iomem

[PATCH] remoteproc: omap: add comment for is_iomem

[Peng Fan (OSS)]

From: Peng Fan <peng.fan@nxp.com>

Address warning: "Function parameter or struct member 'is_iomem' not
described in 'omap_rproc_da_to_va'" with adding comment for is_iomem.

Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202502161648.WZWrFV7I-lkp@intel.com/
Cc: Andrew Davis <afd@ti.com>
Signed-off-by: Peng Fan <peng.fan@nxp.com>
---
 drivers/remoteproc/omap_remoteproc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
index 5f463937cbbf..9c7182b3b038 100644
--- a/drivers/remoteproc/omap_remoteproc.c
+++ b/drivers/remoteproc/omap_remoteproc.c
@@ -724,6 +724,7 @@ static int omap_rproc_stop(struct rproc *rproc)
  * @rproc: remote processor to apply the address translation for
  * @da: device address to translate
  * @len: length of the memory buffer
+ * @is_iomem: pointer filled in to indicate if @da is iomapped memory
  *
  * Custom function implementing the rproc .da_to_va ops to provide address
  * translation (device address to kernel virtual address) for internal RAMs
-- 
2.37.1

Re: [PATCH] remoteproc: omap: add comment for is_iomem

[Mathieu Poirier]

On Mon, Feb 17, 2025 at 03:58:58PM +0800, Peng Fan (OSS) wrote:
> From: Peng Fan <peng.fan@nxp.com>
> 
> Address warning: "Function parameter or struct member 'is_iomem' not
> described in 'omap_rproc_da_to_va'" with adding comment for is_iomem.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202502161648.WZWrFV7I-lkp@intel.com/
> Cc: Andrew Davis <afd@ti.com>
> Signed-off-by: Peng Fan <peng.fan@nxp.com>
> ---
>  drivers/remoteproc/omap_remoteproc.c | 1 +
>  1 file changed, 1 insertion(+)
>

Applied - thanks,
Mathieu

> diff --git a/drivers/remoteproc/omap_remoteproc.c b/drivers/remoteproc/omap_remoteproc.c
> index 5f463937cbbf..9c7182b3b038 100644
> --- a/drivers/remoteproc/omap_remoteproc.c
> +++ b/drivers/remoteproc/omap_remoteproc.c
> @@ -724,6 +724,7 @@ static int omap_rproc_stop(struct rproc *rproc)
>   * @rproc: remote processor to apply the address translation for
>   * @da: device address to translate
>   * @len: length of the memory buffer
> + * @is_iomem: pointer filled in to indicate if @da is iomapped memory
>   *
>   * Custom function implementing the rproc .da_to_va ops to provide address
>   * translation (device address to kernel virtual address) for internal RAMs
> -- 
> 2.37.1
>