From: Simon Horman <horms@verge.net.au>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
"magnus.damm@gmail.com" <magnus.damm@gmail.com>,
"linux@arm.linux.org.uk" <linux@arm.linux.org.uk>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-renesas-soc@vger.kernel.org"
<linux-renesas-soc@vger.kernel.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"pawel.moll@arm.com" <pawel.moll@arm.com>,
"mark.rutland@arm.com" <mark.rutland@arm.com>,
"ijc+devicetree@hellion.org.uk" <ijc+devicetree@hellion.org.uk>,
"galak@codeaurora.org" <galak@codeaurora.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>
Subject: Re: [PATCH] ARM: dts: porter: add MAX3355 support
Date: Mon, 15 Feb 2016 10:45:27 +0900 [thread overview]
Message-ID: <20160215014527.GE12997@verge.net.au> (raw)
In-Reply-To: <56AFAB67.20404@cogentembedded.com>
On Mon, Feb 01, 2016 at 10:00:55PM +0300, Sergei Shtylyov wrote:
> On 02/01/2016 08:54 PM, Sergei Shtylyov wrote:
>
> >>>>>>From: linux-renesas-soc-owner@vger.kernel.org
> >>>>>>[mailto:linux-renesas-soc-owner@vger.kernel.org] On Behalf Of Sergei
> >>>>>>Shtylyov
> >>>>>>Sent: Wednesday, January 27, 2016 7:14 AM
> >>>>>>
> >>>>>>Now that Maxim Integrated MAX3355 'extcon' driver and device tree bindings
> >>>>>>are upstream along with the 'extcon' hook in the Renesas USBHS driver, we
> >>>>>>can add MAX3355 device node to the Porter device tree and properly refer
> >>>>>>to it from the USBHS node instead of using "renesas,enable-gpio" property
> >>>>>>which only allowed checking the USB ID pin at the driver probe time; now
> >>>>>>this pin's state can be monitored dynamically!
> >>>>>>
> >>>>>>Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
> >>>>>
> >>>>>I tested this patch on Porter, but interrupt of "usb-otg" didn't happened
> >>>>>even if I connected/disconnected a usb convert cable (usb micro-ab to A).
> >>>>>Remarks: I confirmed that the usb convert cable worked correctly on other
> >>>>>board.
> >>>>
> >>>> I guess I have the same cable
> >>>
> >>> No, I have mini-AB connector here and hence my cable is mini-AB to A.
> >>
> >>I checked Porter specification and then I found 2 specifications exist...
> >
> > I've looked thru my schematics files and found 3: Rev. 1.1 Update Version
> >2, "PORTER_2" Rev. 3.0 Preliminary, and "PORTER_C" Rev. 3.0 Release version!
> >I'm not sure which of the last 2 should be considered final...
>
> Now I've found 5 versions of the Porter schematics... :-)
>
> >> Porter "B" : mini AB connecter and Max3355 is on the board.
> >> Porter "C" : micro AB connect and Max3355 is not on the board. (Select
> >>host/peripheral by a jumper.)
> >
> > Yeah, seeing JP13 in the PORTER_C schematics.
> >
> >>I guess that your current target is "B".
> >
> > If not earlier. It actually has "Henninger B REV2" printed on it and
> >"Porter PCB 1 R3" on a pasted sticker.
> >
> >>If so, I think this patch is acceptable.
> >
> > I'm not so sure now...
>
> My boss told me PORTER_C is a final version, so this patch isn't needed.
> But then another patch is needed instead: to remove "renesas,enable-gpio"
> prop from the HS-USB device node...
I am marking this patch as "Rejected" in patchwork.
If changes are required in this area please either
resubmit this patch or post a different one.
Thanks.
next prev parent reply other threads:[~2016-02-15 1:45 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1674850.BZpGW9kEud@wasted.cogentembedded.com>
2016-01-21 22:36 ` [PATCH] ARM: dts: porter: add sound support Sergei Shtylyov
2016-01-25 0:35 ` Kuninori Morimoto
2016-01-26 0:43 ` Simon Horman
2016-01-26 14:31 ` Sergei Shtylyov
2016-01-26 22:14 ` [PATCH] ARM: dts: porter: add MAX3355 support Sergei Shtylyov
2016-01-28 5:49 ` Yoshihiro Shimoda
2016-01-29 20:28 ` Sergei Shtylyov
2016-01-29 20:49 ` Sergei Shtylyov
2016-02-01 11:17 ` Yoshihiro Shimoda
2016-02-01 17:54 ` Sergei Shtylyov
2016-02-01 19:00 ` Sergei Shtylyov
2016-02-15 1:45 ` Simon Horman [this message]
2016-02-15 10:59 ` Sergei Shtylyov
2016-02-11 20:26 ` [PATCH] ARM: dts: silk: add sound support Sergei Shtylyov
2016-02-15 4:56 ` Kuninori Morimoto
2016-02-11 21:49 ` [PATCH] ARM: dts: porter: fix JP3 jumper description Sergei Shtylyov
2016-02-15 4:50 ` Kuninori Morimoto
2016-02-15 21:55 ` Simon Horman
2016-02-13 22:26 ` [PATCH] ARM: dts: porter: remove enable prop from HS-USB device node Sergei Shtylyov
2016-02-26 19:43 ` Sergei Shtylyov
2016-03-02 0:47 ` Simon Horman
2016-04-13 19:36 ` [PATCH] ARM: dts: silk: add DU pins Sergei Shtylyov
2016-06-17 20:53 ` Sergei Shtylyov
2016-06-20 8:35 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160215014527.GE12997@verge.net.au \
--to=horms@verge.net.au \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
--cc=yoshihiro.shimoda.uh@renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox