Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

Re: [PATCH v2 0/4] watchdog: add driver for Renesas Gen3 WDT watchdogs

[Wim Van Sebroeck]

Hi Wolfram,

> Here is V2 of this series with the following changes:
> 
> * include bitops.h
> * s/unsigned/unsigned int/
> * drop set_timeout() because core does it already
> * add get_timeleft()
> * don't make "nowayout" a readable parameter
> * use "watchdog" instead of "wdt" in the dt bindings
> 
> The dts and defconfig changes should go via Simon's tree once the driver is
> accepted.
> 
> To use this driver, you need a recent firmware/uboot which initializes the
> WDTRSTCR register which can only be changed in secure mode. 'md 0xe6160054 4'
> should give you 0x8002 or something else with bit 15 set and bit 0 cleared.
> 
> Also, you need the clock enablement patches which just have been posted in
> their newest version to the renesas-soc mailing list and are also in
> close-to-be-applied state.
> 
> A complete branch to test can be found here:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/v8-wdt
> 
> Please review, test, comment...
> 
> Thanks,
> 
>    Wolfram
> 
> 
> Wolfram Sang (4):
>   watchdog: renesas-wdt: add driver
>   arm64: dts: r8a7795: Add RWDT node
>   arm64: dts: salvator-x: Enable watchdog timer
>   arm64: defconfig: enable Renesas Watchdog Timer
> 
>  .../devicetree/bindings/watchdog/renesas-wdt.txt   |  25 +++
>  arch/arm64/boot/dts/renesas/r8a7795-salvator-x.dts |   5 +
>  arch/arm64/boot/dts/renesas/r8a7795.dtsi           |   8 +
>  arch/arm64/configs/defconfig                       |   2 +
>  drivers/watchdog/Kconfig                           |   8 +
>  drivers/watchdog/Makefile                          |   1 +
>  drivers/watchdog/renesas_wdt.c                     | 213 +++++++++++++++++++++
>  7 files changed, 262 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/watchdog/renesas-wdt.txt
>  create mode 100644 drivers/watchdog/renesas_wdt.c
> 
> -- 
> 2.7.0
>

Patch 1 and 4 have been added to linux-watchdog-next.

Kind regards,
Wim.
 

Re: [PATCH v2 2/4] arm64: dts: r8a7795: Add RWDT node

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 555 bytes --]

On Mon, Apr 04, 2016 at 07:00:57AM -0700, Guenter Roeck wrote:
> On Fri, Apr 01, 2016 at 01:56:24PM +0200, Wolfram Sang wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > This patch adds the RWDT device node for r8a7795.
> > 
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Acked-by: Guenter Roeck <linux@roeck-us.net>
> 
> I assume the dts patches will go through the an arm64 tree.
> Is this correct ?

Yes. Simon: ping :)


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 3/4] arm64: dts: salvator-x: Enable watchdog timer

[Wolfram Sang]

[-- Attachment #1: Type: text/plain, Size: 493 bytes --]

On Mon, Apr 04, 2016 at 07:01:31AM -0700, Guenter Roeck wrote:
> On Fri, Apr 01, 2016 at 01:56:25PM +0200, Wolfram Sang wrote:
> > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > This patch enables watchdog timer for Salvator-X board.
> > 
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> 
> Acked-by: Guenter Roeck <linux2roeck-us.net>

Thanks. s/2/@/, I assume ;) Simon: ping


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

Re: [PATCH v2 2/4] arm64: dts: r8a7795: Add RWDT node

[Simon Horman]

On Wed, May 18, 2016 at 11:38:32AM +0200, Wolfram Sang wrote:
> On Mon, Apr 04, 2016 at 07:00:57AM -0700, Guenter Roeck wrote:
> > On Fri, Apr 01, 2016 at 01:56:24PM +0200, Wolfram Sang wrote:
> > > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > 
> > > This patch adds the RWDT device node for r8a7795.
> > > 
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > Acked-by: Guenter Roeck <linux@roeck-us.net>
> > 
> > I assume the dts patches will go through the an arm64 tree.
> > Is this correct ?
> 
> Yes. Simon: ping :)

Thanks, I have queued this up.

Re: [PATCH v2 3/4] arm64: dts: salvator-x: Enable watchdog timer

[Simon Horman]

On Wed, May 18, 2016 at 11:39:54AM +0200, Wolfram Sang wrote:
> On Mon, Apr 04, 2016 at 07:01:31AM -0700, Guenter Roeck wrote:
> > On Fri, Apr 01, 2016 at 01:56:25PM +0200, Wolfram Sang wrote:
> > > From: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > > 
> > > This patch enables watchdog timer for Salvator-X board.
> > > 
> > > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > > Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > Acked-by: Guenter Roeck <linux2roeck-us.net>
> 
> Thanks. s/2/@/, I assume ;) Simon: ping

Thanks, I have have queued this up.