Linux Renesas SOC kernel development
 help / color / mirror / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Cc: Vladimir Barinov <vladimir.barinov@cogentembedded.com>,
	Magnus Damm <magnus.damm@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support
Date: Fri, 2 Sep 2016 10:19:25 +0200	[thread overview]
Message-ID: <20160902081925.GC16669@verge.net.au> (raw)
In-Reply-To: <87d1knumv9.wl%kuninori.morimoto.gx@renesas.com>

On Fri, Sep 02, 2016 at 01:19:49AM +0000, Kuninori Morimoto wrote:
> 
> Hi Vladimir
> 
> > This supports SSI sound for H3ULCB board.
> > SSI DMA mode used. CS2000 used as AUDIO_CLK_B.
> > 
> > Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> > ---
> 
> Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
> 
> > +	audio_clkout: audio_clkout {
> > +		compatible = "fixed-clock";
> > +		#clock-cells = <0>;
> > +		clock-frequency = <11289600>;
> > +	};
> 
> I think having commont for AUDIO_CLKOUT is better for user, like Salvator-X.
> This "audio_clkout" is dummy. Actually, we don't need this dummy clock,
> and we should use "<&rcar_sound 0>" as AUDIO_CLKOUT,
> like AUDIO_CLKOUT3 as "<&rcar_sound 3>" which is used on ak4613. 
> But Salvator-X and this ULCB board has very complex connection,
> especially around CS2000.
> This means cs2000 requests rcar_sound, and rcar_sound requests cs2000.
> This audio_clkout exist to avoid probe dead-lock.
> This is the reason why audio_clkout and rcar_sound::clock-frequency
> has same value.

Vladimir,

please address the above and include it when you repost the patches
that I haven't queued up.

  reply	other threads:[~2016-09-02  8:30 UTC|newest]

Thread overview: 43+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-31 10:01 [PATCH v3 0/12] arm64: renesas: add H3ULCB board Vladimir Barinov
2016-08-31 10:02 ` [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings Vladimir Barinov
2016-10-25 12:48   ` Geert Uytterhoeven
2016-10-25 15:06     ` Vladimir Barinov
2016-10-26 10:27       ` Vladimir Barinov
2016-10-26 11:33         ` Geert Uytterhoeven
2016-08-31 10:02 ` [PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree Vladimir Barinov
2016-09-01  7:38   ` Geert Uytterhoeven
2016-08-31 10:02 ` [PATCH v3 03/12] arm64: dts: h3ulcb: enable SCIF clk and pins Vladimir Barinov
2016-09-01  7:39   ` Geert Uytterhoeven
2016-08-31 10:02 ` [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB Vladimir Barinov
2016-09-01  7:48   ` Geert Uytterhoeven
2016-09-01 10:11     ` Sergei Shtylyov
2016-08-31 10:03 ` [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds Vladimir Barinov
2016-09-01  7:52   ` Geert Uytterhoeven
2016-09-01 10:24     ` Vladimir Barinov
2016-08-31 10:03 ` [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0 Vladimir Barinov
2016-09-01  8:11   ` Geert Uytterhoeven
2016-09-01 10:41     ` Vladimir Barinov
2016-09-01 11:15       ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 07/12] arm64: dts: h3ulcb: enable I2C2 Vladimir Barinov
2016-09-01  8:21   ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 08/12] arm64: dts: h3ulcb: enable EXTALR clk Vladimir Barinov
2016-09-01  8:21   ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 09/12] arm64: dts: h3ulcb: enable WDT Vladimir Barinov
2016-09-01  8:22   ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1 Vladimir Barinov
2016-09-01  8:25   ` Geert Uytterhoeven
2016-08-31 10:04 ` [PATCH v3 11/12] arm64: dts: h3ulcb: enable USB2.0 Host " Vladimir Barinov
2016-09-01  8:32   ` Geert Uytterhoeven
2016-08-31 10:04 ` [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support Vladimir Barinov
2016-09-02  1:19   ` Kuninori Morimoto
2016-09-02  8:19     ` Simon Horman [this message]
2016-09-01  8:39 ` [PATCH v3 0/12] arm64: renesas: add H3ULCB board Geert Uytterhoeven
2016-09-01 10:43   ` Vladimir Barinov
2016-09-01 14:17   ` Simon Horman
2016-09-01 14:27     ` Simon Horman
2016-09-01 19:25     ` Geert Uytterhoeven
2016-09-02  7:59       ` Simon Horman
  -- strict thread matches above, loose matches on Subject: below --
2016-09-02 12:04 [PATCH v4 0/4] arm64: renesas: enable H3ULCB board peripherals Vladimir Barinov
2016-09-02 12:05 ` [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support Vladimir Barinov
2016-09-02 12:08   ` Vladimir Barinov
2016-09-02 12:38   ` Sergei Shtylyov
2016-09-02 14:33     ` Vladimir Barinov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160902081925.GC16669@verge.net.au \
    --to=horms@verge.net.au \
    --cc=devicetree@vger.kernel.org \
    --cc=kuninori.morimoto.gx@renesas.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=vladimir.barinov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox