From: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Simon Horman <horms@verge.net.au>,
Magnus Damm <magnus.damm@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>
Subject: Re: [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds
Date: Thu, 1 Sep 2016 13:24:58 +0300 [thread overview]
Message-ID: <c9c67ae9-d540-df19-14ab-e01b9248ffd2@cogentembedded.com> (raw)
In-Reply-To: <CAMuHMdUpcajev3CsdhtpaD4PrqAOPsAcnv+65TFv-we6FPmDVw@mail.gmail.com>
Hi Geert,
Thank you for the review.
On 01.09.2016 10:52, Geert Uytterhoeven wrote:
> On Wed, Aug 31, 2016 at 12:03 PM, Vladimir Barinov
> <vladimir.barinov@cogentembedded.com> wrote:
>> This supports GPIO leds on H3ULCB board
>>
>> Signed-off-by: Vladimir Barinov <vladimir.barinov@cogentembedded.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
>> --- a/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> +++ b/arch/arm64/boot/dts/renesas/r8a7795-h3ulcb.dts
>> @@ -31,6 +31,19 @@
>> /* first 128MB is reserved for secure area. */
>> reg = <0x0 0x48000000 0x0 0x38000000>;
>> };
>> +
>> + leds {
>> + compatible = "gpio-leds";
>> + led4 {
>> + gpios = <&gpio6 11 GPIO_ACTIVE_HIGH>;
>> + };
>> + led5 {
>> + gpios = <&gpio6 12 GPIO_ACTIVE_HIGH>;
>> + };
>> + led6 {
>> + gpios = <&gpio6 13 GPIO_ACTIVE_HIGH>;
>> + };
>> + };
> The LEDs share GPIOs with the switches. Unfortunately you cannot use both
> at the same time.
> Perhaps we want to configure one of them for the switch, to be used as a
> wakeup-source?
This is a good point.
I will respin this patch accordingly to your suggestion.
Regards,
Vladimir
>
> The same applies to Salvator-X, where we haven't wired up the LEDs nor
> switches (yet).
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
next prev parent reply other threads:[~2016-09-01 10:26 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-31 10:01 [PATCH v3 0/12] arm64: renesas: add H3ULCB board Vladimir Barinov
2016-08-31 10:02 ` [PATCH v3 01/12] dt: arm: shmobile: add H3ULCB board DT bindings Vladimir Barinov
2016-10-25 12:48 ` Geert Uytterhoeven
2016-10-25 15:06 ` Vladimir Barinov
2016-10-26 10:27 ` Vladimir Barinov
2016-10-26 11:33 ` Geert Uytterhoeven
2016-08-31 10:02 ` [PATCH v3 02/12] arm64: dts: h3ulcb: initial device tree Vladimir Barinov
2016-09-01 7:38 ` Geert Uytterhoeven
2016-08-31 10:02 ` [PATCH v3 03/12] arm64: dts: h3ulcb: enable SCIF clk and pins Vladimir Barinov
2016-09-01 7:39 ` Geert Uytterhoeven
2016-08-31 10:02 ` [PATCH v3 04/12] arm64: dts: h3ulcb: enable EthernetAVB Vladimir Barinov
2016-09-01 7:48 ` Geert Uytterhoeven
2016-09-01 10:11 ` Sergei Shtylyov
2016-08-31 10:03 ` [PATCH v3 05/12] arm64: dts: h3ulcb: enable GPIO leds Vladimir Barinov
2016-09-01 7:52 ` Geert Uytterhoeven
2016-09-01 10:24 ` Vladimir Barinov [this message]
2016-08-31 10:03 ` [PATCH v3 06/12] arm64: dts: h3ulcb: enable SDHI0 Vladimir Barinov
2016-09-01 8:11 ` Geert Uytterhoeven
2016-09-01 10:41 ` Vladimir Barinov
2016-09-01 11:15 ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 07/12] arm64: dts: h3ulcb: enable I2C2 Vladimir Barinov
2016-09-01 8:21 ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 08/12] arm64: dts: h3ulcb: enable EXTALR clk Vladimir Barinov
2016-09-01 8:21 ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 09/12] arm64: dts: h3ulcb: enable WDT Vladimir Barinov
2016-09-01 8:22 ` Geert Uytterhoeven
2016-08-31 10:03 ` [PATCH v3 10/12] arm64: dts: h3ulcb: enable USB2 PHY of channel 1 Vladimir Barinov
2016-09-01 8:25 ` Geert Uytterhoeven
2016-08-31 10:04 ` [PATCH v3 11/12] arm64: dts: h3ulcb: enable USB2.0 Host " Vladimir Barinov
2016-09-01 8:32 ` Geert Uytterhoeven
2016-08-31 10:04 ` [PATCH v3 12/12] arm64: dts: h3ulcb: Sound SSI support Vladimir Barinov
2016-09-02 1:19 ` Kuninori Morimoto
2016-09-02 8:19 ` Simon Horman
2016-09-01 8:39 ` [PATCH v3 0/12] arm64: renesas: add H3ULCB board Geert Uytterhoeven
2016-09-01 10:43 ` Vladimir Barinov
2016-09-01 14:17 ` Simon Horman
2016-09-01 14:27 ` Simon Horman
2016-09-01 19:25 ` Geert Uytterhoeven
2016-09-02 7:59 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c9c67ae9-d540-df19-14ab-e01b9248ffd2@cogentembedded.com \
--to=vladimir.barinov@cogentembedded.com \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=horms@verge.net.au \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox