Linux Renesas SOC kernel development
 help / color / mirror / Atom feed
* [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock
@ 2016-11-07 19:07 Geert Uytterhoeven
  2016-11-08 12:16 ` Yoshihiro Shimoda
  2016-11-15 17:56 ` Simon Horman
  0 siblings, 2 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2016-11-07 19:07 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Shinobu Uehara, Yoshihiro Shimoda, linux-renesas-soc,
	Geert Uytterhoeven

The parent clock of the HSUSB clock is the HP clock, not the MP clock.

Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm/boot/dts/r8a7794.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
index 01816ac775a8d177..7d9f0601d3ca8def 100644
--- a/arch/arm/boot/dts/r8a7794.dtsi
+++ b/arch/arm/boot/dts/r8a7794.dtsi
@@ -1262,7 +1262,7 @@
 		mstp7_clks: mstp7_clks@e615014c {
 			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
 			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
-			clocks = <&mp_clk>, <&mp_clk>,
+			clocks = <&mp_clk>, <&hp_clk>,
 				 <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>,
 				 <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
 				 <&zx_clk>;
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* RE: [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock
  2016-11-07 19:07 [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock Geert Uytterhoeven
@ 2016-11-08 12:16 ` Yoshihiro Shimoda
  2016-11-09  7:34   ` Simon Horman
  2016-11-15 17:56 ` Simon Horman
  1 sibling, 1 reply; 4+ messages in thread
From: Yoshihiro Shimoda @ 2016-11-08 12:16 UTC (permalink / raw)
  To: Geert Uytterhoeven, Simon Horman, Magnus Damm
  Cc: Shinobu Uehara, linux-renesas-soc@vger.kernel.org

Hi Geert-san,

> -----Original Message-----
> From: Geert Uytterhoeven
> Sent: Tuesday, November 08, 2016 4:07 AM
> 
> The parent clock of the HSUSB clock is the HP clock, not the MP clock.
> 
> Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thank you for the patch.

Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Best regards,
Yoshihiro Shimoda

> ---
>  arch/arm/boot/dts/r8a7794.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
> index 01816ac775a8d177..7d9f0601d3ca8def 100644
> --- a/arch/arm/boot/dts/r8a7794.dtsi
> +++ b/arch/arm/boot/dts/r8a7794.dtsi
> @@ -1262,7 +1262,7 @@
>  		mstp7_clks: mstp7_clks@e615014c {
>  			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
>  			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
> -			clocks = <&mp_clk>, <&mp_clk>,
> +			clocks = <&mp_clk>, <&hp_clk>,
>  				 <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>,
>  				 <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>  				 <&zx_clk>;
> --
> 1.9.1

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock
  2016-11-08 12:16 ` Yoshihiro Shimoda
@ 2016-11-09  7:34   ` Simon Horman
  0 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-11-09  7:34 UTC (permalink / raw)
  To: Yoshihiro Shimoda
  Cc: Geert Uytterhoeven, Magnus Damm, Shinobu Uehara,
	linux-renesas-soc@vger.kernel.org

On Tue, Nov 08, 2016 at 12:16:17PM +0000, Yoshihiro Shimoda wrote:
> Hi Geert-san,
> 
> > -----Original Message-----
> > From: Geert Uytterhoeven
> > Sent: Tuesday, November 08, 2016 4:07 AM
> > 
> > The parent clock of the HSUSB clock is the HP clock, not the MP clock.
> > 
> > Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree")
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Thank you for the patch.
> 
> Acked-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>

Thanks, I have queued this up.

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock
  2016-11-07 19:07 [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock Geert Uytterhoeven
  2016-11-08 12:16 ` Yoshihiro Shimoda
@ 2016-11-15 17:56 ` Simon Horman
  1 sibling, 0 replies; 4+ messages in thread
From: Simon Horman @ 2016-11-15 17:56 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Magnus Damm, Shinobu Uehara, Yoshihiro Shimoda, linux-renesas-soc

On Mon, Nov 07, 2016 at 08:07:07PM +0100, Geert Uytterhoeven wrote:
> The parent clock of the HSUSB clock is the HP clock, not the MP clock.
> 
> Fixes: c7bab9f929e51761 ("ARM: shmobile: r8a7794: Add USB clocks to device tree")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, I have queued this up.

I also checked that the correct parent is used on the r8a7790, 1 and 3.
HSUSB is not present on the r8a7792.

> ---
>  arch/arm/boot/dts/r8a7794.dtsi | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/r8a7794.dtsi b/arch/arm/boot/dts/r8a7794.dtsi
> index 01816ac775a8d177..7d9f0601d3ca8def 100644
> --- a/arch/arm/boot/dts/r8a7794.dtsi
> +++ b/arch/arm/boot/dts/r8a7794.dtsi
> @@ -1262,7 +1262,7 @@
>  		mstp7_clks: mstp7_clks@e615014c {
>  			compatible = "renesas,r8a7794-mstp-clocks", "renesas,cpg-mstp-clocks";
>  			reg = <0 0xe615014c 0 4>, <0 0xe61501c4 0 4>;
> -			clocks = <&mp_clk>, <&mp_clk>,
> +			clocks = <&mp_clk>, <&hp_clk>,
>  				 <&zs_clk>, <&p_clk>, <&p_clk>, <&zs_clk>,
>  				 <&zs_clk>, <&p_clk>, <&p_clk>, <&p_clk>, <&p_clk>,
>  				 <&zx_clk>;
> -- 
> 1.9.1
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2016-11-15 17:56 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-07 19:07 [PATCH] ARM: dts: r8a7794: Correct hsusb parent clock Geert Uytterhoeven
2016-11-08 12:16 ` Yoshihiro Shimoda
2016-11-09  7:34   ` Simon Horman
2016-11-15 17:56 ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox