[PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC

Linux Renesas SOC kernel development
 help / color / mirror / Atom feed

* [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC
@ 2017-03-07  5:27 Kuninori Morimoto
  2017-03-07  5:28 ` [PATCH 1/4] ARM: dts: r8a7790: " Kuninori Morimoto
                   ` (4 more replies)
  0 siblings, 5 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-03-07  5:27 UTC (permalink / raw)
  To: Simon; +Cc: Magnus, linux-renesas-soc


Hi Simon

These fixup DVC Audio-DMAC channel assignment
which was not same as SRC/SSI policy.
Because of this (is a little bit excessive),
current Playback/Capture on each platform
(= Lager/Koelsch/Gose/Salvator) are using same
Audio-DMAC0. Playback/Capture uses different
Audio-DMAC is more make sense for me.

Kuninori Morimoto (4):
  ARM: dts: r8a7790: Tidyup Audio-DMAC channel for DVC
  ARM: dts: r8a7791: Tidyup Audio-DMAC channel for DVC
  ARM: dts: r8a7793: Tidyup Audio-DMAC channel for DVC
  arm64: renesas: r8a7795: Tidyup Audio-DMAC channel for DVC

 arch/arm/boot/dts/r8a7790.dtsi           | 4 ++--
 arch/arm/boot/dts/r8a7791.dtsi           | 4 ++--
 arch/arm/boot/dts/r8a7793.dtsi           | 4 ++--
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
 4 files changed, 8 insertions(+), 8 deletions(-)

-- 
1.9.1

^ permalink raw reply	[flat|nested] 8+ messages in thread

* [PATCH 1/4] ARM: dts: r8a7790: Tidyup Audio-DMAC channel for DVC
  2017-03-07  5:27 [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC Kuninori Morimoto
@ 2017-03-07  5:28 ` Kuninori Morimoto
  2017-03-07  5:29 ` [PATCH 2/4] ARM: dts: r8a7791: " Kuninori Morimoto
                   ` (3 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-03-07  5:28 UTC (permalink / raw)
  To: Simon, Magnus; +Cc: linux-renesas-soc


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current	Audio-DMAC is assigned "rx" as Audio-DMAC0, "tx" as Audio-DMAC1.
Thus, DVC "tx" should be assigned as Audio-DMAC1, instead of Audio-DMAC0.

Because of this, current platform board (using SRC/DVC/SSI)
Playback/Capture both will use same Audio-DMAC0
(but it depends on data path).

First note is that this "rx" and "tx" are from each IP point,
it doesn't mean Playback/Capture.
Second note is that Audio DMAC assigned on DT is only for
Audio-DMAC, Audio-DMAC-peri-peri has no entry.

=> Audio-DMAC
-> Audio-DMAC-peri-peri
-- HW connection

Playback case

	[Mem] => [SRC]--[DVC] -> [SSI]--[Codec]
	      rx ~~~~~~~~~~~~
Capture

	[Mem] <= [DVC]--[SRC] <- [SSI]--[Codec]
	      tx ~~~~~~~~~~~~

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/r8a7790.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7790.dtsi b/arch/arm/boot/dts/r8a7790.dtsi
index 6d10450..9fd4439 100644
--- a/arch/arm/boot/dts/r8a7790.dtsi
+++ b/arch/arm/boot/dts/r8a7790.dtsi
@@ -1740,11 +1740,11 @@
 
 		rcar_sound,dvc {
 			dvc0: dvc-0 {
-				dmas = <&audma0 0xbc>;
+				dmas = <&audma1 0xbc>;
 				dma-names = "tx";
 			};
 			dvc1: dvc-1 {
-				dmas = <&audma0 0xbe>;
+				dmas = <&audma1 0xbe>;
 				dma-names = "tx";
 			};
 		};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 2/4] ARM: dts: r8a7791: Tidyup Audio-DMAC channel for DVC
  2017-03-07  5:27 [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC Kuninori Morimoto
  2017-03-07  5:28 ` [PATCH 1/4] ARM: dts: r8a7790: " Kuninori Morimoto
@ 2017-03-07  5:29 ` Kuninori Morimoto
  2017-03-07  5:29 ` [PATCH 3/4] ARM: dts: r8a7793: " Kuninori Morimoto
                   ` (2 subsequent siblings)
  4 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-03-07  5:29 UTC (permalink / raw)
  To: Simon, Magnus; +Cc: linux-renesas-soc


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current	Audio-DMAC is assigned "rx" as Audio-DMAC0, "tx" as Audio-DMAC1.
Thus, DVC "tx" should be assigned as Audio-DMAC1, instead of Audio-DMAC0.

Because of this, current platform board (using SRC/DVC/SSI)
Playback/Capture both will use same Audio-DMAC0
(but it depends on audio data path).

First note is that this "rx" and "tx" are from each IP point,
it doesn't mean Playback/Capture.
Second note is that Audio DMAC assigned on DT is only for
Audio-DMAC, Audio-DMAC-peri-peri has no entry.

=> Audio-DMAC
-> Audio-DMAC-peri-peri
-- HW connection

Playback case

	[Mem] => [SRC]--[DVC] -> [SSI]--[Codec]
	      rx ~~~~~~~~~~~~
Capture

	[Mem] <= [DVC]--[SRC] <- [SSI]--[Codec]
	      tx ~~~~~~~~~~~~

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/r8a7791.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7791.dtsi b/arch/arm/boot/dts/r8a7791.dtsi
index 9f9e485..d7474af 100644
--- a/arch/arm/boot/dts/r8a7791.dtsi
+++ b/arch/arm/boot/dts/r8a7791.dtsi
@@ -1777,11 +1777,11 @@
 
 		rcar_sound,dvc {
 			dvc0: dvc-0 {
-				dmas = <&audma0 0xbc>;
+				dmas = <&audma1 0xbc>;
 				dma-names = "tx";
 			};
 			dvc1: dvc-1 {
-				dmas = <&audma0 0xbe>;
+				dmas = <&audma1 0xbe>;
 				dma-names = "tx";
 			};
 		};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 3/4] ARM: dts: r8a7793: Tidyup Audio-DMAC channel for DVC
  2017-03-07  5:27 [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC Kuninori Morimoto
  2017-03-07  5:28 ` [PATCH 1/4] ARM: dts: r8a7790: " Kuninori Morimoto
  2017-03-07  5:29 ` [PATCH 2/4] ARM: dts: r8a7791: " Kuninori Morimoto
@ 2017-03-07  5:29 ` Kuninori Morimoto
  2017-03-07  5:30 ` [PATCH 4/4] arm64: renesas: r8a7795: " Kuninori Morimoto
  2017-03-07  6:52 ` [PATCH 0/4] ARM/ARM64: renesas: " Simon Horman
  4 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-03-07  5:29 UTC (permalink / raw)
  To: Simon, Magnus; +Cc: linux-renesas-soc


From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current	Audio-DMAC is assigned "rx" as Audio-DMAC0, "tx" as Audio-DMAC1.
Thus, DVC "tx" should be assigned as Audio-DMAC1, instead of Audio-DMAC0.

Because of this, current platform board (using SRC/DVC/SSI)
Playback/Capture both will use same Audio-DMAC0
(but it depends on audio data path).

First note is that this "rx" and "tx" are from each IP point,
it doesn't mean Playback/Capture.
Second note is that Audio DMAC assigned on DT is only for
Audio-DMAC, Audio-DMAC-peri-peri has no entry.

=> Audio-DMAC
-> Audio-DMAC-peri-peri
-- HW connection

Playback case

	[Mem] => [SRC]--[DVC] -> [SSI]--[Codec]
	      rx ~~~~~~~~~~~~
Capture

	[Mem] <= [DVC]--[SRC] <- [SSI]--[Codec]
	      tx ~~~~~~~~~~~~

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm/boot/dts/r8a7793.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/r8a7793.dtsi b/arch/arm/boot/dts/r8a7793.dtsi
index 48ce21c..d30cc3b 100644
--- a/arch/arm/boot/dts/r8a7793.dtsi
+++ b/arch/arm/boot/dts/r8a7793.dtsi
@@ -1426,11 +1426,11 @@
 
 		rcar_sound,dvc {
 			dvc0: dvc-0 {
-				dmas = <&audma0 0xbc>;
+				dmas = <&audma1 0xbc>;
 				dma-names = "tx";
 			};
 			dvc1: dvc-1 {
-				dmas = <&audma0 0xbe>;
+				dmas = <&audma1 0xbe>;
 				dma-names = "tx";
 			};
 		};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* [PATCH 4/4] arm64: renesas: r8a7795: Tidyup Audio-DMAC channel for DVC
  2017-03-07  5:27 [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC Kuninori Morimoto
                   ` (2 preceding siblings ...)
  2017-03-07  5:29 ` [PATCH 3/4] ARM: dts: r8a7793: " Kuninori Morimoto
@ 2017-03-07  5:30 ` Kuninori Morimoto
  2017-03-07  6:52 ` [PATCH 0/4] ARM/ARM64: renesas: " Simon Horman
  4 siblings, 0 replies; 8+ messages in thread
From: Kuninori Morimoto @ 2017-03-07  5:30 UTC (permalink / raw)
  To: Simon, Magnus; +Cc: linux-renesas-soc

From: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>

Current	Audio-DMAC is assigned "rx" as Audio-DMAC0, "tx" as Audio-DMAC1.
Thus, DVC "tx" should be assigned as Audio-DMAC1, instead of Audio-DMAC0.

Because of this, current platform board (using SRC/DVC/SSI)
Playback/Capture both will use same Audio-DMAC0
(but it depends on audio data path).

First note is that this "rx" and "tx" are from each IP point,
it doesn't mean Playback/Capture.
Second note is that Audio DMAC assigned on DT is only for
Audio-DMAC, Audio-DMAC-peri-peri has no entry.

=> Audio-DMAC
-> Audio-DMAC-peri-peri
-- HW connection

Playback case

	[Mem] => [SRC]--[DVC] -> [SSI]--[Codec]
	      rx ~~~~~~~~~~~~
Capture

	[Mem] <= [DVC]--[SRC] <- [SSI]--[Codec]
	      tx ~~~~~~~~~~~~

Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a7795.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a7795.dtsi b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
index dd681ff..884d2f5 100644
--- a/arch/arm64/boot/dts/renesas/r8a7795.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7795.dtsi
@@ -1085,11 +1085,11 @@
 
 			rcar_sound,dvc {
 				dvc0: dvc-0 {
-					dmas = <&audma0 0xbc>;
+					dmas = <&audma1 0xbc>;
 					dma-names = "tx";
 				};
 				dvc1: dvc-1 {
-					dmas = <&audma0 0xbe>;
+					dmas = <&audma1 0xbe>;
 					dma-names = "tx";
 				};
 			};
-- 
1.9.1

^ permalink raw reply related	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC
  2017-03-07  5:27 [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC Kuninori Morimoto
                   ` (3 preceding siblings ...)
  2017-03-07  5:30 ` [PATCH 4/4] arm64: renesas: r8a7795: " Kuninori Morimoto
@ 2017-03-07  6:52 ` Simon Horman
  2017-03-08  6:18   ` Kuninori Morimoto
  4 siblings, 1 reply; 8+ messages in thread
From: Simon Horman @ 2017-03-07  6:52 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Magnus, linux-renesas-soc

On Tue, Mar 07, 2017 at 05:27:47AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> These fixup DVC Audio-DMAC channel assignment
> which was not same as SRC/SSI policy.
> Because of this (is a little bit excessive),
> current Playback/Capture on each platform
> (= Lager/Koelsch/Gose/Salvator) are using same
> Audio-DMAC0. Playback/Capture uses different
> Audio-DMAC is more make sense for me.

Thanks Morimoto-san,

I have queued these up with the minor tweak to the subject of the last
patch mentioned below.

> Kuninori Morimoto (4):
>   ARM: dts: r8a7790: Tidyup Audio-DMAC channel for DVC
>   ARM: dts: r8a7791: Tidyup Audio-DMAC channel for DVC
>   ARM: dts: r8a7793: Tidyup Audio-DMAC channel for DVC
>   arm64: renesas: r8a7795: Tidyup Audio-DMAC channel for DVC

s/renesas/dts/

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC
  2017-03-07  6:52 ` [PATCH 0/4] ARM/ARM64: renesas: " Simon Horman
@ 2017-03-08  6:18   ` Kuninori Morimoto
  2017-03-10  9:24     ` Simon Horman
  0 siblings, 1 reply; 8+ messages in thread
From: Kuninori Morimoto @ 2017-03-08  6:18 UTC (permalink / raw)
  To: Simon Horman; +Cc: Magnus, linux-renesas-soc


Hi Simon

> > Kuninori Morimoto (4):
> >   ARM: dts: r8a7790: Tidyup Audio-DMAC channel for DVC
> >   ARM: dts: r8a7791: Tidyup Audio-DMAC channel for DVC
> >   ARM: dts: r8a7793: Tidyup Audio-DMAC channel for DVC
> >   arm64: renesas: r8a7795: Tidyup Audio-DMAC channel for DVC
(snip)
> I have queued these up with the minor tweak to the subject of the last
> patch mentioned below.

I could find 1), 4) patch, but couldn't find 2), 3) patch on your branch.

^ permalink raw reply	[flat|nested] 8+ messages in thread

* Re: [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC
  2017-03-08  6:18   ` Kuninori Morimoto
@ 2017-03-10  9:24     ` Simon Horman
  0 siblings, 0 replies; 8+ messages in thread
From: Simon Horman @ 2017-03-10  9:24 UTC (permalink / raw)
  To: Kuninori Morimoto; +Cc: Magnus, linux-renesas-soc

On Wed, Mar 08, 2017 at 06:18:58AM +0000, Kuninori Morimoto wrote:
> 
> Hi Simon
> 
> > > Kuninori Morimoto (4):
> > >   ARM: dts: r8a7790: Tidyup Audio-DMAC channel for DVC
> > >   ARM: dts: r8a7791: Tidyup Audio-DMAC channel for DVC
> > >   ARM: dts: r8a7793: Tidyup Audio-DMAC channel for DVC
> > >   arm64: renesas: r8a7795: Tidyup Audio-DMAC channel for DVC
> (snip)
> > I have queued these up with the minor tweak to the subject of the last
> > patch mentioned below.
> 
> I could find 1), 4) patch, but couldn't find 2), 3) patch on your branch.

Sorry about that, I have added 2) & 3).

^ permalink raw reply	[flat|nested] 8+ messages in thread

end of thread, other threads:[~2017-03-10  9:24 UTC | newest]

Thread overview: 8+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-03-07  5:27 [PATCH 0/4] ARM/ARM64: renesas: Tidyup Audio-DMAC channel for DVC Kuninori Morimoto
2017-03-07  5:28 ` [PATCH 1/4] ARM: dts: r8a7790: " Kuninori Morimoto
2017-03-07  5:29 ` [PATCH 2/4] ARM: dts: r8a7791: " Kuninori Morimoto
2017-03-07  5:29 ` [PATCH 3/4] ARM: dts: r8a7793: " Kuninori Morimoto
2017-03-07  5:30 ` [PATCH 4/4] arm64: renesas: r8a7795: " Kuninori Morimoto
2017-03-07  6:52 ` [PATCH 0/4] ARM/ARM64: renesas: " Simon Horman
2017-03-08  6:18   ` Kuninori Morimoto
2017-03-10  9:24     ` Simon Horman

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox