* [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage
2020-11-11 10:02 [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Wolfram Sang
@ 2020-11-11 10:02 ` Wolfram Sang
2020-11-12 13:20 ` Niklas Söderlund
2020-11-13 5:53 ` Yoshihiro Shimoda
2020-11-11 10:02 ` [PATCH 2/3] mmc: renesas_sdhi: don't hardcode SDIF values Wolfram Sang
` (3 subsequent siblings)
4 siblings, 2 replies; 10+ messages in thread
From: Wolfram Sang @ 2020-11-11 10:02 UTC (permalink / raw)
To: linux-mmc
Cc: linux-renesas-soc, Yoshihiro Shimoda, Niklas Söderlund,
Wolfram Sang
HOST_MODE should have a CTL_ prefix, too. This makes the code more
readable because we immediately know what it is. Also, remove the
hardcoded values with something readable, too.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi_core.c | 24 ++++++++++++++++--------
1 file changed, 16 insertions(+), 8 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 25c6a1993f8e..b3eb0182c4af 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -39,7 +39,15 @@
#include "renesas_sdhi.h"
#include "tmio_mmc.h"
-#define HOST_MODE 0xe4
+#define CTL_HOST_MODE 0xe4
+#define HOST_MODE_GEN2_SDR50_WMODE BIT(0)
+#define HOST_MODE_GEN2_SDR104_WMODE BIT(0)
+#define HOST_MODE_GEN3_WMODE BIT(0)
+#define HOST_MODE_GEN3_BUSWIDTH BIT(8)
+
+#define HOST_MODE_GEN3_16BIT HOST_MODE_GEN3_WMODE
+#define HOST_MODE_GEN3_32BIT (HOST_MODE_GEN3_WMODE | HOST_MODE_GEN3_BUSWIDTH)
+#define HOST_MODE_GEN3_64BIT 0
#define SDHI_VER_GEN2_SDR50 0x490c
#define SDHI_VER_RZ_A1 0x820b
@@ -60,26 +68,26 @@ static void renesas_sdhi_sdbuf_width(struct tmio_mmc_host *host, int width)
*/
switch (sd_ctrl_read16(host, CTL_VERSION)) {
case SDHI_VER_GEN2_SDR50:
- val = (width == 32) ? 0x0001 : 0x0000;
+ val = (width == 32) ? HOST_MODE_GEN2_SDR50_WMODE : 0;
break;
case SDHI_VER_GEN2_SDR104:
- val = (width == 32) ? 0x0000 : 0x0001;
+ val = (width == 32) ? 0 : HOST_MODE_GEN2_SDR104_WMODE;
break;
case SDHI_VER_GEN3_SD:
case SDHI_VER_GEN3_SDMMC:
if (width == 64)
- val = 0x0000;
+ val = HOST_MODE_GEN3_64BIT;
else if (width == 32)
- val = 0x0101;
+ val = HOST_MODE_GEN3_32BIT;
else
- val = 0x0001;
+ val = HOST_MODE_GEN3_16BIT;
break;
default:
/* nothing to do */
return;
}
- sd_ctrl_write16(host, HOST_MODE, val);
+ sd_ctrl_write16(host, CTL_HOST_MODE, val);
}
static int renesas_sdhi_clk_enable(struct tmio_mmc_host *host)
@@ -795,7 +803,7 @@ static int renesas_sdhi_write16_hook(struct tmio_mmc_host *host, int addr)
case CTL_SD_MEM_CARD_OPT:
case CTL_TRANSACTION_CTL:
case CTL_DMA_ENABLE:
- case HOST_MODE:
+ case CTL_HOST_MODE:
if (host->pdata->flags & TMIO_MMC_HAVE_CBSY)
bit = TMIO_STAT_CMD_BUSY;
fallthrough;
--
2.28.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage
2020-11-11 10:02 ` [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage Wolfram Sang
@ 2020-11-12 13:20 ` Niklas Söderlund
2020-11-13 5:53 ` Yoshihiro Shimoda
1 sibling, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2020-11-12 13:20 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc, Yoshihiro Shimoda
Hi Wolfram,
Thanks for your patch.
On 2020-11-11 11:02:42 +0100, Wolfram Sang wrote:
> HOST_MODE should have a CTL_ prefix, too. This makes the code more
> readable because we immediately know what it is. Also, remove the
> hardcoded values with something readable, too.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 24 ++++++++++++++++--------
> 1 file changed, 16 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 25c6a1993f8e..b3eb0182c4af 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -39,7 +39,15 @@
> #include "renesas_sdhi.h"
> #include "tmio_mmc.h"
>
> -#define HOST_MODE 0xe4
> +#define CTL_HOST_MODE 0xe4
> +#define HOST_MODE_GEN2_SDR50_WMODE BIT(0)
> +#define HOST_MODE_GEN2_SDR104_WMODE BIT(0)
> +#define HOST_MODE_GEN3_WMODE BIT(0)
> +#define HOST_MODE_GEN3_BUSWIDTH BIT(8)
> +
> +#define HOST_MODE_GEN3_16BIT HOST_MODE_GEN3_WMODE
> +#define HOST_MODE_GEN3_32BIT (HOST_MODE_GEN3_WMODE | HOST_MODE_GEN3_BUSWIDTH)
> +#define HOST_MODE_GEN3_64BIT 0
>
> #define SDHI_VER_GEN2_SDR50 0x490c
> #define SDHI_VER_RZ_A1 0x820b
> @@ -60,26 +68,26 @@ static void renesas_sdhi_sdbuf_width(struct tmio_mmc_host *host, int width)
> */
> switch (sd_ctrl_read16(host, CTL_VERSION)) {
> case SDHI_VER_GEN2_SDR50:
> - val = (width == 32) ? 0x0001 : 0x0000;
> + val = (width == 32) ? HOST_MODE_GEN2_SDR50_WMODE : 0;
> break;
> case SDHI_VER_GEN2_SDR104:
> - val = (width == 32) ? 0x0000 : 0x0001;
> + val = (width == 32) ? 0 : HOST_MODE_GEN2_SDR104_WMODE;
> break;
> case SDHI_VER_GEN3_SD:
> case SDHI_VER_GEN3_SDMMC:
> if (width == 64)
> - val = 0x0000;
> + val = HOST_MODE_GEN3_64BIT;
> else if (width == 32)
> - val = 0x0101;
> + val = HOST_MODE_GEN3_32BIT;
> else
> - val = 0x0001;
> + val = HOST_MODE_GEN3_16BIT;
> break;
> default:
> /* nothing to do */
> return;
> }
>
> - sd_ctrl_write16(host, HOST_MODE, val);
> + sd_ctrl_write16(host, CTL_HOST_MODE, val);
> }
>
> static int renesas_sdhi_clk_enable(struct tmio_mmc_host *host)
> @@ -795,7 +803,7 @@ static int renesas_sdhi_write16_hook(struct tmio_mmc_host *host, int addr)
> case CTL_SD_MEM_CARD_OPT:
> case CTL_TRANSACTION_CTL:
> case CTL_DMA_ENABLE:
> - case HOST_MODE:
> + case CTL_HOST_MODE:
> if (host->pdata->flags & TMIO_MMC_HAVE_CBSY)
> bit = TMIO_STAT_CMD_BUSY;
> fallthrough;
> --
> 2.28.0
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 10+ messages in thread* RE: [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage
2020-11-11 10:02 ` [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage Wolfram Sang
2020-11-12 13:20 ` Niklas Söderlund
@ 2020-11-13 5:53 ` Yoshihiro Shimoda
1 sibling, 0 replies; 10+ messages in thread
From: Yoshihiro Shimoda @ 2020-11-13 5:53 UTC (permalink / raw)
To: Wolfram Sang, linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org, Niklas Söderlund
Hi Wolfram-san,
> From: Wolfram Sang, Sent: Wednesday, November 11, 2020 7:03 PM
>
> HOST_MODE should have a CTL_ prefix, too. This makes the code more
> readable because we immediately know what it is. Also, remove the
> hardcoded values with something readable, too.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thank you for the patch!
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 2/3] mmc: renesas_sdhi: don't hardcode SDIF values
2020-11-11 10:02 [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Wolfram Sang
2020-11-11 10:02 ` [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage Wolfram Sang
@ 2020-11-11 10:02 ` Wolfram Sang
2020-11-12 13:24 ` Niklas Söderlund
2020-11-11 10:02 ` [PATCH 3/3] mmc: renesas_sdhi: sort includes Wolfram Sang
` (2 subsequent siblings)
4 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2020-11-11 10:02 UTC (permalink / raw)
To: linux-mmc
Cc: linux-renesas-soc, Yoshihiro Shimoda, Niklas Söderlund,
Wolfram Sang
Use a macro to name the hardcoded values. Also, move the SDIF register
definition into the SDHI driver because this is an SDHI extension.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi_core.c | 7 +++++--
drivers/mmc/host/tmio_mmc.h | 1 -
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index b3eb0182c4af..55633826d38c 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -49,6 +49,9 @@
#define HOST_MODE_GEN3_32BIT (HOST_MODE_GEN3_WMODE | HOST_MODE_GEN3_BUSWIDTH)
#define HOST_MODE_GEN3_64BIT 0
+#define CTL_SDIF_MODE 0xe6
+#define SDIF_MODE_HS400 BIT(0)
+
#define SDHI_VER_GEN2_SDR50 0x490c
#define SDHI_VER_RZ_A1 0x820b
/* very old datasheets said 0x490c for SDR104, too. They are wrong! */
@@ -381,7 +384,7 @@ static void renesas_sdhi_hs400_complete(struct mmc_host *mmc)
sd_ctrl_read16(host, CTL_SD_CARD_CLK_CTL));
/* Set HS400 mode */
- sd_ctrl_write16(host, CTL_SDIF_MODE, 0x0001 |
+ sd_ctrl_write16(host, CTL_SDIF_MODE, SDIF_MODE_HS400 |
sd_ctrl_read16(host, CTL_SDIF_MODE));
sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_DT2FF,
@@ -529,7 +532,7 @@ static void renesas_sdhi_reset_hs400_mode(struct tmio_mmc_host *host,
sd_ctrl_read16(host, CTL_SD_CARD_CLK_CTL));
/* Reset HS400 mode */
- sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 &
+ sd_ctrl_write16(host, CTL_SDIF_MODE, ~SDIF_MODE_HS400 &
sd_ctrl_read16(host, CTL_SDIF_MODE));
sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_DT2FF, priv->scc_tappos);
diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
index 9546e542619c..7ff41185896a 100644
--- a/drivers/mmc/host/tmio_mmc.h
+++ b/drivers/mmc/host/tmio_mmc.h
@@ -42,7 +42,6 @@
#define CTL_DMA_ENABLE 0xd8
#define CTL_RESET_SD 0xe0
#define CTL_VERSION 0xe2
-#define CTL_SDIF_MODE 0xe6
/* Definitions for values the CTL_STOP_INTERNAL_ACTION register can take */
#define TMIO_STOP_STP BIT(0)
--
2.28.0
^ permalink raw reply related [flat|nested] 10+ messages in thread* Re: [PATCH 2/3] mmc: renesas_sdhi: don't hardcode SDIF values
2020-11-11 10:02 ` [PATCH 2/3] mmc: renesas_sdhi: don't hardcode SDIF values Wolfram Sang
@ 2020-11-12 13:24 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2020-11-12 13:24 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc, Yoshihiro Shimoda
Hi Wolfram,
Thanks for your work.
On 2020-11-11 11:02:43 +0100, Wolfram Sang wrote:
> Use a macro to name the hardcoded values. Also, move the SDIF register
> definition into the SDHI driver because this is an SDHI extension.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 7 +++++--
> drivers/mmc/host/tmio_mmc.h | 1 -
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index b3eb0182c4af..55633826d38c 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -49,6 +49,9 @@
> #define HOST_MODE_GEN3_32BIT (HOST_MODE_GEN3_WMODE | HOST_MODE_GEN3_BUSWIDTH)
> #define HOST_MODE_GEN3_64BIT 0
>
> +#define CTL_SDIF_MODE 0xe6
> +#define SDIF_MODE_HS400 BIT(0)
> +
> #define SDHI_VER_GEN2_SDR50 0x490c
> #define SDHI_VER_RZ_A1 0x820b
> /* very old datasheets said 0x490c for SDR104, too. They are wrong! */
> @@ -381,7 +384,7 @@ static void renesas_sdhi_hs400_complete(struct mmc_host *mmc)
> sd_ctrl_read16(host, CTL_SD_CARD_CLK_CTL));
>
> /* Set HS400 mode */
> - sd_ctrl_write16(host, CTL_SDIF_MODE, 0x0001 |
> + sd_ctrl_write16(host, CTL_SDIF_MODE, SDIF_MODE_HS400 |
> sd_ctrl_read16(host, CTL_SDIF_MODE));
>
> sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_DT2FF,
> @@ -529,7 +532,7 @@ static void renesas_sdhi_reset_hs400_mode(struct tmio_mmc_host *host,
> sd_ctrl_read16(host, CTL_SD_CARD_CLK_CTL));
>
> /* Reset HS400 mode */
> - sd_ctrl_write16(host, CTL_SDIF_MODE, ~0x0001 &
> + sd_ctrl_write16(host, CTL_SDIF_MODE, ~SDIF_MODE_HS400 &
> sd_ctrl_read16(host, CTL_SDIF_MODE));
>
> sd_scc_write32(host, priv, SH_MOBILE_SDHI_SCC_DT2FF, priv->scc_tappos);
> diff --git a/drivers/mmc/host/tmio_mmc.h b/drivers/mmc/host/tmio_mmc.h
> index 9546e542619c..7ff41185896a 100644
> --- a/drivers/mmc/host/tmio_mmc.h
> +++ b/drivers/mmc/host/tmio_mmc.h
> @@ -42,7 +42,6 @@
> #define CTL_DMA_ENABLE 0xd8
> #define CTL_RESET_SD 0xe0
> #define CTL_VERSION 0xe2
> -#define CTL_SDIF_MODE 0xe6
>
> /* Definitions for values the CTL_STOP_INTERNAL_ACTION register can take */
> #define TMIO_STOP_STP BIT(0)
> --
> 2.28.0
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH 3/3] mmc: renesas_sdhi: sort includes
2020-11-11 10:02 [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Wolfram Sang
2020-11-11 10:02 ` [PATCH 1/3] mmc: renesas_sdhi: improve HOST_MODE usage Wolfram Sang
2020-11-11 10:02 ` [PATCH 2/3] mmc: renesas_sdhi: don't hardcode SDIF values Wolfram Sang
@ 2020-11-11 10:02 ` Wolfram Sang
2020-11-12 13:24 ` Niklas Söderlund
2020-11-13 6:00 ` [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Yoshihiro Shimoda
2020-11-17 11:50 ` Ulf Hansson
4 siblings, 1 reply; 10+ messages in thread
From: Wolfram Sang @ 2020-11-11 10:02 UTC (permalink / raw)
To: linux-mmc
Cc: linux-renesas-soc, Yoshihiro Shimoda, Niklas Söderlund,
Wolfram Sang
Better prevent double includes.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/mmc/host/renesas_sdhi_core.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
index 55633826d38c..bb937411c2ec 100644
--- a/drivers/mmc/host/renesas_sdhi_core.c
+++ b/drivers/mmc/host/renesas_sdhi_core.c
@@ -18,22 +18,22 @@
*
*/
-#include <linux/kernel.h>
#include <linux/clk.h>
-#include <linux/slab.h>
-#include <linux/module.h>
-#include <linux/of_device.h>
-#include <linux/platform_device.h>
-#include <linux/pm_domain.h>
+#include <linux/delay.h>
+#include <linux/kernel.h>
+#include <linux/mfd/tmio.h>
#include <linux/mmc/host.h>
#include <linux/mmc/mmc.h>
#include <linux/mmc/slot-gpio.h>
-#include <linux/mfd/tmio.h>
-#include <linux/sh_dma.h>
-#include <linux/delay.h>
+#include <linux/module.h>
+#include <linux/of_device.h>
#include <linux/pinctrl/consumer.h>
#include <linux/pinctrl/pinctrl-state.h>
+#include <linux/platform_device.h>
+#include <linux/pm_domain.h>
#include <linux/regulator/consumer.h>
+#include <linux/sh_dma.h>
+#include <linux/slab.h>
#include <linux/sys_soc.h>
#include "renesas_sdhi.h"
--
2.28.0
^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 3/3] mmc: renesas_sdhi: sort includes
2020-11-11 10:02 ` [PATCH 3/3] mmc: renesas_sdhi: sort includes Wolfram Sang
@ 2020-11-12 13:24 ` Niklas Söderlund
0 siblings, 0 replies; 10+ messages in thread
From: Niklas Söderlund @ 2020-11-12 13:24 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-mmc, linux-renesas-soc, Yoshihiro Shimoda
Hi Wolfram,
Thanks for your patch.
On 2020-11-11 11:02:44 +0100, Wolfram Sang wrote:
> Better prevent double includes.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/mmc/host/renesas_sdhi_core.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 55633826d38c..bb937411c2ec 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -18,22 +18,22 @@
> *
> */
>
> -#include <linux/kernel.h>
> #include <linux/clk.h>
> -#include <linux/slab.h>
> -#include <linux/module.h>
> -#include <linux/of_device.h>
> -#include <linux/platform_device.h>
> -#include <linux/pm_domain.h>
> +#include <linux/delay.h>
> +#include <linux/kernel.h>
> +#include <linux/mfd/tmio.h>
> #include <linux/mmc/host.h>
> #include <linux/mmc/mmc.h>
> #include <linux/mmc/slot-gpio.h>
> -#include <linux/mfd/tmio.h>
> -#include <linux/sh_dma.h>
> -#include <linux/delay.h>
> +#include <linux/module.h>
> +#include <linux/of_device.h>
> #include <linux/pinctrl/consumer.h>
> #include <linux/pinctrl/pinctrl-state.h>
> +#include <linux/platform_device.h>
> +#include <linux/pm_domain.h>
> #include <linux/regulator/consumer.h>
> +#include <linux/sh_dma.h>
> +#include <linux/slab.h>
> #include <linux/sys_soc.h>
>
> #include "renesas_sdhi.h"
> --
> 2.28.0
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [PATCH 0/3] mmc: renesas_sdhi: generic cleanups
2020-11-11 10:02 [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Wolfram Sang
` (2 preceding siblings ...)
2020-11-11 10:02 ` [PATCH 3/3] mmc: renesas_sdhi: sort includes Wolfram Sang
@ 2020-11-13 6:00 ` Yoshihiro Shimoda
2020-11-17 11:50 ` Ulf Hansson
4 siblings, 0 replies; 10+ messages in thread
From: Yoshihiro Shimoda @ 2020-11-13 6:00 UTC (permalink / raw)
To: Wolfram Sang, linux-mmc@vger.kernel.org
Cc: linux-renesas-soc@vger.kernel.org, Niklas Söderlund
Hi Wolfram-san,
> From: Wolfram Sang, Sent: Wednesday, November 11, 2020 7:03 PM
>
> Here are a few patches fixing cosmetic issues which always annoyed me
> when working on this driver. Patches #1+#2 improve naming and remove
> hardcoded values. Patch #3 sorts the defines. The object files were
> identical here before and after the patchset, as expected.
>
> The patches depend on the series "[PATCH 0/3] mmc: renesas_sdhi:
> refactor SCC reset" and are part of this branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2
Thank you for the patch!
Since I intended to reply on the patch 2/3 with my comment,
I sent my Reviewed-by on the patch 1/3. But, I realized the patch 2/3 was also OK.
So, I sent my Reviewed-by on the cover-letter:
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
Best regards,
Yoshihiro Shimoda
^ permalink raw reply [flat|nested] 10+ messages in thread* Re: [PATCH 0/3] mmc: renesas_sdhi: generic cleanups
2020-11-11 10:02 [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Wolfram Sang
` (3 preceding siblings ...)
2020-11-13 6:00 ` [PATCH 0/3] mmc: renesas_sdhi: generic cleanups Yoshihiro Shimoda
@ 2020-11-17 11:50 ` Ulf Hansson
4 siblings, 0 replies; 10+ messages in thread
From: Ulf Hansson @ 2020-11-17 11:50 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-mmc@vger.kernel.org, Linux-Renesas, Yoshihiro Shimoda,
Niklas Söderlund
On Wed, 11 Nov 2020 at 11:02, Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
>
> Here are a few patches fixing cosmetic issues which always annoyed me
> when working on this driver. Patches #1+#2 improve naming and remove
> hardcoded values. Patch #3 sorts the defines. The object files were
> identical here before and after the patchset, as expected.
>
> The patches depend on the series "[PATCH 0/3] mmc: renesas_sdhi:
> refactor SCC reset" and are part of this branch:
>
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/sdhi/tap_en_v2
>
> Hope you'll like it,
>
> Wolfram
>
>
> Wolfram Sang (3):
> mmc: renesas_sdhi: improve HOST_MODE usage
> mmc: renesas_sdhi: don't hardcode SDIF values
> mmc: renesas_sdhi: sort includes
>
> drivers/mmc/host/renesas_sdhi_core.c | 49 +++++++++++++++++-----------
> drivers/mmc/host/tmio_mmc.h | 1 -
> 2 files changed, 30 insertions(+), 20 deletions(-)
>
Applied for next, thanks!
Kind regards
Uffe
^ permalink raw reply [flat|nested] 10+ messages in thread