[PATCH v2 0/2] media: renesas: vsp1: Fix display pipeline regression

[PATCH v2 0/2] media: renesas: vsp1: Fix display pipeline regression

[Laurent Pinchart]

Hello,

Two commits merged in v7.1-rc1 introduced a regression in the display
pipeline. This series revert them to fix the regression.

The commits were meant to fix v4l2-compliance failures. Those failures
have never caused any issue in production use cases, and have never been
reported as issue by anyone. Reverting the commits is therefore the
safer option, to give us more time to address the v4l2-compliance
failures in a better way.

Laurent Pinchart (2):
  Revert "media: renesas: vsp1: Initialize format on all pads"
  Revert "media: renesas: vsp1: brx: Fix format propagation"

 drivers/media/platform/renesas/vsp1/vsp1_brx.c    | 10 ++--------
 drivers/media/platform/renesas/vsp1/vsp1_entity.c |  2 +-
 2 files changed, 3 insertions(+), 9 deletions(-)


base-commit: 3cd9b7011519c3fffffb7b6752fc7603be52dc1d
-- 
Regards,

Laurent Pinchart

[PATCH v2 1/2] Revert "media: renesas: vsp1: Initialize format on all pads"

[Laurent Pinchart]

This reverts commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6.

The change to format initialization, along with the change to format
propagation in the BRx in commit 937f3e6b51f1 ("media: renesas: vsp1:
brx: Fix format propagation"), broke configuration of the DRM pipeline.
Revert it to fix the regression.

The original commit was meant to fix a v4l2-compliance failure, with no
known userspace applications being affected beside test tools. Reverting
is the simplest option, a more comprehensive fix can be developed (and
tested more thoroughly) later.

Fixes: 133ac42af0a1 ("media: renesas: vsp1: Initialize format on all pads")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_entity.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.c b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
index 1dad9589768c..839b75b62ceb 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_entity.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
@@ -380,7 +380,7 @@ static int vsp1_entity_init_state(struct v4l2_subdev *subdev,
 	unsigned int pad;
 
 	/* Initialize all pad formats with default values. */
-	for (pad = 0; pad < subdev->entity.num_pads; ++pad) {
+	for (pad = 0; pad < subdev->entity.num_pads - 1; ++pad) {
 		struct v4l2_subdev_format format = {
 			.pad = pad,
 			.which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
-- 
Regards,

Laurent Pinchart

[PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Laurent Pinchart]

This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.

The change to format propagation in the BRx broke configuration of the
DRM pipeline. Revert it to fix the regression.

The original commit was meant to fix a v4l2-compliance failure, with no
known userspace applications being affected beside test tools. Reverting
is the simplest option, a more comprehensive fix can be developed (and
tested more thoroughly) later.

Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
---
 drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
 1 file changed, 2 insertions(+), 8 deletions(-)

diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
index b1a2c68e9944..9d93cb8b8e82 100644
--- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
+++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
@@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
 		compose->height = format->height;
 	}
 
-	/*
-	 * Propagate the format code to all pads, and the whole format to the
-	 * source pad.
-	 */
+	/* Propagate the format code to all pads. */
 	if (fmt->pad == BRX_PAD_SINK(0)) {
 		unsigned int i;
 
-		for (i = 0; i < brx->entity.source_pad; ++i) {
+		for (i = 0; i <= brx->entity.source_pad; ++i) {
 			format = v4l2_subdev_state_get_format(state, i);
 			format->code = fmt->format.code;
 		}
-
-		format = v4l2_subdev_state_get_format(state, i);
-		*format = fmt->format;
 	}
 
 done:
-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 1/2] Revert "media: renesas: vsp1: Initialize format on all pads"

[Lad, Prabhakar]

On Wed, May 6, 2026 at 11:00 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> This reverts commit 133ac42af0a1b389e8b7b3dc7c1cc8c30ff162b6.
>
> The change to format initialization, along with the change to format
> propagation in the BRx in commit 937f3e6b51f1 ("media: renesas: vsp1:
> brx: Fix format propagation"), broke configuration of the DRM pipeline.
> Revert it to fix the regression.
>
> The original commit was meant to fix a v4l2-compliance failure, with no
> known userspace applications being affected beside test tools. Reverting
> is the simplest option, a more comprehensive fix can be developed (and
> tested more thoroughly) later.
>
> Fixes: 133ac42af0a1 ("media: renesas: vsp1: Initialize format on all pads")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_entity.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # On RZ/T2H
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar


> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_entity.c b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
> index 1dad9589768c..839b75b62ceb 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_entity.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_entity.c
> @@ -380,7 +380,7 @@ static int vsp1_entity_init_state(struct v4l2_subdev *subdev,
>         unsigned int pad;
>
>         /* Initialize all pad formats with default values. */
> -       for (pad = 0; pad < subdev->entity.num_pads; ++pad) {
> +       for (pad = 0; pad < subdev->entity.num_pads - 1; ++pad) {
>                 struct v4l2_subdev_format format = {
>                         .pad = pad,
>                         .which = sd_state ? V4L2_SUBDEV_FORMAT_TRY
> --
> Regards,
>
> Laurent Pinchart
>
>

Re: [PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Lad, Prabhakar]

On Wed, May 6, 2026 at 10:57 PM Laurent Pinchart
<laurent.pinchart+renesas@ideasonboard.com> wrote:
>
> This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.
>
> The change to format propagation in the BRx broke configuration of the
> DRM pipeline. Revert it to fix the regression.
>
> The original commit was meant to fix a v4l2-compliance failure, with no
> known userspace applications being affected beside test tools. Reverting
> is the simplest option, a more comprehensive fix can be developed (and
> tested more thoroughly) later.
>
> Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
> Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
>
Tested-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com> # On RZ/T2H
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Cheers,
Prabhakar

> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> index b1a2c68e9944..9d93cb8b8e82 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> @@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
>                 compose->height = format->height;
>         }
>
> -       /*
> -        * Propagate the format code to all pads, and the whole format to the
> -        * source pad.
> -        */
> +       /* Propagate the format code to all pads. */
>         if (fmt->pad == BRX_PAD_SINK(0)) {
>                 unsigned int i;
>
> -               for (i = 0; i < brx->entity.source_pad; ++i) {
> +               for (i = 0; i <= brx->entity.source_pad; ++i) {
>                         format = v4l2_subdev_state_get_format(state, i);
>                         format->code = fmt->format.code;
>                 }
> -
> -               format = v4l2_subdev_state_get_format(state, i);
> -               *format = fmt->format;
>         }
>
>  done:
> --
> Regards,
>
> Laurent Pinchart
>
>

Re: [PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Thorsten Leemhuis]

On 5/6/26 23:56, Laurent Pinchart wrote:
> This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.
> 
> The change to format propagation in the BRx broke configuration of the
> DRM pipeline. Revert it to fix the regression.

Laurent, is this still on your radar? From the outside it looks like
this fix for the 7.1 regression should ideally go to Linus this week, as
he ideally wants all known regression fixed by -rc6.

But it's easy to miss things from the outside, so if this is not a
proper regression, the revert obsolete, or something like that, just
mention it.

Ciao, Thorsten

> The original commit was meant to fix a v4l2-compliance failure, with no
> known userspace applications being affected beside test tools. Reverting
> is the simplest option, a more comprehensive fix can be developed (and
> tested more thoroughly) later.
> 
> Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
> Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
>  1 file changed, 2 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> index b1a2c68e9944..9d93cb8b8e82 100644
> --- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> +++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> @@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
>  		compose->height = format->height;
>  	}
>  
> -	/*
> -	 * Propagate the format code to all pads, and the whole format to the
> -	 * source pad.
> -	 */
> +	/* Propagate the format code to all pads. */
>  	if (fmt->pad == BRX_PAD_SINK(0)) {
>  		unsigned int i;
>  
> -		for (i = 0; i < brx->entity.source_pad; ++i) {
> +		for (i = 0; i <= brx->entity.source_pad; ++i) {
>  			format = v4l2_subdev_state_get_format(state, i);
>  			format->code = fmt->format.code;
>  		}
> -
> -		format = v4l2_subdev_state_get_format(state, i);
> -		*format = fmt->format;
>  	}
>  
>  done:

Re: [PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Laurent Pinchart]

Hi Thorsten,

On Wed, May 27, 2026 at 09:35:03AM +0200, Thorsten Leemhuis wrote:
> On 5/6/26 23:56, Laurent Pinchart wrote:
> > This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.
> > 
> > The change to format propagation in the BRx broke configuration of the
> > DRM pipeline. Revert it to fix the regression.
> 
> Laurent, is this still on your radar? From the outside it looks like
> this fix for the 7.1 regression should ideally go to Linus this week, as
> he ideally wants all known regression fixed by -rc6.
> 
> But it's easy to miss things from the outside, so if this is not a
> proper regression, the revert obsolete, or something like that, just
> mention it.

Thank you for the reminder. Hans, Mauro, this series seems to not have
been merged in the media fixes branch. Could you pick it up ?

> > The original commit was meant to fix a v4l2-compliance failure, with no
> > known userspace applications being affected beside test tools. Reverting
> > is the simplest option, a more comprehensive fix can be developed (and
> > tested more thoroughly) later.
> > 
> > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
> > Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
> > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> >  drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
> >  1 file changed, 2 insertions(+), 8 deletions(-)
> > 
> > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > index b1a2c68e9944..9d93cb8b8e82 100644
> > --- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > +++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > @@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
> >  		compose->height = format->height;
> >  	}
> >  
> > -	/*
> > -	 * Propagate the format code to all pads, and the whole format to the
> > -	 * source pad.
> > -	 */
> > +	/* Propagate the format code to all pads. */
> >  	if (fmt->pad == BRX_PAD_SINK(0)) {
> >  		unsigned int i;
> >  
> > -		for (i = 0; i < brx->entity.source_pad; ++i) {
> > +		for (i = 0; i <= brx->entity.source_pad; ++i) {
> >  			format = v4l2_subdev_state_get_format(state, i);
> >  			format->code = fmt->format.code;
> >  		}
> > -
> > -		format = v4l2_subdev_state_get_format(state, i);
> > -		*format = fmt->format;
> >  	}
> >  
> >  done:

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2 2/2] Revert "media: renesas: vsp1: brx: Fix format propagation"

[Laurent Pinchart]

On Wed, May 27, 2026 at 09:48:17AM +0200, Laurent Pinchart wrote:
> On Wed, May 27, 2026 at 09:35:03AM +0200, Thorsten Leemhuis wrote:
> > On 5/6/26 23:56, Laurent Pinchart wrote:
> > > This reverts commit 937f3e6b51f1cea079be9ba642665f2bf8bcc31f.
> > > 
> > > The change to format propagation in the BRx broke configuration of the
> > > DRM pipeline. Revert it to fix the regression.
> > 
> > Laurent, is this still on your radar? From the outside it looks like
> > this fix for the 7.1 regression should ideally go to Linus this week, as
> > he ideally wants all known regression fixed by -rc6.
> > 
> > But it's easy to miss things from the outside, so if this is not a
> > proper regression, the revert obsolete, or something like that, just
> > mention it.
> 
> Thank you for the reminder. Hans, Mauro, this series seems to not have
> been merged in the media fixes branch. Could you pick it up ?

I have sent a pull request:

https://lore.kernel.org/linux-media/20260529102955.GA675012@killaraus.ideasonboard.com

> > > The original commit was meant to fix a v4l2-compliance failure, with no
> > > known userspace applications being affected beside test tools. Reverting
> > > is the simplest option, a more comprehensive fix can be developed (and
> > > tested more thoroughly) later.
> > > 
> > > Reported-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > Closes: https://lore.kernel.org/linux-media/CA+V-a8t481xuwava0nb7uY9CUPqFWZ_8EP0xrK3BgumP7HDcLg@mail.gmail.com
> > > Fixes: 937f3e6b51f1 ("media: renesas: vsp1: brx: Fix format propagation")
> > > Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> > > ---
> > >  drivers/media/platform/renesas/vsp1/vsp1_brx.c | 10 ++--------
> > >  1 file changed, 2 insertions(+), 8 deletions(-)
> > > 
> > > diff --git a/drivers/media/platform/renesas/vsp1/vsp1_brx.c b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > > index b1a2c68e9944..9d93cb8b8e82 100644
> > > --- a/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > > +++ b/drivers/media/platform/renesas/vsp1/vsp1_brx.c
> > > @@ -156,20 +156,14 @@ static int brx_set_format(struct v4l2_subdev *subdev,
> > >  		compose->height = format->height;
> > >  	}
> > >  
> > > -	/*
> > > -	 * Propagate the format code to all pads, and the whole format to the
> > > -	 * source pad.
> > > -	 */
> > > +	/* Propagate the format code to all pads. */
> > >  	if (fmt->pad == BRX_PAD_SINK(0)) {
> > >  		unsigned int i;
> > >  
> > > -		for (i = 0; i < brx->entity.source_pad; ++i) {
> > > +		for (i = 0; i <= brx->entity.source_pad; ++i) {
> > >  			format = v4l2_subdev_state_get_format(state, i);
> > >  			format->code = fmt->format.code;
> > >  		}
> > > -
> > > -		format = v4l2_subdev_state_get_format(state, i);
> > > -		*format = fmt->format;
> > >  	}
> > >  
> > >  done:

-- 
Regards,

Laurent Pinchart