* Re: [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all()
2016-06-17 8:25 ` [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all() Chris Wilson
@ 2016-06-21 8:56 ` Daniel Vetter
2016-06-21 9:15 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Daniel Vetter @ 2016-06-21 8:56 UTC (permalink / raw)
To: Chris Wilson
Cc: dri-devel, intel-gfx, Daniel Vetter, Laurent Pinchart,
David Airlie, linux-renesas-soc
On Fri, Jun 17, 2016 at 09:25:23AM +0100, Chris Wilson wrote:
> Up to now, the recommendation was for drivers to call drm_dev_register()
> followed by drm_connector_register_all(). Now that
> drm_connector_register() is safe against multiple invocations, we can
> move drm_connector_register_all() to drm_dev_register() and not suffer
> from any backwards compatibility issues with drivers not following the
> more rigorous init ordering.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
Ok, merged the driver patches now. Would be good to unexport/static
drm_connector_register_all, and I think there's a few drivers (like vc4)
which open-coded it.
-Daniel
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> index 48ec4b6e8b26..36d390093c92 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -278,7 +278,6 @@ static int rcar_du_remove(struct platform_device *pdev)
> struct rcar_du_device *rcdu = platform_get_drvdata(pdev);
> struct drm_device *ddev = rcdu->ddev;
>
> - drm_connector_unregister_all(ddev);
> drm_dev_unregister(ddev);
>
> if (rcdu->fbdev)
> @@ -360,10 +359,6 @@ static int rcar_du_probe(struct platform_device *pdev)
> if (ret)
> goto error;
>
> - ret = drm_connector_register_all(ddev);
> - if (ret < 0)
> - goto error;
> -
> DRM_INFO("Device %s probed\n", dev_name(&pdev->dev));
>
> return 0;
> --
> 2.8.1
>
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all()
2016-06-17 8:25 ` [PATCH 7/7] drm/rcar-du: Remove redundant calls to drm_connector_register_all() Chris Wilson
2016-06-21 8:56 ` Daniel Vetter
@ 2016-06-21 9:15 ` Laurent Pinchart
1 sibling, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2016-06-21 9:15 UTC (permalink / raw)
To: Chris Wilson
Cc: dri-devel, intel-gfx, Daniel Vetter, David Airlie,
linux-renesas-soc
Hi Chris,
Thank you for the patch.
On Friday 17 Jun 2016 09:25:23 Chris Wilson wrote:
> Up to now, the recommendation was for drivers to call drm_dev_register()
> followed by drm_connector_register_all(). Now that
> drm_connector_register() is safe against multiple invocations, we can
> move drm_connector_register_all() to drm_dev_register() and not suffer
> from any backwards compatibility issues with drivers not following the
> more rigorous init ordering.
>
> Signed-off-by: Chris Wilson <chris@chris-wilson.co.uk>
> Cc: Daniel Vetter <daniel.vetter@ffwll.ch>
> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Cc: David Airlie <airlied@linux.ie>
> Cc: dri-devel@lists.freedesktop.org
> Cc: linux-renesas-soc@vger.kernel.org
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_drv.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> b/drivers/gpu/drm/rcar-du/rcar_du_drv.c index 48ec4b6e8b26..36d390093c92
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_drv.c
> @@ -278,7 +278,6 @@ static int rcar_du_remove(struct platform_device *pdev)
> struct rcar_du_device *rcdu = platform_get_drvdata(pdev);
> struct drm_device *ddev = rcdu->ddev;
>
> - drm_connector_unregister_all(ddev);
> drm_dev_unregister(ddev);
>
> if (rcdu->fbdev)
> @@ -360,10 +359,6 @@ static int rcar_du_probe(struct platform_device *pdev)
> if (ret)
> goto error;
>
> - ret = drm_connector_register_all(ddev);
> - if (ret < 0)
> - goto error;
> -
> DRM_INFO("Device %s probed\n", dev_name(&pdev->dev));
>
> return 0;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread