Linux Renesas SOC kernel development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] drm: rcar-du: Use NULL for table initialisation
Date: Thu, 26 Apr 2018 13:59:56 +0300	[thread overview]
Message-ID: <3899757.qNu51Qhhj6@avalon> (raw)
In-Reply-To: <20180424154003.2604-1-kieran.bingham+renesas@ideasonboard.com>

Hi Kieran,

Thank you for the patch.

On Tuesday, 24 April 2018 18:40:03 EEST Kieran Bingham wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
> 
> Fixes the following warning:
>  linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
>     warning: Using plain integer as NULL pointer
>       CC      drivers/gpu/drm/rcar-du/rcar_du_kms.o
> 
> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same
> VSP") Signed-off-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

and applied to my tree.

> ---
>  drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ef72dff00763..cf5b422fc753
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device
> *rcdu) struct {
>  		struct device_node *np;
>  		unsigned int crtcs_mask;
> -	} vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
> +	} vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
>  	unsigned int vsps_count = 0;
>  	unsigned int cells;
>  	unsigned int i;

-- 
Regards,

Laurent Pinchart

      parent reply	other threads:[~2018-04-26 10:59 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-24 15:40 [PATCH] drm: rcar-du: Use NULL for table initialisation Kieran Bingham
2018-04-24 19:53 ` Vaishali Thakkar
2018-04-25  7:13 ` Simon Horman
2018-04-26 10:59 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3899757.qNu51Qhhj6@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=kieran.bingham+renesas@ideasonboard.com \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox