* [PATCH] drm: rcar-du: Use NULL for table initialisation
@ 2018-04-24 15:40 Kieran Bingham
2018-04-24 19:53 ` Vaishali Thakkar
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Kieran Bingham @ 2018-04-24 15:40 UTC (permalink / raw)
To: Laurent Pinchart, linux-renesas-soc, dri-devel; +Cc: Kieran Bingham
Replace the initialisation of the vsps table with a NULL specifier.
Fixes the following warning:
linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
warning: Using plain integer as NULL pointer
CC drivers/gpu/drm/rcar-du/rcar_du_kms.o
Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP")
Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index ef72dff00763..cf5b422fc753 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
struct {
struct device_node *np;
unsigned int crtcs_mask;
- } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
+ } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
unsigned int vsps_count = 0;
unsigned int cells;
unsigned int i;
--
2.17.0
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] drm: rcar-du: Use NULL for table initialisation
2018-04-24 15:40 [PATCH] drm: rcar-du: Use NULL for table initialisation Kieran Bingham
@ 2018-04-24 19:53 ` Vaishali Thakkar
2018-04-25 7:13 ` Simon Horman
2018-04-26 10:59 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Vaishali Thakkar @ 2018-04-24 19:53 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Laurent Pinchart, linux-renesas-soc, dri-devel
On Tue, Apr 24, 2018 at 9:10 PM, Kieran Bingham
<kieran.bingham+renesas@ideasonboard.com> wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
>
> Fixes the following warning:
> linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
> warning: Using plain integer as NULL pointer
> CC drivers/gpu/drm/rcar-du/rcar_du_kms.o
Hi Kieran,
Change looks ok to me.
> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Vaishali Thakkar <vthakkar@vaishalithakkar.in>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index ef72dff00763..cf5b422fc753 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device *rcdu)
> struct {
> struct device_node *np;
> unsigned int crtcs_mask;
> - } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
> + } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
> unsigned int vsps_count = 0;
> unsigned int cells;
> unsigned int i;
> --
> 2.17.0
>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: rcar-du: Use NULL for table initialisation
2018-04-24 15:40 [PATCH] drm: rcar-du: Use NULL for table initialisation Kieran Bingham
2018-04-24 19:53 ` Vaishali Thakkar
@ 2018-04-25 7:13 ` Simon Horman
2018-04-26 10:59 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Simon Horman @ 2018-04-25 7:13 UTC (permalink / raw)
To: Kieran Bingham; +Cc: Laurent Pinchart, linux-renesas-soc, dri-devel
On Tue, Apr 24, 2018 at 04:40:03PM +0100, Kieran Bingham wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
>
> Fixes the following warning:
> linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
> warning: Using plain integer as NULL pointer
> CC drivers/gpu/drm/rcar-du/rcar_du_kms.o
>
> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same VSP")
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm: rcar-du: Use NULL for table initialisation
2018-04-24 15:40 [PATCH] drm: rcar-du: Use NULL for table initialisation Kieran Bingham
2018-04-24 19:53 ` Vaishali Thakkar
2018-04-25 7:13 ` Simon Horman
@ 2018-04-26 10:59 ` Laurent Pinchart
2 siblings, 0 replies; 4+ messages in thread
From: Laurent Pinchart @ 2018-04-26 10:59 UTC (permalink / raw)
To: Kieran Bingham; +Cc: linux-renesas-soc, dri-devel
Hi Kieran,
Thank you for the patch.
On Tuesday, 24 April 2018 18:40:03 EEST Kieran Bingham wrote:
> Replace the initialisation of the vsps table with a NULL specifier.
>
> Fixes the following warning:
> linux/drivers/gpu/drm/rcar-du/rcar_du_kms.c:483:40:
> warning: Using plain integer as NULL pointer
> CC drivers/gpu/drm/rcar-du/rcar_du_kms.o
>
> Fixes: 3e81374e2014 ("drm: rcar-du: Support multiple sources from the same
> VSP") Signed-off-by: Kieran Bingham
> <kieran.bingham+renesas@ideasonboard.com>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and applied to my tree.
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> b/drivers/gpu/drm/rcar-du/rcar_du_kms.c index ef72dff00763..cf5b422fc753
> 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -480,7 +480,7 @@ static int rcar_du_vsps_init(struct rcar_du_device
> *rcdu) struct {
> struct device_node *np;
> unsigned int crtcs_mask;
> - } vsps[RCAR_DU_MAX_VSPS] = { { 0, }, };
> + } vsps[RCAR_DU_MAX_VSPS] = { { NULL, }, };
> unsigned int vsps_count = 0;
> unsigned int cells;
> unsigned int i;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-04-26 10:59 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-04-24 15:40 [PATCH] drm: rcar-du: Use NULL for table initialisation Kieran Bingham
2018-04-24 19:53 ` Vaishali Thakkar
2018-04-25 7:13 ` Simon Horman
2018-04-26 10:59 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox