Re: GEN2: Initialization of VSP1 failed at upstream v4.8-rc2

[Hiep Cao Minh <cm-hiep@jinso.co.jp>]

Hi Geert,

Thanks for your quick reply!

>> As you know the information about Initialization of VSP1 failed at upstream
>> v4.8-rc2
>>   from the report of "The failure summary report of GEN2 for Linux v4.8-rc2".
>> "[    5.237049] vsp1: probe of fe920000.vsp1 failed with error -38
>> [    5.254664] vsp1: probe of fe928000.vsp1 failed with error -38
>> [    5.272277] vsp1: probe of fe930000.vsp1 failed with error -38
>> [    5.289891] vsp1: probe of fe938000.vsp1 failed with error -38"
>>
>> I have found the patch that causing of this issue:
>> "94fcdf8 [media] v4l: vsp1: Add FCP support"
>>
>> In this patch,
>>
>> "@@ -528,7 +533,7 @@ static int vsp1_pm_runtime_resume(struct device *dev)
>>                          return ret;
>>          }
>>
>> -       return 0;
>> +       return rcar_fcp_enable(vsp1->fcp);
>>   }"
>>
>> vsp1_pm_runtime_resume() function should be returned "0" if it success.
>> I tried to debug this place, and I realize that the rcar_fcp_enable()
>> function returned "-38" during Initialization.
>> That's why the error message occurs.
>> We know that the rcar_fcp_enable() function also returns 0 on success or a
>> negative error code if an error occurs.
>> So, I am thinking of something just before it happens.
> Please see commits d0cd1e773fee06ed "[media] rcar-fcp: Make sure
> rcar_fcp_enable() returns 0 on success" in renesas-drivers and ba75faf43dc60744
> in media-next.
>
> But we indeed need this fix in v4.8, not v4.9.
Thanks for your fixed patch.
I'll re-confirm it on my environment.
Sorry for the late investigation.


Best regards,
Hiep.


> Gr{oetje,eeting}s,
>
>                          Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
>                                  -- Linus Torvalds
>