* [PATCH 04/20] pinctrl: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
@ 2023-02-28 13:01 ` Nick Alcock
2023-02-28 13:02 ` [PATCH 09/20] clk: " Nick Alcock
` (2 subsequent siblings)
3 siblings, 0 replies; 9+ messages in thread
From: Nick Alcock @ 2023-02-28 13:01 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Geert Uytterhoeven,
Linus Walleij, linux-renesas-soc, linux-gpio
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-gpio@vger.kernel.org
---
drivers/pinctrl/renesas/pinctrl-rza1.c | 1 -
drivers/pinctrl/renesas/pinctrl-rza2.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzg2l.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzn1.c | 1 -
drivers/pinctrl/renesas/pinctrl-rzv2m.c | 1 -
5 files changed, 5 deletions(-)
diff --git a/drivers/pinctrl/renesas/pinctrl-rza1.c b/drivers/pinctrl/renesas/pinctrl-rza1.c
index 529c0fc4ec063..48173355a040a 100644
--- a/drivers/pinctrl/renesas/pinctrl-rza1.c
+++ b/drivers/pinctrl/renesas/pinctrl-rza1.c
@@ -1407,4 +1407,3 @@ core_initcall(rza1_pinctrl_init);
MODULE_AUTHOR("Jacopo Mondi <jacopo+renesas@jmondi.org");
MODULE_DESCRIPTION("Pin and gpio controller driver for Reneas RZ/A1 SoC");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rza2.c b/drivers/pinctrl/renesas/pinctrl-rza2.c
index c0a04f1ee994e..40b1326a10776 100644
--- a/drivers/pinctrl/renesas/pinctrl-rza2.c
+++ b/drivers/pinctrl/renesas/pinctrl-rza2.c
@@ -514,4 +514,3 @@ core_initcall(rza2_pinctrl_init);
MODULE_AUTHOR("Chris Brandt <chris.brandt@renesas.com>");
MODULE_DESCRIPTION("Pin and gpio controller driver for RZ/A2 SoC");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
index 5aa3836dbc226..362c3a0baf1df 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
@@ -1561,4 +1561,3 @@ core_initcall(rzg2l_pinctrl_init);
MODULE_AUTHOR("Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>");
MODULE_DESCRIPTION("Pin and gpio controller driver for RZ/G2L family");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rzn1.c b/drivers/pinctrl/renesas/pinctrl-rzn1.c
index 9158c17574923..d73741651419f 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzn1.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzn1.c
@@ -952,4 +952,3 @@ subsys_initcall(_pinctrl_drv_register);
MODULE_AUTHOR("Phil Edworthy <phil.edworthy@renesas.com>");
MODULE_DESCRIPTION("Renesas RZ/N1 pinctrl driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/pinctrl/renesas/pinctrl-rzv2m.c b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
index 3b65a71abd9ac..e5472293bc7fb 100644
--- a/drivers/pinctrl/renesas/pinctrl-rzv2m.c
+++ b/drivers/pinctrl/renesas/pinctrl-rzv2m.c
@@ -1117,4 +1117,3 @@ core_initcall(rzv2m_pinctrl_init);
MODULE_AUTHOR("Phil Edworthy <phil.edworthy@renesas.com>");
MODULE_DESCRIPTION("Pin and gpio controller driver for RZ/V2M");
-MODULE_LICENSE("GPL");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:01 ` [PATCH 04/20] pinctrl: renesas: remove MODULE_LICENSE in non-modules Nick Alcock
@ 2023-02-28 13:02 ` Nick Alcock
2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
2023-03-09 16:14 ` Greg KH
3 siblings, 1 reply; 9+ messages in thread
From: Nick Alcock @ 2023-02-28 13:02 UTC (permalink / raw)
To: mcgrof
Cc: linux-modules, linux-kernel, Hitomi Hasegawa, Geert Uytterhoeven,
Michael Turquette, Stephen Boyd, Philipp Zabel, linux-renesas-soc,
linux-clk
Since commit 8b41fc4454e ("kbuild: create modules.builtin without
Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
are used to identify modules. As a consequence, uses of the macro
in non-modules will cause modprobe to misidentify their containing
object file as a module when it is not (false positives), and modprobe
might succeed rather than failing with a suitable error message.
So remove it in the files in this commit, none of which can be built as
modules.
Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Cc: Luis Chamberlain <mcgrof@kernel.org>
Cc: linux-modules@vger.kernel.org
Cc: linux-kernel@vger.kernel.org
Cc: Hitomi Hasegawa <hasegawa-hitomi@fujitsu.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Michael Turquette <mturquette@baylibre.com>
Cc: Stephen Boyd <sboyd@kernel.org>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Cc: linux-renesas-soc@vger.kernel.org
Cc: linux-clk@vger.kernel.org
---
drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
drivers/clk/renesas/rzg2l-cpg.c | 1 -
3 files changed, 3 deletions(-)
diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
index 684d8937965e0..ba6b5bd67786f 100644
--- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
+++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
@@ -220,4 +220,3 @@ static struct platform_driver rcar_usb2_clock_sel_driver = {
builtin_platform_driver(rcar_usb2_clock_sel_driver);
MODULE_DESCRIPTION("Renesas R-Car USB2 clock selector Driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
index 1a0cdf001b2f2..bfe5dc9a2e36b 100644
--- a/drivers/clk/renesas/renesas-cpg-mssr.c
+++ b/drivers/clk/renesas/renesas-cpg-mssr.c
@@ -1154,4 +1154,3 @@ void __init mssr_mod_reparent(struct mssr_mod_clk *mod_clks,
}
MODULE_DESCRIPTION("Renesas CPG/MSSR Driver");
-MODULE_LICENSE("GPL v2");
diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
index 4bf40f6ccd1d1..93b02cdc98c25 100644
--- a/drivers/clk/renesas/rzg2l-cpg.c
+++ b/drivers/clk/renesas/rzg2l-cpg.c
@@ -1440,4 +1440,3 @@ static int __init rzg2l_cpg_init(void)
subsys_initcall(rzg2l_cpg_init);
MODULE_DESCRIPTION("Renesas RZ/G2L CPG Driver");
-MODULE_LICENSE("GPL v2");
--
2.39.1.268.g9de2f9a303
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:02 ` [PATCH 09/20] clk: " Nick Alcock
@ 2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 14:07 ` Adam Ford
2023-03-20 11:08 ` Nick Alcock
0 siblings, 2 replies; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-02-28 13:45 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Michael Turquette, Stephen Boyd, Philipp Zabel, linux-renesas-soc,
linux-clk, Yoshihiro Shimoda, Adam Ford
Hi Nick,
On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> are used to identify modules. As a consequence, uses of the macro
> in non-modules will cause modprobe to misidentify their containing
> object file as a module when it is not (false positives), and modprobe
> might succeed rather than failing with a suitable error message.
>
> So remove it in the files in this commit, none of which can be built as
> modules.
>
> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
Thanks for your patch!
> drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
tristate. Shimoda-san?
The Beacon Renesom seems to be the only board where this
is wired up, Adam?
> drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
> drivers/clk/renesas/rzg2l-cpg.c | 1 -
> 3 files changed, 3 deletions(-)
>
> diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> index 684d8937965e0..ba6b5bd67786f 100644
> --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> @@ -220,4 +220,3 @@ static struct platform_driver rcar_usb2_clock_sel_driver = {
> builtin_platform_driver(rcar_usb2_clock_sel_driver);
>
> MODULE_DESCRIPTION("Renesas R-Car USB2 clock selector Driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
> index 1a0cdf001b2f2..bfe5dc9a2e36b 100644
> --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
> @@ -1154,4 +1154,3 @@ void __init mssr_mod_reparent(struct mssr_mod_clk *mod_clks,
> }
>
> MODULE_DESCRIPTION("Renesas CPG/MSSR Driver");
> -MODULE_LICENSE("GPL v2");
> diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
> index 4bf40f6ccd1d1..93b02cdc98c25 100644
> --- a/drivers/clk/renesas/rzg2l-cpg.c
> +++ b/drivers/clk/renesas/rzg2l-cpg.c
> @@ -1440,4 +1440,3 @@ static int __init rzg2l_cpg_init(void)
> subsys_initcall(rzg2l_cpg_init);
>
> MODULE_DESCRIPTION("Renesas RZ/G2L CPG Driver");
> -MODULE_LICENSE("GPL v2");
> --
> 2.39.1.268.g9de2f9a303
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:45 ` Geert Uytterhoeven
@ 2023-02-28 14:07 ` Adam Ford
2023-03-20 11:08 ` Nick Alcock
1 sibling, 0 replies; 9+ messages in thread
From: Adam Ford @ 2023-02-28 14:07 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nick Alcock, mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Michael Turquette, Stephen Boyd, Philipp Zabel, linux-renesas-soc,
linux-clk, Yoshihiro Shimoda
On Tue, Feb 28, 2023 at 7:46 AM Geert Uytterhoeven <geert@linux-m68k.org> wrote:
>
> Hi Nick,
>
> On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> > Since commit 8b41fc4454e ("kbuild: create modules.builtin without
> > Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
> > are used to identify modules. As a consequence, uses of the macro
> > in non-modules will cause modprobe to misidentify their containing
> > object file as a module when it is not (false positives), and modprobe
> > might succeed rather than failing with a suitable error message.
> >
> > So remove it in the files in this commit, none of which can be built as
> > modules.
> >
> > Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
> > Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Thanks for your patch!
>
> > drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
>
> I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
> tristate. Shimoda-san?
> The Beacon Renesom seems to be the only board where this
> is wired up, Adam?
The CLK_RCAR_USB2_CLOCK_SEL is basically glue that lets the user
select between an external oscillator or a crystal oscillator. The
Beacon board uses an external clock instead of a crystal, so this
driver is plumbed in to make sure the external clock is enabled on
demand and the SoC isn't trying to excite the crystal.
The CLK_RCAR_USB2_CLOCK_SEL is currently set to 'y' in the defconfig,
but it looks like the USB_RENESAS_USB3 and USB_RENESAS_USBHS drivers
are all modules. I am not an expert in this area, but it seems to me
like the CLK_RCAR_USB2_CLOCK_SEL could likely be tri-state as well. I
am not sure how the dependency and/or loading order would be
established.
adam
>
> > drivers/clk/renesas/renesas-cpg-mssr.c | 1 -
> > drivers/clk/renesas/rzg2l-cpg.c | 1 -
> > 3 files changed, 3 deletions(-)
> >
> > diff --git a/drivers/clk/renesas/rcar-usb2-clock-sel.c b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > index 684d8937965e0..ba6b5bd67786f 100644
> > --- a/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > +++ b/drivers/clk/renesas/rcar-usb2-clock-sel.c
> > @@ -220,4 +220,3 @@ static struct platform_driver rcar_usb2_clock_sel_driver = {
> > builtin_platform_driver(rcar_usb2_clock_sel_driver);
> >
> > MODULE_DESCRIPTION("Renesas R-Car USB2 clock selector Driver");
> > -MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/clk/renesas/renesas-cpg-mssr.c b/drivers/clk/renesas/renesas-cpg-mssr.c
> > index 1a0cdf001b2f2..bfe5dc9a2e36b 100644
> > --- a/drivers/clk/renesas/renesas-cpg-mssr.c
> > +++ b/drivers/clk/renesas/renesas-cpg-mssr.c
> > @@ -1154,4 +1154,3 @@ void __init mssr_mod_reparent(struct mssr_mod_clk *mod_clks,
> > }
> >
> > MODULE_DESCRIPTION("Renesas CPG/MSSR Driver");
> > -MODULE_LICENSE("GPL v2");
> > diff --git a/drivers/clk/renesas/rzg2l-cpg.c b/drivers/clk/renesas/rzg2l-cpg.c
> > index 4bf40f6ccd1d1..93b02cdc98c25 100644
> > --- a/drivers/clk/renesas/rzg2l-cpg.c
> > +++ b/drivers/clk/renesas/rzg2l-cpg.c
> > @@ -1440,4 +1440,3 @@ static int __init rzg2l_cpg_init(void)
> > subsys_initcall(rzg2l_cpg_init);
> >
> > MODULE_DESCRIPTION("Renesas RZ/G2L CPG Driver");
> > -MODULE_LICENSE("GPL v2");
> > --
> > 2.39.1.268.g9de2f9a303
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 09/20] clk: renesas: remove MODULE_LICENSE in non-modules
2023-02-28 13:45 ` Geert Uytterhoeven
2023-02-28 14:07 ` Adam Ford
@ 2023-03-20 11:08 ` Nick Alcock
1 sibling, 0 replies; 9+ messages in thread
From: Nick Alcock @ 2023-03-20 11:08 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: mcgrof, linux-modules, linux-kernel, Hitomi Hasegawa,
Michael Turquette, Stephen Boyd, Philipp Zabel, linux-renesas-soc,
linux-clk, Yoshihiro Shimoda, Adam Ford
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> Hi Nick,
>
> On Tue, Feb 28, 2023 at 2:03 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> Since commit 8b41fc4454e ("kbuild: create modules.builtin without
>> Makefile.modbuiltin or tristate.conf"), MODULE_LICENSE declarations
>> are used to identify modules. As a consequence, uses of the macro
>> in non-modules will cause modprobe to misidentify their containing
>> object file as a module when it is not (false positives), and modprobe
>> might succeed rather than failing with a suitable error message.
>>
>> So remove it in the files in this commit, none of which can be built as
>> modules.
>>
>> Signed-off-by: Nick Alcock <nick.alcock@oracle.com>
>> Suggested-by: Luis Chamberlain <mcgrof@kernel.org>
>
> Thanks for your patch!
>
>> drivers/clk/renesas/rcar-usb2-clock-sel.c | 1 -
>
> I think it would make sense to make CLK_RCAR_USB2_CLOCK_SEL
> tristate. Shimoda-san?
This patch touches three files, so I hope that means the MODULE_LICENSE
removal from drivers/clk/renesas/renesas-cpg-mssr.c and
drivers/clk/renesas/rzg2l-cpg.c is OK :)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
2023-02-28 13:01 ` [PATCH 04/20] pinctrl: renesas: remove MODULE_LICENSE in non-modules Nick Alcock
2023-02-28 13:02 ` [PATCH 09/20] clk: " Nick Alcock
@ 2023-02-28 13:47 ` Geert Uytterhoeven
2023-03-20 11:06 ` Nick Alcock
2023-03-09 16:14 ` Greg KH
3 siblings, 1 reply; 9+ messages in thread
From: Geert Uytterhoeven @ 2023-02-28 13:47 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
Hi Nick,
On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Does this mean you expect us to queue them for v6.3?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-20 11:06 ` Nick Alcock
0 siblings, 0 replies; 9+ messages in thread
From: Nick Alcock @ 2023-03-20 11:06 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Nick Alcock, mcgrof, linux-clk, linux-gpio, linux-kernel,
linux-modules, linux-perf-users, linux-pm, linux-remoteproc,
linux-renesas-soc, linux-riscv, linux-serial, linux-tegra,
linux-trace-devel, linux-trace-kernel
On 28 Feb 2023, Geert Uytterhoeven outgrape:
> On Tue, Feb 28, 2023 at 2:05 PM Nick Alcock <nick.alcock@oracle.com> wrote:
>> This series, based on current modules-next, is part of a treewide cleanup
>> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
>> files/objects that are not tristate. Due to recent changes to kbuild, these
>> uses are now problematic. See the commit logs for more details.
>
> Does this mean you expect us to queue them for v6.3?
> Thanks!
I believe Luis is planning to pull them in around -rc3, hence my
freshening the series up now, getting everyone's tags in, etc.
--
NULL && (void)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 00/20] MODULE_LICENSE removals, fifth tranche
2023-02-28 13:01 [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Nick Alcock
` (2 preceding siblings ...)
2023-02-28 13:47 ` [PATCH 00/20] MODULE_LICENSE removals, fifth tranche Geert Uytterhoeven
@ 2023-03-09 16:14 ` Greg KH
3 siblings, 0 replies; 9+ messages in thread
From: Greg KH @ 2023-03-09 16:14 UTC (permalink / raw)
To: Nick Alcock
Cc: mcgrof, linux-clk, linux-gpio, linux-kernel, linux-modules,
linux-perf-users, linux-pm, linux-remoteproc, linux-renesas-soc,
linux-riscv, linux-serial, linux-tegra, linux-trace-devel,
linux-trace-kernel
On Tue, Feb 28, 2023 at 01:01:55PM +0000, Nick Alcock wrote:
> This series, based on current modules-next, is part of a treewide cleanup
> suggested by Luis Chamberlain, to remove the LICENSE_MODULE usage from
> files/objects that are not tristate. Due to recent changes to kbuild, these
> uses are now problematic. See the commit logs for more details.
Why isn't kbuild fixed instead? These files can have MODULE_AUTHOR()
and other macros when built into the kernel, what is so special about
MODULE_LICENSE() that prevents this from working properly?
There should not be a need to remove these markings in my opinion, why
treat one MODULE_* macro more special than others?
thanks,
greg k-h
^ permalink raw reply [flat|nested] 9+ messages in thread