* [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused [not found] <cover.1733410889.git.jani.nikula@intel.com> @ 2024-12-05 15:03 ` Jani Nikula 2024-12-05 16:02 ` Laurent Pinchart 0 siblings, 1 reply; 3+ messages in thread From: Jani Nikula @ 2024-12-05 15:03 UTC (permalink / raw) To: dri-devel Cc: intel-gfx, jani.nikula, Laurent Pinchart, Kieran Bingham, linux-renesas-soc, Nathan Chancellor Building with clang and and W=1 leads to warning about unused rcar_cmm_read(). Fix by annotating it with __maybe_unused. See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static inline functions for W=1 build"). Signed-off-by: Jani Nikula <jani.nikula@intel.com> --- Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> Cc: linux-renesas-soc@vger.kernel.org Cc: Nathan Chancellor <nathan@kernel.org> --- drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c index 26a2f5ad8ee5..ea52b0af9226 100644 --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c @@ -32,7 +32,7 @@ struct rcar_cmm { } lut; }; -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) { return ioread32(rcmm->base + reg); } -- 2.39.5 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused 2024-12-05 15:03 ` [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused Jani Nikula @ 2024-12-05 16:02 ` Laurent Pinchart 2025-01-09 12:42 ` Jani Nikula 0 siblings, 1 reply; 3+ messages in thread From: Laurent Pinchart @ 2024-12-05 16:02 UTC (permalink / raw) To: Jani Nikula Cc: dri-devel, intel-gfx, Kieran Bingham, linux-renesas-soc, Nathan Chancellor On Thu, Dec 05, 2024 at 05:03:00PM +0200, Jani Nikula wrote: > Building with clang and and W=1 leads to warning about unused > rcar_cmm_read(). Fix by annotating it with __maybe_unused. > > See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static > inline functions for W=1 build"). > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> https://lore.kernel.org/r/20240911095113.GB4470@pendragon.ideasonboard.com I wonder if Dave and Sima are starting to ignore my pull request in the hope I'll switch to using drm-misc :-S I'll send another one. > --- > > Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> > Cc: linux-renesas-soc@vger.kernel.org > Cc: Nathan Chancellor <nathan@kernel.org> > --- > drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c > index 26a2f5ad8ee5..ea52b0af9226 100644 > --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c > +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c > @@ -32,7 +32,7 @@ struct rcar_cmm { > } lut; > }; > > -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) > +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) > { > return ioread32(rcmm->base + reg); > } -- Regards, Laurent Pinchart ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused 2024-12-05 16:02 ` Laurent Pinchart @ 2025-01-09 12:42 ` Jani Nikula 0 siblings, 0 replies; 3+ messages in thread From: Jani Nikula @ 2025-01-09 12:42 UTC (permalink / raw) To: Laurent Pinchart Cc: dri-devel, intel-gfx, Kieran Bingham, linux-renesas-soc, Nathan Chancellor On Thu, 05 Dec 2024, Laurent Pinchart <laurent.pinchart@ideasonboard.com> wrote: > On Thu, Dec 05, 2024 at 05:03:00PM +0200, Jani Nikula wrote: >> Building with clang and and W=1 leads to warning about unused >> rcar_cmm_read(). Fix by annotating it with __maybe_unused. >> >> See also commit 6863f5643dd7 ("kbuild: allow Clang to find unused static >> inline functions for W=1 build"). >> >> Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > https://lore.kernel.org/r/20240911095113.GB4470@pendragon.ideasonboard.com > > I wonder if Dave and Sima are starting to ignore my pull request in the > hope I'll switch to using drm-misc :-S I'll send another one. Have you sent the pull request again? I haven't seen one. BR, Jani. > >> --- >> >> Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com> >> Cc: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com> >> Cc: linux-renesas-soc@vger.kernel.org >> Cc: Nathan Chancellor <nathan@kernel.org> >> --- >> drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c >> index 26a2f5ad8ee5..ea52b0af9226 100644 >> --- a/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c >> +++ b/drivers/gpu/drm/renesas/rcar-du/rcar_cmm.c >> @@ -32,7 +32,7 @@ struct rcar_cmm { >> } lut; >> }; >> >> -static inline int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) >> +static inline __maybe_unused int rcar_cmm_read(struct rcar_cmm *rcmm, u32 reg) >> { >> return ioread32(rcmm->base + reg); >> } -- Jani Nikula, Intel ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-01-09 12:42 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <cover.1733410889.git.jani.nikula@intel.com>
2024-12-05 15:03 ` [PATCH v2 2/3] drm: renesas: rcar-du: annotate rcar_cmm_read() with __maybe_unused Jani Nikula
2024-12-05 16:02 ` Laurent Pinchart
2025-01-09 12:42 ` Jani Nikula
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox