From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: linux-renesas-soc@vger.kernel.org,
Koichiro Den <den@valinux.co.jp>, Vinod Koul <vkoul@kernel.org>,
Frank Li <Frank.Li@kernel.org>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Magnus Damm <magnus.damm@gmail.com>,
dmaengine@vger.kernel.org
Subject: Re: [PATCH 2/3] dmaengine: rcar-dmac: Add missing dma_descriptor_unmap()
Date: Thu, 17 Sep 2026 10:23:07 +0200 [thread overview]
Message-ID: <aqujV8TrgdiZJdEM@ninjato> (raw)
In-Reply-To: <20260917073825.GB4019@killaraus.ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 849 bytes --]
On Thu, Sep 17, 2026 at 10:38:25AM +0300, Laurent Pinchart wrote:
> On Thu, Sep 17, 2026 at 09:12:07AM +0200, Wolfram Sang wrote:
> > From: Koichiro Den <den@valinux.co.jp>
> >
> > Call dma_descriptor_unmap() right after dma_cookie_complete() in the
> > threaded IRQ completion path. Without this, streaming DMA mappings
> > attached to the descriptor are never released and may eventually exhaust
> > DMA mapping resources (e.g. IOVA with an IOMMU or bounce-buffer slots
> > with SWIOTLB), leading to dma_map_* failures.
>
> That looks like a horrible API. It pushes a requirement onto drivers to
> clean up something done by clients, and is completely undocumented.
> Can't those calls be moved somewhere in the DMA engine core ?
In general, I agree. No bandwidth for an API cleanup here, though. It
affects multiple drivers.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
next prev parent reply other threads:[~2026-09-17 8:23 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-17 7:12 [PATCH 0/3] dmaengine: rcar-dmac: collection of small missed fixes Wolfram Sang
2026-09-17 7:12 ` [PATCH 1/3] dmaengine: rcar-dmac: Fix PM usage counter imbalance Wolfram Sang
2026-09-17 7:17 ` Laurent Pinchart
2026-09-17 7:12 ` [PATCH 2/3] dmaengine: rcar-dmac: Add missing dma_descriptor_unmap() Wolfram Sang
2026-09-17 7:38 ` Laurent Pinchart
2026-09-17 8:23 ` Wolfram Sang [this message]
2026-09-17 16:39 ` Frank Li
2026-09-18 13:07 ` Koichiro Den
2026-09-27 12:43 ` Wolfram Sang
2026-09-27 13:11 ` Wolfram Sang
2026-09-29 4:13 ` Koichiro Den
2026-10-09 9:26 ` Vinod Koul
2026-10-09 13:38 ` Wolfram Sang
2026-10-09 9:23 ` Vinod Koul
2026-09-27 12:38 ` Wolfram Sang
2026-09-17 7:12 ` [PATCH 3/3] dmaengine: rcar-dmac: Remove redundant dev_err()/dev_err_probe() Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqujV8TrgdiZJdEM@ninjato \
--to=wsa+renesas@sang-engineering.com \
--cc=Frank.Li@kernel.org \
--cc=den@valinux.co.jp \
--cc=dmaengine@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=magnus.damm@gmail.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox