Re: [PATCH v2 5/5] riscv: dts: spacemit: add Ethernet support for MusePi Pro

From: Troy Mitchell <troy.mitchell@linux.spacemit.com>
To: Vivian Wang <wangruikang@iscas.ac.cn>,
	Troy Mitchell <troy.mitchell@linux.spacemit.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>, Yixun Lan <dlan@gentoo.org>,
	Paul Walmsley <paul.walmsley@sifive.com>,
	Palmer Dabbelt <palmer@dabbelt.com>,
	Albert Ou <aou@eecs.berkeley.edu>,
	Alexandre Ghiti <alex@ghiti.fr>, Yangyu Chen <cyy@cyyself.name>
Cc: devicetree@vger.kernel.org, linux-riscv@lists.infradead.org,
	spacemit@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] riscv: dts: spacemit: add Ethernet support for MusePi Pro
Date: Fri, 10 Oct 2025 14:23:08 +0800	[thread overview]
Message-ID: <08298B8B17A59AAE+aOimTFhG8DqrtfH0@kernel.org> (raw)
In-Reply-To: <f968ca77-6fc0-4485-a13a-2ed83a7e6617@iscas.ac.cn>

On Fri, Oct 10, 2025 at 02:20:50PM +0800, Vivian Wang wrote:
> 
> On 10/10/25 14:13, Vivian Wang wrote:
> > On 10/10/25 09:56, Troy Mitchell wrote:
> >> MusePi Pro features a single RGMII Ethernet port with
> >> PHY reset controlled by GPIO.
> >>
> >> Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> >> ---
> >>  arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts | 23 +++++++++++++++++++++++
> >>  1 file changed, 23 insertions(+)
> >>
> >> diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> >> index 89a35914710bfd15c6ad27cd8d0de7ccf62e2309..e9a53dc7a417117c82f3e467677290bdaeffc845 100644
> >> --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> >> +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> >> @@ -47,6 +47,29 @@ &pdma {
> >>  	status = "okay";
> >>  };
> >>  
> >> +&eth0 {
> > For node orders in board DTS for SpacemiT devices, usually we follow
> > node name order because there's no unit address to go off of here, so
> > for what we have here it should be emmc, eth0, pdma, uart.
> >
> > See e.g. arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts and previous
> > discussion [1].
> >
> > Also, personally I think it would be fine to just add the whole
> > k1-musepi-pro.dts in the same patch instead of splitting it up like
> > this. I feel it would be easier to manage this way. For previous devices
> > these nodes have been added piecemeal mostly because the drivers were
> > being developed in parallel, but if you're going to base this on
> > v6.18-rc1 there shouldn't be dependency problems.
> ... and also almost missed: this should have an ethernet0 alias. In the
> most common boot flow it's read by U-Boot to set mac-address so that
> both U-Boot and Linux use the same MAC address. This allows U-Boot to a
> persistent MAC address rather than having to use a random one.  
Yes, I forgot to add that.. I'll add it in the next version.

Thanks!

                    - Troy
> > Maybe Yixun can chime in about this as well.
> >
> > Thanks,
> > Vivian "dramforever" Wang
> >
> > [1]: https://lore.kernel.org/linux-riscv/CAH1PCMa35n4dnJ94-EHGrJyU3kztQYO8_v2CkD=rid466zv3+A@mail.gmail.com
> >
> 
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv