Re: [PATCH v2 5/5] riscv: dts: spacemit: add Ethernet support for MusePi Pro

[Conor Dooley <conor@kernel.org>]

[-- Attachment #1.1: Type: text/plain, Size: 2206 bytes --]

On Fri, Oct 10, 2025 at 02:20:12PM +0800, Troy Mitchell wrote:
> On Fri, Oct 10, 2025 at 02:13:31PM +0800, Vivian Wang wrote:
> > 
> > On 10/10/25 09:56, Troy Mitchell wrote:
> > > MusePi Pro features a single RGMII Ethernet port with
> > > PHY reset controlled by GPIO.
> > >
> > > Signed-off-by: Troy Mitchell <troy.mitchell@linux.spacemit.com>
> > > ---
> > >  arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts | 23 +++++++++++++++++++++++
> > >  1 file changed, 23 insertions(+)
> > >
> > > diff --git a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> > > index 89a35914710bfd15c6ad27cd8d0de7ccf62e2309..e9a53dc7a417117c82f3e467677290bdaeffc845 100644
> > > --- a/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> > > +++ b/arch/riscv/boot/dts/spacemit/k1-musepi-pro.dts
> > > @@ -47,6 +47,29 @@ &pdma {
> > >  	status = "okay";
> > >  };
> > >  
> > > +&eth0 {
> > 
> > For node orders in board DTS for SpacemiT devices, usually we follow
> > node name order because there's no unit address to go off of here, so
> > for what we have here it should be emmc, eth0, pdma, uart.
> > 
> > See e.g. arch/riscv/boot/dts/spacemit/k1-bananapi-f3.dts and previous
> > discussion [1].
> Thanks for you point out!
> 
> > 
> > Also, personally I think it would be fine to just add the whole
> > k1-musepi-pro.dts in the same patch instead of splitting it up like
> > this. I feel it would be easier to manage this way. For previous devices
> > these nodes have been added piecemeal mostly because the drivers were
> > being developed in parallel, but if you're going to base this on
> > v6.18-rc1 there shouldn't be dependency problems.
> > 
> > Maybe Yixun can chime in about this as well.
> We have talked here [1]
> 
> Personally, I think splitting them makes the commit history clearer.
> I'm happy to merge them if others also think it's more appropriate.

tbh, I don't think it makes much sense to add it piecemeal, you'd then
end up potentially with dozens of commits for new platforms later in the
life of the SoC.
When you're adding new boards, add them in as complete as possible a
state from the beginning.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

[-- Attachment #2: Type: text/plain, Size: 161 bytes --]

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv