public inbox for linux-riscv@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static
@ 2024-08-08  0:27 Charlie Jenkins
  2024-08-11  8:21 ` Alexandre Ghiti
  2024-09-17 16:30 ` patchwork-bot+linux-riscv
  0 siblings, 2 replies; 3+ messages in thread
From: Charlie Jenkins @ 2024-08-08  0:27 UTC (permalink / raw)
  To: Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: linux-riscv, linux-kernel, Charlie Jenkins, kernel test robot

Since this array is only used in this file, it should be static.

Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
Reported-by: kernel test robot <lkp@intel.com>
Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/
---
 arch/riscv/kernel/vendor_extensions/andes.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/riscv/kernel/vendor_extensions/andes.c b/arch/riscv/kernel/vendor_extensions/andes.c
index ec688c88456a..51f302b6d503 100644
--- a/arch/riscv/kernel/vendor_extensions/andes.c
+++ b/arch/riscv/kernel/vendor_extensions/andes.c
@@ -8,7 +8,7 @@
 #include <linux/types.h>
 
 /* All Andes vendor extensions supported in Linux */
-const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = {
+static const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = {
 	__RISCV_ISA_EXT_DATA(xandespmu, RISCV_ISA_VENDOR_EXT_XANDESPMU),
 };
 

---
base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
change-id: 20240807-make_andes_static-ec524bae21f2
-- 
- Charlie


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static
  2024-08-08  0:27 [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static Charlie Jenkins
@ 2024-08-11  8:21 ` Alexandre Ghiti
  2024-09-17 16:30 ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 3+ messages in thread
From: Alexandre Ghiti @ 2024-08-11  8:21 UTC (permalink / raw)
  To: Charlie Jenkins, Paul Walmsley, Palmer Dabbelt, Albert Ou
  Cc: linux-riscv, linux-kernel, kernel test robot

Hi Charlie,

On 08/08/2024 02:27, Charlie Jenkins wrote:
> Since this array is only used in this file, it should be static.
>
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/
> ---
>   arch/riscv/kernel/vendor_extensions/andes.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/kernel/vendor_extensions/andes.c b/arch/riscv/kernel/vendor_extensions/andes.c
> index ec688c88456a..51f302b6d503 100644
> --- a/arch/riscv/kernel/vendor_extensions/andes.c
> +++ b/arch/riscv/kernel/vendor_extensions/andes.c
> @@ -8,7 +8,7 @@
>   #include <linux/types.h>
>   
>   /* All Andes vendor extensions supported in Linux */
> -const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = {
> +static const struct riscv_isa_ext_data riscv_isa_vendor_ext_andes[] = {
>   	__RISCV_ISA_EXT_DATA(xandespmu, RISCV_ISA_VENDOR_EXT_XANDESPMU),
>   };
>   
>
> ---
> base-commit: 8400291e289ee6b2bf9779ff1c83a291501f017b
> change-id: 20240807-make_andes_static-ec524bae21f2


Reviewed-by: Alexandre Ghiti <alexghiti@rivosinc.com>

Thanks,

Alex


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static
  2024-08-08  0:27 [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static Charlie Jenkins
  2024-08-11  8:21 ` Alexandre Ghiti
@ 2024-09-17 16:30 ` patchwork-bot+linux-riscv
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+linux-riscv @ 2024-09-17 16:30 UTC (permalink / raw)
  To: Charlie Jenkins
  Cc: linux-riscv, paul.walmsley, palmer, aou, linux-kernel, lkp

Hello:

This patch was applied to riscv/linux.git (for-next)
by Palmer Dabbelt <palmer@rivosinc.com>:

On Wed, 07 Aug 2024 17:27:42 -0700 you wrote:
> Since this array is only used in this file, it should be static.
> 
> Signed-off-by: Charlie Jenkins <charlie@rivosinc.com>
> Reported-by: kernel test robot <lkp@intel.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202407241530.ej5SVgX1-lkp@intel.com/
> ---
>  arch/riscv/kernel/vendor_extensions/andes.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> [...]

Here is the summary with links:
  - riscv: Make riscv_isa_vendor_ext_andes array static
    https://git.kernel.org/riscv/c/594ffcf4efe5

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2024-09-17 17:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-08-08  0:27 [PATCH] riscv: Make riscv_isa_vendor_ext_andes array static Charlie Jenkins
2024-08-11  8:21 ` Alexandre Ghiti
2024-09-17 16:30 ` patchwork-bot+linux-riscv

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox