[PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[Heikki Krogerus]

Hi guys,

This is a proposal for Kconfig improvement regarding the Synopsys
DesignWare I2C adapter driver.

Changes since v1:

There was one driver that selects I2C_DESIGNWARE_PLATFORM in its
Kconfig which causes an error because I2C_DESIGNWARE_CORE is not
selected.

The drivers Kconfig I'm proposing that we fix by using "depends on"
instead of "select". There are also a number of defconfigs that enable
I2C_DESIGNWARE_PLATFORM that now need to enable I2C_DESIGNWARE_CORE.

The original patch:
https://lore.kernel.org/linux-i2c/20240830111222.2131172-1-heikki.krogerus@linux.intel.com/

thanks,

Heikki Krogerus (7):
  ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
  ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
  arm64: defconfig: enable I2C_DESIGNWARE_CORE with
    I2C_DESIGNWARE_PLATFORM
  mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
  RISC-V: configs: enable I2C_DESIGNWARE_CORE with
    I2C_DESIGNWARE_PLATFORM
  net: txgbe: Fix I2C Kconfig dependencies
  i2c: designware: Group all DesignWare drivers under a single option

 arch/arc/configs/axs101_defconfig             |  1 +
 arch/arc/configs/axs103_defconfig             |  1 +
 arch/arc/configs/axs103_smp_defconfig         |  1 +
 arch/arc/configs/tb10x_defconfig              |  1 +
 arch/arm/configs/hisi_defconfig               |  1 +
 arch/arm/configs/multi_v7_defconfig           |  1 +
 arch/arm/configs/pxa_defconfig                |  1 +
 arch/arm/configs/socfpga_defconfig            |  1 +
 arch/arm/configs/spear13xx_defconfig          |  1 +
 arch/arm/configs/spear3xx_defconfig           |  1 +
 arch/arm/configs/spear6xx_defconfig           |  1 +
 arch/arm64/configs/defconfig                  |  1 +
 arch/mips/configs/generic/board-ocelot.config |  1 +
 arch/riscv/configs/defconfig                  |  1 +
 arch/riscv/configs/nommu_k210_defconfig       |  1 +
 .../riscv/configs/nommu_k210_sdcard_defconfig |  1 +
 drivers/i2c/busses/Kconfig                    | 29 ++++++++++++-------
 drivers/net/ethernet/wangxun/Kconfig          |  3 +-
 18 files changed, 35 insertions(+), 13 deletions(-)

-- 
2.45.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

[PATCH v2 5/7] RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM

[Heikki Krogerus]

The dependency handling of the Synopsys DesignWare I2C
adapter drivers is going to be changed so that the glue
drivers for the PCI and platform buses depend on
I2C_DESIGNWARE_CORE.

Cc: Paul Walmsley <paul.walmsley@sifive.com>
Cc: Palmer Dabbelt <palmer@dabbelt.com>
Cc: Albert Ou <aou@eecs.berkeley.edu>
Cc: linux-riscv@lists.infradead.org
Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
---
 arch/riscv/configs/defconfig                   | 1 +
 arch/riscv/configs/nommu_k210_defconfig        | 1 +
 arch/riscv/configs/nommu_k210_sdcard_defconfig | 1 +
 3 files changed, 3 insertions(+)

diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
index 0d678325444f..a644a798f602 100644
--- a/arch/riscv/configs/defconfig
+++ b/arch/riscv/configs/defconfig
@@ -157,6 +157,7 @@ CONFIG_HW_RANDOM_VIRTIO=y
 CONFIG_HW_RANDOM_JH7110=m
 CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=m
+CONFIG_I2C_DESIGNWARE_CORE=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_I2C_MV64XXX=m
 CONFIG_I2C_RIIC=y
diff --git a/arch/riscv/configs/nommu_k210_defconfig b/arch/riscv/configs/nommu_k210_defconfig
index af9601da4643..87ff5a1233af 100644
--- a/arch/riscv/configs/nommu_k210_defconfig
+++ b/arch/riscv/configs/nommu_k210_defconfig
@@ -58,6 +58,7 @@ CONFIG_I2C=y
 # CONFIG_I2C_COMPAT is not set
 CONFIG_I2C_CHARDEV=y
 # CONFIG_I2C_HELPER_AUTO is not set
+CONFIG_I2C_DESIGNWARE_CORE=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_SPI=y
 # CONFIG_SPI_MEM is not set
diff --git a/arch/riscv/configs/nommu_k210_sdcard_defconfig b/arch/riscv/configs/nommu_k210_sdcard_defconfig
index dd460c649152..95cbd574f291 100644
--- a/arch/riscv/configs/nommu_k210_sdcard_defconfig
+++ b/arch/riscv/configs/nommu_k210_sdcard_defconfig
@@ -50,6 +50,7 @@ CONFIG_DEVTMPFS_MOUNT=y
 CONFIG_I2C=y
 CONFIG_I2C_CHARDEV=y
 # CONFIG_I2C_HELPER_AUTO is not set
+CONFIG_I2C_DESIGNWARE_CORE=y
 CONFIG_I2C_DESIGNWARE_PLATFORM=y
 CONFIG_SPI=y
 # CONFIG_SPI_MEM is not set
-- 
2.45.2


_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[Andi Shyti]

Hi Jarkko, Andy,

...

> Heikki Krogerus (7):
>   ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>   ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>   arm64: defconfig: enable I2C_DESIGNWARE_CORE with
>     I2C_DESIGNWARE_PLATFORM
>   mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>   RISC-V: configs: enable I2C_DESIGNWARE_CORE with
>     I2C_DESIGNWARE_PLATFORM
>   net: txgbe: Fix I2C Kconfig dependencies
>   i2c: designware: Group all DesignWare drivers under a single option

I believe you know this code already, do you mind giving it an
ack?

Thanks,
Andi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[Jarkko Nikula]

On 9/4/24 12:01 AM, Andi Shyti wrote:
> Hi Jarkko, Andy,
> 
> ...
> 
>> Heikki Krogerus (7):
>>    ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>>    ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>>    arm64: defconfig: enable I2C_DESIGNWARE_CORE with
>>      I2C_DESIGNWARE_PLATFORM
>>    mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>>    RISC-V: configs: enable I2C_DESIGNWARE_CORE with
>>      I2C_DESIGNWARE_PLATFORM
>>    net: txgbe: Fix I2C Kconfig dependencies
>>    i2c: designware: Group all DesignWare drivers under a single option
> 
> I believe you know this code already, do you mind giving it an
> ack?
> 
To the patches 1-7/7 in this set:

Acked-by: Jarkko Nikula <jarkko.nikula@linux.intel.com>

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[Andi Shyti]

Hi Heikki,

> Heikki Krogerus (7):
>   ARC: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>   ARM: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>   arm64: defconfig: enable I2C_DESIGNWARE_CORE with
>     I2C_DESIGNWARE_PLATFORM
>   mips: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>   RISC-V: configs: enable I2C_DESIGNWARE_CORE with
>     I2C_DESIGNWARE_PLATFORM
>   net: txgbe: Fix I2C Kconfig dependencies
>   i2c: designware: Group all DesignWare drivers under a single option

Merged to i2c/i2c-host.

Thanks,
Andi

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 5/7] RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM

[Palmer Dabbelt]

On Tue, 03 Sep 2024 07:25:04 PDT (-0700), heikki.krogerus@linux.intel.com wrote:
> The dependency handling of the Synopsys DesignWare I2C
> adapter drivers is going to be changed so that the glue
> drivers for the PCI and platform buses depend on
> I2C_DESIGNWARE_CORE.
>
> Cc: Paul Walmsley <paul.walmsley@sifive.com>
> Cc: Palmer Dabbelt <palmer@dabbelt.com>
> Cc: Albert Ou <aou@eecs.berkeley.edu>
> Cc: linux-riscv@lists.infradead.org
> Signed-off-by: Heikki Krogerus <heikki.krogerus@linux.intel.com>
> ---
>  arch/riscv/configs/defconfig                   | 1 +
>  arch/riscv/configs/nommu_k210_defconfig        | 1 +
>  arch/riscv/configs/nommu_k210_sdcard_defconfig | 1 +
>  3 files changed, 3 insertions(+)
>
> diff --git a/arch/riscv/configs/defconfig b/arch/riscv/configs/defconfig
> index 0d678325444f..a644a798f602 100644
> --- a/arch/riscv/configs/defconfig
> +++ b/arch/riscv/configs/defconfig
> @@ -157,6 +157,7 @@ CONFIG_HW_RANDOM_VIRTIO=y
>  CONFIG_HW_RANDOM_JH7110=m
>  CONFIG_I2C=y
>  CONFIG_I2C_CHARDEV=m
> +CONFIG_I2C_DESIGNWARE_CORE=y
>  CONFIG_I2C_DESIGNWARE_PLATFORM=y
>  CONFIG_I2C_MV64XXX=m
>  CONFIG_I2C_RIIC=y
> diff --git a/arch/riscv/configs/nommu_k210_defconfig b/arch/riscv/configs/nommu_k210_defconfig
> index af9601da4643..87ff5a1233af 100644
> --- a/arch/riscv/configs/nommu_k210_defconfig
> +++ b/arch/riscv/configs/nommu_k210_defconfig
> @@ -58,6 +58,7 @@ CONFIG_I2C=y
>  # CONFIG_I2C_COMPAT is not set
>  CONFIG_I2C_CHARDEV=y
>  # CONFIG_I2C_HELPER_AUTO is not set
> +CONFIG_I2C_DESIGNWARE_CORE=y
>  CONFIG_I2C_DESIGNWARE_PLATFORM=y
>  CONFIG_SPI=y
>  # CONFIG_SPI_MEM is not set
> diff --git a/arch/riscv/configs/nommu_k210_sdcard_defconfig b/arch/riscv/configs/nommu_k210_sdcard_defconfig
> index dd460c649152..95cbd574f291 100644
> --- a/arch/riscv/configs/nommu_k210_sdcard_defconfig
> +++ b/arch/riscv/configs/nommu_k210_sdcard_defconfig
> @@ -50,6 +50,7 @@ CONFIG_DEVTMPFS_MOUNT=y
>  CONFIG_I2C=y
>  CONFIG_I2C_CHARDEV=y
>  # CONFIG_I2C_HELPER_AUTO is not set
> +CONFIG_I2C_DESIGNWARE_CORE=y
>  CONFIG_I2C_DESIGNWARE_PLATFORM=y
>  CONFIG_SPI=y
>  # CONFIG_SPI_MEM is not set

Acked-by: Palmer Dabbelt <palmer@rivosinc.com>

(based on the rest of the thread I'm assuming you're taking these all 
together, which seems saner to me)

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[patchwork-bot+linux-riscv]

Hello:

This patch was applied to riscv/linux.git (fixes)
by Andi Shyti <andi.shyti@kernel.org>:

On Tue,  3 Sep 2024 17:24:59 +0300 you wrote:
> Hi guys,
> 
> This is a proposal for Kconfig improvement regarding the Synopsys
> DesignWare I2C adapter driver.
> 
> Changes since v1:
> 
> [...]

Here is the summary with links:
  - [v2,5/7] RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
    https://git.kernel.org/riscv/c/0175b1d3c6df

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv

Re: [PATCH v2 0/7] i2c: designware: Group all DesignWare drivers under a single option

[Andi Shyti]

Hi,

On Tue, Oct 01, 2024 at 11:35:13AM GMT, patchwork-bot+linux-riscv@kernel.org wrote:
> Hello:
> 
> This patch was applied to riscv/linux.git (fixes)
> by Andi Shyti <andi.shyti@kernel.org>:
> 
> On Tue,  3 Sep 2024 17:24:59 +0300 you wrote:
> > Hi guys,
> > 
> > This is a proposal for Kconfig improvement regarding the Synopsys
> > DesignWare I2C adapter driver.
> > 
> > Changes since v1:
> > 
> > [...]
> 
> Here is the summary with links:
>   - [v2,5/7] RISC-V: configs: enable I2C_DESIGNWARE_CORE with I2C_DESIGNWARE_PLATFORM
>     https://git.kernel.org/riscv/c/0175b1d3c6df

This patch has already been taken and merged to mainline through
i2c.

Andi

> You are awesome, thank you!
> -- 
> Deet-doot-dot, I am a bot.
> https://korg.docs.kernel.org/patchwork/pwbot.html
> 
> 

_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv