From: Atish Patra <atish.patra@linux.dev>
To: "Radim Krčmář" <rkrcmar@ventanamicro.com>, kvm-riscv@lists.infradead.org
Cc: kvm@vger.kernel.org, linux-riscv@lists.infradead.org,
linux-kernel@vger.kernel.org, Anup Patel <anup@brainfault.org>,
Atish Patra <atishp@atishpatra.org>,
Paul Walmsley <paul.walmsley@sifive.com>,
Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Alexandre Ghiti <alex@ghiti.fr>,
Andrew Jones <ajones@ventanamicro.com>
Subject: Re: [PATCH v3 0/2] RISC-V: KVM: VCPU reset fixes
Date: Thu, 22 May 2025 14:43:40 -0700 [thread overview]
Message-ID: <1a7a81fd-cf15-4b54-a805-32d66ced4517@linux.dev> (raw)
In-Reply-To: <20250515143723.2450630-4-rkrcmar@ventanamicro.com>
On 5/15/25 7:37 AM, Radim KrÄmáŠwrote:
> Hello,
>
> the design still requires a discussion.
>
> [v3 1/2] removes most of the additional changes that the KVM capability
> was doing in v2. [v3 2/2] is new and previews a general solution to the
> lack of userspace control over KVM SBI.
>
I am still missing the motivation behind it. If the motivation is SBI
HSM suspend, the PATCH2 doesn't achieve that as it forwards every call
to the user space. Why do you want to control hsm start/stop from the
user space ?
> A possible QEMU implementation for both capabilities can be seen in
> https://github.com/radimkrcmar/qemu/tree/reset_fixes_v3
> The next step would be to forward the HSM ecalls to QEMU.
>
> v2: https://lore.kernel.org/kvm-riscv/20250508142842.1496099-2-rkrcmar@ventanamicro.com/
> v1: https://lore.kernel.org/kvm-riscv/20250403112522.1566629-3-rkrcmar@ventanamicro.com/
>
> Radim Krčmář (2):
> RISC-V: KVM: add KVM_CAP_RISCV_MP_STATE_RESET
> RISC-V: KVM: add KVM_CAP_RISCV_USERSPACE_SBI
>
> Documentation/virt/kvm/api.rst | 22 ++++++++++++++++++++++
> arch/riscv/include/asm/kvm_host.h | 6 ++++++
> arch/riscv/include/asm/kvm_vcpu_sbi.h | 1 +
> arch/riscv/kvm/vcpu.c | 27 ++++++++++++++-------------
> arch/riscv/kvm/vcpu_sbi.c | 27 +++++++++++++++++++++++++--
> arch/riscv/kvm/vm.c | 18 ++++++++++++++++++
> include/uapi/linux/kvm.h | 2 ++
> 7 files changed, 88 insertions(+), 15 deletions(-)
>
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
next prev parent reply other threads:[~2025-05-22 21:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-15 14:37 [PATCH v3 0/2] RISC-V: KVM: VCPU reset fixes Radim Krčmář
2025-05-15 14:37 ` [PATCH v3 1/2] RISC-V: KVM: add KVM_CAP_RISCV_MP_STATE_RESET Radim Krčmář
2025-05-16 12:25 ` Anup Patel
2025-05-19 12:25 ` Radim Krčmář
2025-05-20 15:43 ` Anup Patel
2025-05-15 14:37 ` [PATCH v3 2/2] RISC-V: KVM: add KVM_CAP_RISCV_USERSPACE_SBI Radim Krčmář
2025-05-22 21:43 ` Atish Patra [this message]
2025-05-23 7:17 ` [PATCH v3 0/2] RISC-V: KVM: VCPU reset fixes Radim Krčmář
2025-05-23 8:08 ` Anup Patel
2025-05-23 9:20 ` Radim Krčmář
2025-05-23 17:44 ` Atish Patra
2025-05-24 9:59 ` Anup Patel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a7a81fd-cf15-4b54-a805-32d66ced4517@linux.dev \
--to=atish.patra@linux.dev \
--cc=ajones@ventanamicro.com \
--cc=alex@ghiti.fr \
--cc=anup@brainfault.org \
--cc=aou@eecs.berkeley.edu \
--cc=atishp@atishpatra.org \
--cc=kvm-riscv@lists.infradead.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=rkrcmar@ventanamicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox