* [PATCH] riscv: enable STRICT_DEVMEM by default
@ 2018-02-22 15:39 Christoph Hellwig
2018-02-22 15:54 ` Bart Van Assche
2018-02-26 17:48 ` Palmer Dabbelt
0 siblings, 2 replies; 5+ messages in thread
From: Christoph Hellwig @ 2018-02-22 15:39 UTC (permalink / raw)
To: linux-riscv
No need to enable /dev/mem access on a new port.
Signed-off-by: Christoph Hellwig <hch@lst.de>
---
lib/Kconfig.debug | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
index 6088408ef26c..0c6c2aafe93a 100644
--- a/lib/Kconfig.debug
+++ b/lib/Kconfig.debug
@@ -1968,7 +1968,7 @@ config STRICT_DEVMEM
bool "Filter access to /dev/mem"
depends on MMU && DEVMEM
depends on ARCH_HAS_DEVMEM_IS_ALLOWED
- default y if TILE || PPC || X86 || ARM64
+ default y if TILE || PPC || X86 || ARM64 | RISCV
---help---
If this option is disabled, you allow userspace (root) access to all
of memory, including kernel and userspace memory. Accidental
--
2.14.2
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH] riscv: enable STRICT_DEVMEM by default
2018-02-22 15:39 [PATCH] riscv: enable STRICT_DEVMEM by default Christoph Hellwig
@ 2018-02-22 15:54 ` Bart Van Assche
2018-02-22 15:54 ` Christoph Hellwig
2018-02-26 17:48 ` Palmer Dabbelt
1 sibling, 1 reply; 5+ messages in thread
From: Bart Van Assche @ 2018-02-22 15:54 UTC (permalink / raw)
To: linux-riscv
On Thu, 2018-02-22 at 07:39 -0800, Christoph Hellwig wrote:
> No need to enable /dev/mem access on a new port.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 6088408ef26c..0c6c2aafe93a 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1968,7 +1968,7 @@ config STRICT_DEVMEM
> bool "Filter access to /dev/mem"
> depends on MMU && DEVMEM
> depends on ARCH_HAS_DEVMEM_IS_ALLOWED
> - default y if TILE || PPC || X86 || ARM64
> + default y if TILE || PPC || X86 || ARM64 | RISCV
^
Did you perhaps intend "||" instead of "|"? With that change applied:
Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com
^ permalink raw reply [flat|nested] 5+ messages in thread* [PATCH] riscv: enable STRICT_DEVMEM by default
2018-02-22 15:54 ` Bart Van Assche
@ 2018-02-22 15:54 ` Christoph Hellwig
2018-02-26 18:04 ` Palmer Dabbelt
0 siblings, 1 reply; 5+ messages in thread
From: Christoph Hellwig @ 2018-02-22 15:54 UTC (permalink / raw)
To: linux-riscv
On Thu, Feb 22, 2018 at 03:54:01PM +0000, Bart Van Assche wrote:
> On Thu, 2018-02-22 at 07:39 -0800, Christoph Hellwig wrote:
> > No need to enable /dev/mem access on a new port.
> >
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> > ---
> > lib/Kconfig.debug | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> > index 6088408ef26c..0c6c2aafe93a 100644
> > --- a/lib/Kconfig.debug
> > +++ b/lib/Kconfig.debug
> > @@ -1968,7 +1968,7 @@ config STRICT_DEVMEM
> > bool "Filter access to /dev/mem"
> > depends on MMU && DEVMEM
> > depends on ARCH_HAS_DEVMEM_IS_ALLOWED
> > - default y if TILE || PPC || X86 || ARM64
> > + default y if TILE || PPC || X86 || ARM64 | RISCV
> ^
> Did you perhaps intend "||" instead of "|"? With that change applied:
>
> Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com
Oops, yes.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] riscv: enable STRICT_DEVMEM by default
2018-02-22 15:54 ` Christoph Hellwig
@ 2018-02-26 18:04 ` Palmer Dabbelt
0 siblings, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-02-26 18:04 UTC (permalink / raw)
To: linux-riscv
On Thu, 22 Feb 2018 07:54:42 PST (-0800), Christoph Hellwig wrote:
> On Thu, Feb 22, 2018 at 03:54:01PM +0000, Bart Van Assche wrote:
>> On Thu, 2018-02-22 at 07:39 -0800, Christoph Hellwig wrote:
>> > No need to enable /dev/mem access on a new port.
>> >
>> > Signed-off-by: Christoph Hellwig <hch@lst.de>
>> > ---
>> > lib/Kconfig.debug | 2 +-
>> > 1 file changed, 1 insertion(+), 1 deletion(-)
>> >
>> > diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
>> > index 6088408ef26c..0c6c2aafe93a 100644
>> > --- a/lib/Kconfig.debug
>> > +++ b/lib/Kconfig.debug
>> > @@ -1968,7 +1968,7 @@ config STRICT_DEVMEM
>> > bool "Filter access to /dev/mem"
>> > depends on MMU && DEVMEM
>> > depends on ARCH_HAS_DEVMEM_IS_ALLOWED
>> > - default y if TILE || PPC || X86 || ARM64
>> > + default y if TILE || PPC || X86 || ARM64 | RISCV
>> ^
>> Did you perhaps intend "||" instead of "|"? With that change applied:
>>
>> Reviewed-by: Bart Van Assche <bart.vanassche@wdc.com
>
> Oops, yes.
Thanks.
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] riscv: enable STRICT_DEVMEM by default
2018-02-22 15:39 [PATCH] riscv: enable STRICT_DEVMEM by default Christoph Hellwig
2018-02-22 15:54 ` Bart Van Assche
@ 2018-02-26 17:48 ` Palmer Dabbelt
1 sibling, 0 replies; 5+ messages in thread
From: Palmer Dabbelt @ 2018-02-26 17:48 UTC (permalink / raw)
To: linux-riscv
On Thu, 22 Feb 2018 07:39:41 PST (-0800), Christoph Hellwig wrote:
> No need to enable /dev/mem access on a new port.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
> ---
> lib/Kconfig.debug | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug
> index 6088408ef26c..0c6c2aafe93a 100644
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -1968,7 +1968,7 @@ config STRICT_DEVMEM
> bool "Filter access to /dev/mem"
> depends on MMU && DEVMEM
> depends on ARCH_HAS_DEVMEM_IS_ALLOWED
> - default y if TILE || PPC || X86 || ARM64
> + default y if TILE || PPC || X86 || ARM64 | RISCV
> ---help---
> If this option is disabled, you allow userspace (root) access to all
> of memory, including kernel and userspace memory. Accidental
Looks good to me. I'm queueing this into for-next, as hopefully we won't have
any changes remaining for 4.16.
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-26 18:04 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-22 15:39 [PATCH] riscv: enable STRICT_DEVMEM by default Christoph Hellwig
2018-02-22 15:54 ` Bart Van Assche
2018-02-22 15:54 ` Christoph Hellwig
2018-02-26 18:04 ` Palmer Dabbelt
2018-02-26 17:48 ` Palmer Dabbelt
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox